From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7125AC433DF for ; Fri, 21 Aug 2020 16:28:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 33E4C206DA for ; Fri, 21 Aug 2020 16:28:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="mvQsNqxv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 33E4C206DA Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B368E8D0067; Fri, 21 Aug 2020 12:28:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC0AE8D0013; Fri, 21 Aug 2020 12:28:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93E2A8D0067; Fri, 21 Aug 2020 12:28:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0163.hostedemail.com [216.40.44.163]) by kanga.kvack.org (Postfix) with ESMTP id 776248D0013 for ; Fri, 21 Aug 2020 12:28:11 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 2FFBE180AD817 for ; Fri, 21 Aug 2020 16:28:11 +0000 (UTC) X-FDA: 77175107982.11.swing84_5208f5c2703a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id F05CD180F8B82 for ; Fri, 21 Aug 2020 16:28:10 +0000 (UTC) X-HE-Tag: swing84_5208f5c2703a X-Filterd-Recvd-Size: 5443 Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Fri, 21 Aug 2020 16:28:10 +0000 (UTC) Received: by mail-lj1-f195.google.com with SMTP id y2so2519752ljc.1 for ; Fri, 21 Aug 2020 09:28:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ASBotJZ8EZpsI/eCx5HlBKysI3NgkGBSfRhPo944ZDA=; b=mvQsNqxvDRfKY9x4pIZgEPhlpB930QAuNErYXzNPLu7IhTBgokTUR97DSKDApKmNfS cibjePU5QCWO42UFsCRWQwMu/X9Q9pISUETSOyLv8GDQ7qwMEl4Ib/H3WWqJjSRry3xl 9TU6msunmhJlIGiYjWcVH7a2M3X4BhkWw0G2xvXyrrXNTBchQ9LtnRpmS8/pffU/upUX /kFJp8461OeN+P7fP/3Y2HmjrCgDZQYrsQfpcRdb/+ho08gxWAK1CegzesM559po/s7S QS3/ic98qpHNV6+NY5HcH0fd2uQX7y1u6cKBRJq2fY9JRNDQP1Z7JMuCbauUj7xPMwgM dTgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ASBotJZ8EZpsI/eCx5HlBKysI3NgkGBSfRhPo944ZDA=; b=iQys8B8j3hwtu4wOpnOuDbb8PZBxnLtetxhYZj/pqBh7iWkz3wrWc06zs2N17xALWt I+8hl3RLWwJqPAzEFxrNmo8uXrUqiSHoZzHfQugWLmic4iZUezdi5qciryZ+EZQPWQGn aBG6TrroP4PXsuDMc2cCvs8DX16JTFndlRTcnVQcA/4DCRDqCIenvFNBjqZqn7cfSFIN NksJaMg9S5wqEA95x1QmVTTDz8YAls+av802WPHBU+cjNEAV8y9oOEOcQewaA8UYnv1I ZsJKIH/i1jfju2IzI24LkRAPPba71ClOoSAKLhX6ShHWAAH3f0LqZnzinmVIHzf+lkS0 +XMg== X-Gm-Message-State: AOAM533jAGEuvgUhZGI6Tej3MtOL3MQ0rBazejzlyGHM+3eaWjUXuSkt /eg+r3o9jk3JFhnRSjAEoDzjRhrqjmTxFsZRDgy3iQ== X-Google-Smtp-Source: ABdhPJxBJx48eP7IauIXH6HjOknwmi0SBAJ//UG77vmKK+pXc4hy+ku162ReCSBX43dsu2Kih9HINa4PcVbhBog5/lU= X-Received: by 2002:a2e:96c3:: with SMTP id d3mr1932135ljj.270.1598027287929; Fri, 21 Aug 2020 09:28:07 -0700 (PDT) MIME-Version: 1.0 References: <20200528135444.11508-1-schatzberg.dan@gmail.com> <20200821150405.GA4137@dschatzberg-fedora-PC0Y6AEN.dhcp.thefacebook.com> <20200821160128.GA2233370@carbon.dhcp.thefacebook.com> In-Reply-To: <20200821160128.GA2233370@carbon.dhcp.thefacebook.com> From: Shakeel Butt Date: Fri, 21 Aug 2020 09:27:56 -0700 Message-ID: Subject: Re: [PATCH v6 0/4] Charge loop device i/o to issuing cgroup To: Roman Gushchin Cc: Dan Schatzberg , Jens Axboe , Alexander Viro , Jan Kara , Amir Goldstein , Tejun Heo , Li Zefan , Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Hugh Dickins , Chris Down , Yang Shi , Thomas Gleixner , "Peter Zijlstra (Intel)" , Ingo Molnar , Mathieu Desnoyers , Andrea Arcangeli , "open list:BLOCK LAYER" , open list , "open list:FILESYSTEMS (VFS and infrastructure)" , "open list:CONTROL GROUP (CGROUP)" , "open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: F05CD180F8B82 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 21, 2020 at 9:02 AM Roman Gushchin wrote: > > On Fri, Aug 21, 2020 at 11:04:05AM -0400, Dan Schatzberg wrote: > > On Thu, Aug 20, 2020 at 10:06:44AM -0700, Shakeel Butt wrote: > > > On Thu, May 28, 2020 at 6:55 AM Dan Schatzberg wrote: > > > > > > > > Much of the discussion about this has died down. There's been a > > > > concern raised that we could generalize infrastructure across loop, > > > > md, etc. This may be possible, in the future, but it isn't clear to me > > > > how this would look like. I'm inclined to fix the existing issue with > > > > loop devices now (this is a problem we hit at FB) and address > > > > consolidation with other cases if and when those need to be addressed. > > > > > > > > > > What's the status of this series? > > > > Thanks for reminding me about this. I haven't got any further > > feedback. I'll bug Jens to take a look and see if he has any concerns > > and if not send a rebased version. > > Just as a note, I stole a patch from this series called > "mm: support nesting memalloc_use_memcg()" to use for the bpf memory accounting. > I rewrote the commit log and rebased to the tot with some trivial changes. > > I just sent it upstream: > https://lore.kernel.org/bpf/20200821150134.2581465-1-guro@fb.com/T/#md7edb6b5b940cee1c4d15e3cef17aa8b07328c2e > > It looks like we need it for two independent sub-systems, so I wonder > if we want to route it first through the mm tree as a standalone patch? > Another way is to push that patch to 5.9-rc2 linus tree, so both block and mm branches for 5.10 will have it. (Not sure if that's ok.)