From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37A97C47082 for ; Sat, 5 Jun 2021 06:35:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D974B61358 for ; Sat, 5 Jun 2021 06:35:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D974B61358 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6B6706B0036; Sat, 5 Jun 2021 02:35:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 653FA6B006C; Sat, 5 Jun 2021 02:35:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CD536B006E; Sat, 5 Jun 2021 02:35:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0099.hostedemail.com [216.40.44.99]) by kanga.kvack.org (Postfix) with ESMTP id 180D86B0036 for ; Sat, 5 Jun 2021 02:35:22 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A80DB181AC553 for ; Sat, 5 Jun 2021 06:35:21 +0000 (UTC) X-FDA: 78218708442.13.D1FD0B4 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by imf07.hostedemail.com (Postfix) with ESMTP id 7D994A00090A for ; Sat, 5 Jun 2021 06:35:18 +0000 (UTC) Received: by mail-lf1-f52.google.com with SMTP id n12so10362517lft.10 for ; Fri, 04 Jun 2021 23:35:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Vow0w7T/H4Ok4yA/drin7CQKErICdzTcTT/vrNcM5Q4=; b=cQpKNyLMQiiglbrRjutBB1ddOTJ0H8uhnwCNG/LXy9JI6NoO9lzdOy1HZVNF2AUCgp +p+rCr2qv9jP3GKnpc3t1Irvf17uRHj9MpYhzTGpzCI39q9t/0ZbxDL/kzuO7O2OE07c QD0ofIbb5nPJaakITyoiShuR/SLGOVJC/BN/LDf4cID895GGCjl4AQqtCFK3HGIL5GOf lCrsT6FzE+7Rd18A1PE02wg0GVG+nqn/DWpMgA+f0ryLKukck/9GhajbiUt1BNUe9Wqe szncH+Or4xHWi9+JvrTkdXFEqbOrpxKFnGctU+/59p3/6PKIoRW6xmt7mxsIdmarHhOK c7ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Vow0w7T/H4Ok4yA/drin7CQKErICdzTcTT/vrNcM5Q4=; b=YbrCH4+uzfDfUGMYuyqsCefKC8NEl11u8XwYApr6LbYjei/yFexx92tWeVmOjv/laW FbxHNd1/T7Mx//yOzCpDVLO/TEgY8MfeyU1V7h1oVSjAxul1V+HnIlk5iCu2vEE58bGe qXc6QL+Lvio4Zyp/nORGiROpvdZI7Ne6ihaY9xDDQXl8T7iouZ5oOm41onjDNjxVa00t P0MmBQ+6Thzys/lLs+hXRqqmmRbYWO2gNSekPqw2ElRoXcFID/hlbutkLgex/YsBFu4P bSaRs/gWq/7d6OCdtrRxvGDkPwABHUgZYqRhqMhRpmMd5lWRwYEeOrPpwACPV3RwKnNx VMSA== X-Gm-Message-State: AOAM532TXpRuP3Sb7Ke3ZWxq7IKhBuq0yj6kIGt7rUqmLg0aOcZfpgyt EwHF8Pz8uZcFhX1RpnlUXWqjBMdTAzAsHgwLlA0aRmwnHvg= X-Google-Smtp-Source: ABdhPJwQoGzX28kw7JKRXYgL5n6FP6kpxLErtYAUQ4PvLx/uwUiZYxfr8DzUpLIwdqw3wtn0D5rmMlrCsiM0eKjbe3w= X-Received: by 2002:a05:6512:952:: with SMTP id u18mr4785726lft.83.1622868339254; Fri, 04 Jun 2021 21:45:39 -0700 (PDT) MIME-Version: 1.0 References: <20210604015640.2586269-1-shakeelb@google.com> <20210604061816.3110-1-hdanton@sina.com> <20210605015421.5096-1-hdanton@sina.com> In-Reply-To: From: Shakeel Butt Date: Fri, 4 Jun 2021 21:45:28 -0700 Message-ID: Subject: Re: [PATCH 2/2] memcg: periodically flush the memcg stats To: Tejun Heo Cc: Hillf Danton , Johannes Weiner , Muchun Song , Michal Hocko , Roman Gushchin , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Huang Ying , Andrew Morton , Cgroups , Linux MM , LKML Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=cQpKNyLM; spf=pass (imf07.hostedemail.com: domain of shakeelb@google.com designates 209.85.167.52 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 7D994A00090A X-Stat-Signature: kgo6ghwx51hprjadj8n74t5rwwiqj619 X-HE-Tag: 1622874918-26423 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 4, 2021 at 7:33 PM Tejun Heo wrote: > > On Sat, Jun 05, 2021 at 09:54:21AM +0800, Hillf Danton wrote: > > The cond_resched() in cgroup_rstat_flush_locked() matches its appearence in > > your post [1]. So does unbound IMHO. > > Ah yeah, this either needs CPU_INTENSIVE or UNBOUND, prolly the latter is > better. > I will change the next version to the system_unbound_wq.