From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE27AC433DF for ; Mon, 22 Jun 2020 18:42:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7E6C72073E for ; Mon, 22 Jun 2020 18:42:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="PkWyxttt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E6C72073E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 048116B000E; Mon, 22 Jun 2020 14:42:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F3A416B0010; Mon, 22 Jun 2020 14:42:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E295B6B0022; Mon, 22 Jun 2020 14:42:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0039.hostedemail.com [216.40.44.39]) by kanga.kvack.org (Postfix) with ESMTP id C57636B000E for ; Mon, 22 Jun 2020 14:42:19 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 2F52C1E78D0 for ; Mon, 22 Jun 2020 18:42:19 +0000 (UTC) X-FDA: 76957717998.23.title28_0114e4426e35 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id 0099B389C1 for ; Mon, 22 Jun 2020 18:42:18 +0000 (UTC) X-HE-Tag: title28_0114e4426e35 X-Filterd-Recvd-Size: 3280 Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Mon, 22 Jun 2020 18:42:18 +0000 (UTC) Received: by mail-lj1-f194.google.com with SMTP id 9so20506492ljv.5 for ; Mon, 22 Jun 2020 11:42:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9aX2e0KRVgCu7iM/YzQ9kW8CY4++NvSyG3ZKNDs8dBA=; b=PkWyxtttxziJ7sl0J3cRRVqapHbtXt4kdu65zklL3qMNyj/kjW1Ul758pFfOfq7bc6 vIq4C4PwC6Rlt93ZeCqqhOxf9pF6Rgwm3KfctMtfhrPhEunuiOYxoQIodSkAGBAjfR8q xzyUIeOenWufKMgp6iggI7PqKYqK1589MvKHc4dpa40qgOEfP0EvG9bdKk8YWo8Ob6He FsMNnr04wAZwfZLSOPoNm3SjxtkYkPzfpdrxz13T+dinoILo/fLnB+dQRAE64Un2byUt pHgq7o/3EyZRFF07xl3YG6cAcHeypZ4n5d37OtAYejFZr3KkIzRPD3Jv4UyRTNA6Yf3C P43w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9aX2e0KRVgCu7iM/YzQ9kW8CY4++NvSyG3ZKNDs8dBA=; b=kF/TgXRD9gRfIcnxkScFWRpOzgTLIIjRf0FRi5PrSUmT25gs9wysl0jHRgoeDFRGYk 2zRiqnUCGr8bsvRJ/epyt4xDtbLN0g2w45/trF8Q5Rqh3XeOJOWdh6v0CdQZTxmd9gzg vLLYc0QHvncdBPyFMgGQZXZhgMXy7Pyd0IsHCi6qzHhpUzSgdvXb3vhQREM38IEgKlLQ dxR9eqTil/y1SsR1RBHe+Ql9UZDDIXozCy6c+qeo0oaDam6lUOibj7g3EcyzKT0SCe7m 5joZxO9FEKHyuqaIgFS6jI/2kEd5Nhtid436+cGaEzwXl7sYguTvGDs0OvMD/J3lIDg3 M1CQ== X-Gm-Message-State: AOAM5334UCHcfDLbnWv8/JHsTtDdh07y9HTOlHvwiNXe5amUj4rTRbZ+ heQWK0Q4Vc7IQJfoisYCFH7cQso91ovy5elT4s877w== X-Google-Smtp-Source: ABdhPJwRCFcJmK2mEPD2AfdCfvBCKYaTqaRO4KPnzwM344nnPLVu6HlrS309q7QQ41IdOgsCzHLKXZ2bpzLAvYJB3zg= X-Received: by 2002:a2e:960b:: with SMTP id v11mr9389585ljh.77.1592851336994; Mon, 22 Jun 2020 11:42:16 -0700 (PDT) MIME-Version: 1.0 References: <20200608230654.828134-1-guro@fb.com> <20200608230654.828134-15-guro@fb.com> In-Reply-To: <20200608230654.828134-15-guro@fb.com> From: Shakeel Butt Date: Mon, 22 Jun 2020 11:42:05 -0700 Message-ID: Subject: Re: [PATCH v6 14/19] mm: memcg/slab: remove memcg_kmem_get_cache() To: Roman Gushchin Cc: Andrew Morton , Christoph Lameter , Johannes Weiner , Michal Hocko , Linux MM , Vlastimil Babka , Kernel Team , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 0099B389C1 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 8, 2020 at 4:07 PM Roman Gushchin wrote: > > The memcg_kmem_get_cache() function became really trivial, > so let's just inline it into the single call point: > memcg_slab_pre_alloc_hook(). > > It will make the code less bulky and can also help the compiler > to generate a better code. > > Signed-off-by: Roman Gushchin > Reviewed-by: Vlastimil Babka Reviewed-by: Shakeel Butt