From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A642BC433DF for ; Mon, 22 Jun 2020 17:36:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6B26420732 for ; Mon, 22 Jun 2020 17:36:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="h+1YTyO0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B26420732 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0AF576B0010; Mon, 22 Jun 2020 13:36:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 05DB46B0023; Mon, 22 Jun 2020 13:36:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E8F656B002C; Mon, 22 Jun 2020 13:36:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0144.hostedemail.com [216.40.44.144]) by kanga.kvack.org (Postfix) with ESMTP id CC00B6B0010 for ; Mon, 22 Jun 2020 13:36:35 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 3553C5B5CB for ; Mon, 22 Jun 2020 17:36:35 +0000 (UTC) X-FDA: 76957552350.09.rice56_130eae826e34 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id 097C3180AD822 for ; Mon, 22 Jun 2020 17:36:34 +0000 (UTC) X-HE-Tag: rice56_130eae826e34 X-Filterd-Recvd-Size: 3846 Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Mon, 22 Jun 2020 17:36:34 +0000 (UTC) Received: by mail-lj1-f194.google.com with SMTP id i27so20259381ljb.12 for ; Mon, 22 Jun 2020 10:36:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+uMOcYRhR3VQERG3cveMu1d/XmkJLee7HKQWW5pciSU=; b=h+1YTyO0jwHDlXsWEXi7dChxTynVwk13+1BfbQGc8Gu/VEhzSeG4hxWV2R//d6poCh lnc/eX4VCK+n3HQpWw8jv+0V9kzm753mr4iHTkihl2yFsk4zQ3SP7akUXo9czn6UxM2u GV/ztdnXvpXxXDORP2nD+7/tMj/Av0wGLdmL8JZr6hGK7c4c104vBcbqhPZfsL2jzOku Vn+Z+RVHFJYRjLAbdGnD5+VWMZVcDmfjtBOkGt/HmlfxauUZesS4mB/jR36yiqH6Cp4y R0CEuskHVx7PrlCBhtlTYyNarxRge9zbRBRroGixw6xWuzz1zMOoEqIq3l9nFHgzaYMZ V1pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+uMOcYRhR3VQERG3cveMu1d/XmkJLee7HKQWW5pciSU=; b=EpONFWdBNZKL/EOqerveEe02tg3nrqWN4CgCCIAUd8NLHMOBkObg2l5/CdI62o+s6a JJoRujbbHYN+PVS7HSGEaHyrVFC1AAejQ0igYsadkGFmMdY6ObyOvICFtPY8Mx8BEfsa OelCXOGw+ChZnyVeCiznrq3nSOJo7lHDtvCFPrue/9Y7VreXpJGbHig3pJ2mqeZuGr8H DJPtYKaomFzH8sUCpaNqR9gKuiDWKBJz3Mw3Se2PlUX4We6aKURurP6Pw92EvoA/ANoh BiXVQXw5PnNQ45N+fOf3sTWUJ+cIeQ4SRfIazlFiwdUY0sXImS/7dIcWMdVQ55V3iBxX j6FQ== X-Gm-Message-State: AOAM533Wl+yy7a6CALc85GHIjtBspdiRPAAm9eb1XRjv5MIeNF/HkuqU i7S3MdB3ggg6Ia8Y0XmEZeGg2nT/3GSFryapA22zzA== X-Google-Smtp-Source: ABdhPJz0GXP4YiIJPJAEmUOBfeBrF2UiDL/A+GdRn3H3Q6ZDFWO17mrlWSqZkyZUKyAhH+b51fbW3e9Gp4fwsYLNXHA= X-Received: by 2002:a2e:8754:: with SMTP id q20mr9339481ljj.270.1592847392932; Mon, 22 Jun 2020 10:36:32 -0700 (PDT) MIME-Version: 1.0 References: <20200608230654.828134-1-guro@fb.com> <20200608230654.828134-16-guro@fb.com> In-Reply-To: <20200608230654.828134-16-guro@fb.com> From: Shakeel Butt Date: Mon, 22 Jun 2020 10:36:21 -0700 Message-ID: Subject: Re: [PATCH v6 15/19] mm: memcg/slab: deprecate slab_root_caches To: Roman Gushchin Cc: Andrew Morton , Christoph Lameter , Johannes Weiner , Michal Hocko , Linux MM , Vlastimil Babka , Kernel Team , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 097C3180AD822 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 8, 2020 at 4:07 PM Roman Gushchin wrote: > > Currently there are two lists of kmem_caches: > 1) slab_caches, which contains all kmem_caches, > 2) slab_root_caches, which contains only root kmem_caches. > > And there is some preprocessor magic to have a single list > if CONFIG_MEMCG_KMEM isn't enabled. > > It was required earlier because the number of non-root kmem_caches > was proportional to the number of memory cgroups and could reach > really big values. Now, when it cannot exceed the number of root > kmem_caches, there is really no reason to maintain two lists. > > We never iterate over the slab_root_caches list on any hot paths, > so it's perfectly fine to iterate over slab_caches and filter out > non-root kmem_caches. > > It allows to remove a lot of config-dependent code and two pointers > from the kmem_cache structure. > > Signed-off-by: Roman Gushchin > Reviewed-by: Vlastimil Babka Reviewed-by: Shakeel Butt