From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1C47C54FCB for ; Wed, 22 Apr 2020 22:20:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9559D2077D for ; Wed, 22 Apr 2020 22:20:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="CLGEo+u6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9559D2077D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2B8C18E0006; Wed, 22 Apr 2020 18:20:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2696E8E0003; Wed, 22 Apr 2020 18:20:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 180048E0006; Wed, 22 Apr 2020 18:20:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0029.hostedemail.com [216.40.44.29]) by kanga.kvack.org (Postfix) with ESMTP id F29538E0003 for ; Wed, 22 Apr 2020 18:20:28 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B31BB8248047 for ; Wed, 22 Apr 2020 22:20:28 +0000 (UTC) X-FDA: 76736910936.26.duck10_424d97de2011 X-HE-Tag: duck10_424d97de2011 X-Filterd-Recvd-Size: 3751 Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Wed, 22 Apr 2020 22:20:28 +0000 (UTC) Received: by mail-lf1-f65.google.com with SMTP id 131so3069785lfh.11 for ; Wed, 22 Apr 2020 15:20:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7RkYliGFMdqXvO717N2pm4NnCZwapAsCgxwoREIwOrQ=; b=CLGEo+u6Ol6OoAJw6QXk0qHvTJvCNzFarr5oZ0N0OMVK0XtleuSdVK7pspDWG+k8jZ Fm6/J0Sa0R+dGQWLaH2Zbx07U2d3gIJZb/HPrE7IkZdmhaPk23GjxGZsP3sxqcHhkuVA JFsolmPT4jwkqogLz/cwAuqgpFa1+OvRlp9T/mP0vAcqFi9KKYNHf8q8DT6m0kVrJ82t ETNo6nwSIlWJd3Fqek4NNLkYj1sNQgBMjr3ocYfmpru/Jzn4futMt2nX5p4XBcZb4SMq bxL7eaGouhPxxZIK/cYUP5Ge4aZsfSmKI5MYbgEpRXPj6Idx+OiBwCRD++V/dck67C/g FrlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7RkYliGFMdqXvO717N2pm4NnCZwapAsCgxwoREIwOrQ=; b=flwlgx/iLoyQ2FuXq6ha4igJr26GYiBiHzkJnmDOVpPA/5sOhp/3ywtY/uXE+473ec 1wRi09XX0isW2FusyPYi6JuNStY39XucecAlHqS19G8suelIhkDkahkt5d5djxqaYmdv cRzYgVODRQnWQoHt/+A5EM7LCwWCbbqlT4Bw+xDznzyGhkxKSafYwDL0duqqen7nxX72 yfWTnc0ynqIy3BPx0keoCnGv9/wOU8lNv+GKPuud41arQWzqidjvV8xtPbw+S9+ZMmu5 S1MShjFw5y3TI8KswB8hRkuvVNNE9IZ3RHb7lz2ZqJnOTNOfSMkfML9rEjsjLNNdgG+z HO7w== X-Gm-Message-State: AGi0PuYvlKbWS9ei+pjBt+buBAWYNR8wAxIDGm1B0nVB6OUXH1LeJsl7 FQ7tWd5su9CGAQ3fmjGmF+dDC0h6N4zcad84nx+YzA== X-Google-Smtp-Source: APiQypLuGzni3dbzxyWjvGmOnHKp8BVo+fq+dqIX0XL8GnwTi7ZNuCZ6m9ZR7aVz8TjHNTWYSEjuLpXd5DXELLsIdxc= X-Received: by 2002:ac2:5e65:: with SMTP id a5mr424101lfr.189.1587594026577; Wed, 22 Apr 2020 15:20:26 -0700 (PDT) MIME-Version: 1.0 References: <20200420221126.341272-1-hannes@cmpxchg.org> <20200420221126.341272-5-hannes@cmpxchg.org> In-Reply-To: <20200420221126.341272-5-hannes@cmpxchg.org> From: Shakeel Butt Date: Wed, 22 Apr 2020 15:20:15 -0700 Message-ID: Subject: Re: [PATCH 04/18] mm: memcontrol: move out cgroup swaprate throttling To: Johannes Weiner Cc: Joonsoo Kim , Alex Shi , Hugh Dickins , Michal Hocko , "Kirill A. Shutemov" , Roman Gushchin , Linux MM , Cgroups , LKML , Kernel Team Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 20, 2020 at 3:11 PM Johannes Weiner wrote: > > The cgroup swaprate throttling is about matching new anon allocations > to the rate of available IO when that is being throttled. It's the io > controller hooking into the VM, rather than a memory controller thing. > > Rename mem_cgroup_throttle_swaprate() to cgroup_throttle_swaprate(), > and drop the @memcg argument which is only used to check whether the > preceding page charge has succeeded and the fault is proceeding. > > We could decouple the call from mem_cgroup_try_charge() here as well, > but that would cause unnecessary churn: the following patches convert > all callsites to a new charge API and we'll decouple as we go along. > > Signed-off-by: Johannes Weiner Reviewed-by: Shakeel Butt