From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 450A2C4338F for ; Mon, 2 Aug 2021 20:05:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C251B61051 for ; Mon, 2 Aug 2021 20:05:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C251B61051 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 012BD8D0001; Mon, 2 Aug 2021 16:05:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F05296B0036; Mon, 2 Aug 2021 16:05:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF33A8D0001; Mon, 2 Aug 2021 16:05:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0004.hostedemail.com [216.40.44.4]) by kanga.kvack.org (Postfix) with ESMTP id C2AF06B0033 for ; Mon, 2 Aug 2021 16:05:16 -0400 (EDT) Received: from smtpin37.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 6FF9E181AEF1D for ; Mon, 2 Aug 2021 20:05:16 +0000 (UTC) X-FDA: 78431219832.37.F91FD2B Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by imf18.hostedemail.com (Postfix) with ESMTP id 31B0F400332D for ; Mon, 2 Aug 2021 20:05:15 +0000 (UTC) Received: by mail-lf1-f53.google.com with SMTP id x8so22521519lfe.3 for ; Mon, 02 Aug 2021 13:05:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HB3dfAanD6v/DibZ+Kd9MP5PZZX+18PKh7cDBPxAeHs=; b=ptyOG8hVKeJFevLxjCDUGzEhuSpZVEdMhDg+ywQnIWCracEKgYNJi9MyuD507zg3Eq doKw0YYpy3+9o+JFlSBQTwidtTbAq/pCC0+1OUtEuGXvon5JYsygoPX6N6QUxPNwLecd dGRPriNZp5jImD5F5U8MlOwLn3i0kGKTMQu8TVzPmTftKU/9lo7bbqVTkkpuKAx/PUSW jiBeP+zM1R/b4geXHK+h+upY1oHpTKGY01BvxD0hnkWN9TGqJgSlpJHuDvg7R3BlOky5 4GgMumBWGK6P4QfI9acGmi0hXOcdxN3Gy+//oD79tKf96Yi5qkwrLtvtQy4dYRne726K qBjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HB3dfAanD6v/DibZ+Kd9MP5PZZX+18PKh7cDBPxAeHs=; b=QQwMXldyxbj2H2BdbjgF45Ifw/ehe2bChhuJfH2AciikR8F8Z9LAoOa8zv46pGwV6s oyzFaL7eo5oZwEwnBa69xNV++EawtssR89OAuiK0PCAZU12vx4VCkrbPOq59RTRFDt9s 6eNYgSvqlEO6skl0O4G+JKVyUGs6nQL6rfe6a/gbZFy1o2Bh1ZF6SjolORaxjtCWbOVB 3IoF2leBWQGzRZuyCDY6sIYM+JsnSi2F+5rAFUZ0agmQ0x86uJKY52Jtod4WOhI3eFSs oPY1UF2qoLWfMJv88GYiPbq9y5FEPbmZH8dhYjFuV2yP+uXecAID3Or+p0e142vS6K/+ vakg== X-Gm-Message-State: AOAM532g8gVIdPPtW6UbGv1RyCh6knY83Rdh2j3QAv0XuCRhm0q/yy2w hXjESYNE5AnS3AiNW3jMkC10JQMI8LcdNCntR9aWLw== X-Google-Smtp-Source: ABdhPJw8jY5UdHR872LonjGRIaliKSNWHXm1Rd2gXr1lTdg2PAg9+PKcz61b46s8PaG0GQQyveidYUX3SYA87Pal2eA= X-Received: by 2002:a05:6512:c23:: with SMTP id z35mr14088907lfu.299.1627934714208; Mon, 02 Aug 2021 13:05:14 -0700 (PDT) MIME-Version: 1.0 References: <20210723011436.60960-1-surenb@google.com> In-Reply-To: From: Shakeel Butt Date: Mon, 2 Aug 2021 13:05:03 -0700 Message-ID: Subject: Re: [PATCH v3 1/2] mm: introduce process_mrelease system call To: Suren Baghdasaryan Cc: Michal Hocko , Andrew Morton , David Rientjes , Matthew Wilcox , Johannes Weiner , Roman Gushchin , Rik van Riel , Minchan Kim , Christian Brauner , Christoph Hellwig , Oleg Nesterov , David Hildenbrand , Jann Horn , Andy Lutomirski , Christian Brauner , Florian Weimer , Jan Engelhardt , Tim Murray , Linux API , Linux MM , LKML , kernel-team Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 31B0F400332D Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=ptyOG8hV; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf18.hostedemail.com: domain of shakeelb@google.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=shakeelb@google.com X-Stat-Signature: nz1faah4x3pjebz4bzpdgdpqad8m8k8y X-HE-Tag: 1627934715-147427 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 2, 2021 at 12:54 PM Suren Baghdasaryan wrote: > > On Mon, Jul 26, 2021 at 6:44 AM Shakeel Butt wrote: > > > > On Mon, Jul 26, 2021 at 12:27 AM Michal Hocko wrote: > > > > > [...] > > > > > > Is process_mrelease on all of them really necessary? I thought that the > > > primary reason for the call is to guarantee a forward progress in cases > > > where the userspace OOM victim cannot die on SIGKILL. That should be > > > more an exception than a normal case, no? > > > > > > > I am thinking of using this API in this way: On user-defined OOM > > condition, kill a job/cgroup and unconditionally reap all of its > > processes. Keep monitoring the situation and if it does not improve go > > for another kill and reap. > > > > I can add additional logic in between kill and reap to see if reap is > > necessary but unconditionally reaping is more simple. > > > > > > > > > An alternative would be to have a cgroup specific interface for > > > > reaping similar to cgroup.kill. > > > > > > Could you elaborate? > > > > > > > I mentioned this in [1] where I was thinking if it makes sense to > > overload cgroup.kill to also add the SIGKILLed processes in > > oom_reaper_list. The downside would be that there will be one thread > > doing the reaping and the syscall approach allows userspace to reap in > > multiple threads. I think for now, I would go with whatever Suren is > > proposing and we can always add more stuff if need arises. > > > > [1] https://lore.kernel.org/containers/CALvZod4jsb6bFzTOS4ZRAJGAzBru0oWanAhezToprjACfGm+ew@mail.gmail.com/ > > Hi Folks, > So far I don't think there was any request for further changes. > Anything else you would want me to address or are we in a good shape > wrt this feature? > If so, would people who had a chance to review this patchset be > willing to endorse it with their Reviewed-by or Acked-by? I think with Michal's suggestion to use a killable mmap lock, at least I am good with the patch.