From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6352FC433E1 for ; Mon, 22 Jun 2020 17:32:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2BE852075A for ; Mon, 22 Jun 2020 17:32:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="B97slECk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2BE852075A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C1FDB6B0002; Mon, 22 Jun 2020 13:32:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BD12E6B000D; Mon, 22 Jun 2020 13:32:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE7776B0010; Mon, 22 Jun 2020 13:32:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0042.hostedemail.com [216.40.44.42]) by kanga.kvack.org (Postfix) with ESMTP id 96AE96B0002 for ; Mon, 22 Jun 2020 13:32:39 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 09E20D5E1 for ; Mon, 22 Jun 2020 17:32:39 +0000 (UTC) X-FDA: 76957542438.26.ball86_620cb9626e34 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id A32F81841B55E for ; Mon, 22 Jun 2020 17:32:36 +0000 (UTC) X-HE-Tag: ball86_620cb9626e34 X-Filterd-Recvd-Size: 3247 Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Mon, 22 Jun 2020 17:32:36 +0000 (UTC) Received: by mail-lf1-f67.google.com with SMTP id t74so10127736lff.2 for ; Mon, 22 Jun 2020 10:32:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fZsJVwDrOxKrBzWWAsZN0Wz485qfczm0ojFoE3HuC8Y=; b=B97slECk7p+UApt7HEu2L46Awqn4jeXNqhBPxYKtyGhSPTh/Jb//7y7zBEyWqWevtW dLu6Fx/khrwGC8lHn/tYWNwJ80sqbHHvLODpaOthDRf94MI7UD5vDelpS1d7e8K+AN4Y OvGhfdZg2Y5xvmbRCoxIgStQPCgOasGuzQTvsk9WYHueX6/I5DLiLN7DpRfmRup6J2uf gHz0bN2X6saHrWIY+6Odwb9Sczp0L2zGJy7l800XdroTPsjy5Tqw5haIST4edmoy6qNB vmq48Z/I4HSgRZiS2eaXV6maEJlz0qtfrnuXhZB5bN2FvaE8tiTxPRKEMQ78FNo6fXD+ pTkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fZsJVwDrOxKrBzWWAsZN0Wz485qfczm0ojFoE3HuC8Y=; b=Z68t3k8lixtmnShbwUDU24bKhFv3pJkCHmIHOUdXiMSxl74HMY/fcJXnu77yaIbVQE bmNYl9wK6hUKBKgOqTnvOWoQZes7Xrra61VG4f6pL/GAZpW52d2FEP+gVevx/Pi+QQR1 ZI7js5sD5jZ9zHa0jiqO9USN+9xNP0L5wBosXHgnR1Qedx7cIhb8nyQtP3nTyQEhlHnX wnm1nMtG4AdqPd8GVag0Kl8gbuIKaUBgCmUErMsOkA4RlnGnMxDXPA+C3wykO9KJbpyd SLW2q2cW8NWegDN+0rRQQllGZNg9k6XtD8DuRqfQ0GZsogSPVBmyhpdT4IJRGR7C7ezZ 6OQQ== X-Gm-Message-State: AOAM530bOptRbd0/Pgx8JbqnjbZBduN/+hEd+MaI6r21xKUlRVzMMsz3 VPxCh3ha5Uw4EYq57IjJHGi5kYSWosEKW0CRABCxSw== X-Google-Smtp-Source: ABdhPJx0uWPE+mHRbsfaQ2QHd0ZSFRs9zLnEbwP/Zl1FPpJTvIlUyLTOw+ivd5xB2DSTieKirftUU/0t2M1cu4jIdNw= X-Received: by 2002:a19:4301:: with SMTP id q1mr10373314lfa.96.1592847154742; Mon, 22 Jun 2020 10:32:34 -0700 (PDT) MIME-Version: 1.0 References: <20200608230654.828134-1-guro@fb.com> <20200608230654.828134-17-guro@fb.com> In-Reply-To: <20200608230654.828134-17-guro@fb.com> From: Shakeel Butt Date: Mon, 22 Jun 2020 10:32:23 -0700 Message-ID: Subject: Re: [PATCH v6 16/19] mm: memcg/slab: remove redundant check in memcg_accumulate_slabinfo() To: Roman Gushchin Cc: Andrew Morton , Christoph Lameter , Johannes Weiner , Michal Hocko , Linux MM , Vlastimil Babka , Kernel Team , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: A32F81841B55E X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 8, 2020 at 4:07 PM Roman Gushchin wrote: > > memcg_accumulate_slabinfo() is never called with a non-root > kmem_cache as a first argument, so the is_root_cache(s) check > is redundant and can be removed without any functional change. > > Signed-off-by: Roman Gushchin > Reviewed-by: Vlastimil Babka Reviewed-by: Shakeel Butt