From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70BE1C433F5 for ; Fri, 1 Apr 2022 15:41:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C7A516B0072; Fri, 1 Apr 2022 11:41:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C52DD6B0073; Fri, 1 Apr 2022 11:41:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF2548D0001; Fri, 1 Apr 2022 11:41:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0125.hostedemail.com [216.40.44.125]) by kanga.kvack.org (Postfix) with ESMTP id A09636B0072 for ; Fri, 1 Apr 2022 11:41:34 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 6B489A45D7 for ; Fri, 1 Apr 2022 15:41:24 +0000 (UTC) X-FDA: 79308724488.29.C25D3A1 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by imf27.hostedemail.com (Postfix) with ESMTP id EA71F40002 for ; Fri, 1 Apr 2022 15:41:23 +0000 (UTC) Received: by mail-pg1-f172.google.com with SMTP id q19so2681113pgm.6 for ; Fri, 01 Apr 2022 08:41:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pqJWbvvbg0qdWklwqs2qhrfKKi69liUYvCt62FUbnWk=; b=Fn5jpMZAmMPReAvL0Tyf7tj5rAcmThNhnq1xKoKFkJI0vR0fJhwRbtqFchPRvfX4q1 ONoUm1fDJi9X/SdotI5xdBPmgeBbrWo8/YaW2ybUubSt1izJy97NcFaxs+dJxWC0WBMf 6z+iwlN+sbK2nfsp4T5xwzKsl3sE9+883flPy03nnksy67+Yj2ZYN4oSkYQiIHtJaUUH 6+GoJw85rhIbSF3mvBhZg+VFZFkJaWhhkPhJhHoJqg/NLIlaGVi7lJF460tom7CJNf71 QLXswXjH3yWTPwjM8DWIfiObLitVJeSiXu0UH1DAOa8qNyI5WVPl/7tgONlEth6eYrLf Uwag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pqJWbvvbg0qdWklwqs2qhrfKKi69liUYvCt62FUbnWk=; b=uAJstUNJdD2BcmW9vCUVE/AzCBRsar9kggjtiLRfJH6M9QEyhJkWwoh6vr7gzZlkOH gDLFh69FJmNbANlfdvqaqHwLHR+RvtugyOBld25fMEBIRJ+4wIeGbOWSsp9QE7sEIIVO Ycpud1JWdhGEAxw+eWOiBQqxFOVs1+ldGo7J/Tsfr3J2plFJwVpXcgUxlsIVT0XU0X6e KUmLrRyN2DWzLHJmeMdN3MLzXRZF9+RbMGbtPl+PZOJenJYzoHkMhyGvoB5wgyxmUrZD 4SqrUiqk3z5tV16Xxspgj5Z6jpYMNPGvTA46r/FHRbk25XtZE54KrcAVnqJtYFlPfO9m H30g== X-Gm-Message-State: AOAM532g7J+o9yvfOT10WJDGo9B3xPbs8reTQ5NEWDdd8mr3eaWP5Ams juE4ci8SUyoN4rdPIPFeU18XwoPv39RHZHGResMaJw== X-Google-Smtp-Source: ABdhPJxICFXuqj/lX5mtK0KnO7e8FwZzOC70mH0krkoDwxL8TroQr5Ghmg+DK+Zw9WUBYtZMvmLXl8GvFlOCo2bG5as= X-Received: by 2002:a05:6a00:2392:b0:4fa:dcd2:5bc1 with SMTP id f18-20020a056a00239200b004fadcd25bc1mr11451248pfc.8.1648827682692; Fri, 01 Apr 2022 08:41:22 -0700 (PDT) MIME-Version: 1.0 References: <20220331084151.2600229-1-yosryahmed@google.com> In-Reply-To: From: Shakeel Butt Date: Fri, 1 Apr 2022 08:41:11 -0700 Message-ID: Subject: Re: [PATCH resend] memcg: introduce per-memcg reclaim interface To: Yosry Ahmed Cc: Roman Gushchin , Johannes Weiner , Michal Hocko , Andrew Morton , David Rientjes , Tejun Heo , Zefan Li , Cgroups , "open list:DOCUMENTATION" , LKML , Linux-MM , Jonathan Corbet , Yu Zhao , Dave Hansen , Wei Xu , Greg Thelen Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Stat-Signature: sqgympfda59psat3smzwhy47pr77yurt Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Fn5jpMZA; spf=pass (imf27.hostedemail.com: domain of shakeelb@google.com designates 209.85.215.172 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: EA71F40002 X-HE-Tag: 1648827683-179539 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 1, 2022 at 2:16 AM Yosry Ahmed wrote: > [...] > > > + { > > > + .name = "reclaim", > > > + .flags = CFTYPE_NOT_ON_ROOT | CFTYPE_NS_DELEGATABLE, > > > + .write = memory_reclaim, > > > > Btw, why not on root? > > I missed the root question in my first reply. I think this was > originally modeled after the memory.high interface, but I don't know > if there are other reasons. Shakeel would know better. > > AFAIK this should work naturally on root as well, but I think it makes > more sense then to use a global interface (hopefully introduced soon)? > I don't have an opinion here let me know what you prefer for v2. We will follow the psi example which is exposed for root as well as for system level in procfs but both of these (for memory.reclaim) are planned as the followup feature.