From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8C08C433E6 for ; Mon, 15 Mar 2021 23:59:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8451764F37 for ; Mon, 15 Mar 2021 23:59:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8451764F37 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 06BB56B0036; Mon, 15 Mar 2021 19:59:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 01B646B006C; Mon, 15 Mar 2021 19:59:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DFD546B0070; Mon, 15 Mar 2021 19:59:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0082.hostedemail.com [216.40.44.82]) by kanga.kvack.org (Postfix) with ESMTP id C6C596B0036 for ; Mon, 15 Mar 2021 19:59:03 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 6DACC181A88E4 for ; Mon, 15 Mar 2021 23:59:03 +0000 (UTC) X-FDA: 77923776966.20.CD6FB5B Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) by imf03.hostedemail.com (Postfix) with ESMTP id DD325C0002C1 for ; Mon, 15 Mar 2021 23:59:02 +0000 (UTC) Received: by mail-lj1-f176.google.com with SMTP id y1so18366992ljm.10 for ; Mon, 15 Mar 2021 16:59:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GiWLaJ6JfRY7D2fjAEheSS/CI6En0Tfjr7NfpaLRaUg=; b=el1U4yM7KpXL5g8A1suug3kzC4jqMxihYzAe6idzQvWFnWS91NbuSI/u+c6mo6cRnV SPei+MME4J69H5g9v4345POnj6DndSypgXQdfUHFQYb7eJNzCDNSvw/2JxkV/MfzWtOC kf4IBHDbVcqItf9trvNPu1tywIQIXWuoKwXmyEvHMidR1r5dkG0r+DYt+noifqymr/al NOpBuSOhXUfkxXzujUrmtj6SfPf704YxzLSaRzU5iJInw3d/wh8k5iOLjeOO/M+5KmEi LJh2OEaMvZRv9JdvA6or3g3XBQ1bnr8Uu6YnH5VpChJ/5QuJgx7O/g/j1G2ONUuw4djx N5OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GiWLaJ6JfRY7D2fjAEheSS/CI6En0Tfjr7NfpaLRaUg=; b=QFk5I+Rq+JvWmPjy+PJsLt/LEt9Rtlm6R/ZjWSUxhOigpwagahnS8giHH5CabieyI+ mcjzQoSJXmoQ7AkvzDew/UUcGachhkDLlpaG+8e6xNc2yk2H2A1QVLCXwhva236aH5Em OL+fSFReYO3amta1bqyQ5avkWJhlTeBCKIsbetxz27nPOZtgng5geym89bnNp2MmJAWR SftxlhwanZrP+GPfO9sNDEXyIQed3DIqkk2nEF75uGrJjmbqHAkZ2Iv88nEPxIpf8TNG 7dW5G+SvdRvU8PYUIgbL1B9Td3MYu06I1uOiveGmIb2jWYE7f4zAG2J9ktUgE2hT8DNa dkWQ== X-Gm-Message-State: AOAM533W5JGlJOU+Hj+J8WSR2sMhnqYzMq2Pl5uc+6c1ZYxkaLaRM6G0 qJ0thB7uSfYRG6/fKhLrL2sz+8Xo8IW+v64HlPZvjQ== X-Google-Smtp-Source: ABdhPJzCFWkbAbfU5FZc7r0w/lfxsElxEMPSYg1g37oXUD304ZYfPSKaUF3yhqQGKYWlRE3P3zrkIX0Ht1rL3aPfSaI= X-Received: by 2002:a2e:7d03:: with SMTP id y3mr922776ljc.0.1615852741307; Mon, 15 Mar 2021 16:59:01 -0700 (PDT) MIME-Version: 1.0 References: <20210315234100.64307-1-hannes@cmpxchg.org> In-Reply-To: <20210315234100.64307-1-hannes@cmpxchg.org> From: Shakeel Butt Date: Mon, 15 Mar 2021 16:58:49 -0700 Message-ID: Subject: Re: [PATCH] mm: memcontrol: switch to rstat fix To: Johannes Weiner Cc: Andrew Morton , Michal Hocko , Roman Gushchin , Tejun Heo , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Cgroups , Linux MM , LKML , Kernel Team Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: DD325C0002C1 X-Stat-Signature: wpcaoagyhqyprtycomt847s6hsjtgicc Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf03; identity=mailfrom; envelope-from=""; helo=mail-lj1-f176.google.com; client-ip=209.85.208.176 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615852742-397175 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 15, 2021 at 4:41 PM Johannes Weiner wrote: > > Fix a sleep in atomic section problem: wb_writeback() takes a spinlock > and calls wb_over_bg_thresh() -> mem_cgroup_wb_stats, but the regular > rstat flushing function called from in there does lockbreaking and may > sleep. Switch to the atomic variant, cgroup_rstat_irqsafe(). > > To be consistent with other memcg flush calls, but without adding > another memcg wrapper, inline and drop memcg_flush_vmstats() instead. > > Signed-off-by: Johannes Weiner Reviewed-by: Shakeel Butt