From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1000CC433E1 for ; Fri, 21 Aug 2020 20:23:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BCF6E20735 for ; Fri, 21 Aug 2020 20:23:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Iaf2NJFc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BCF6E20735 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5AD8A8D007F; Fri, 21 Aug 2020 16:23:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 55EEF8D0002; Fri, 21 Aug 2020 16:23:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 44D358D007F; Fri, 21 Aug 2020 16:23:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0033.hostedemail.com [216.40.44.33]) by kanga.kvack.org (Postfix) with ESMTP id 2E44F8D0002 for ; Fri, 21 Aug 2020 16:23:34 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id DDAC618039525 for ; Fri, 21 Aug 2020 20:23:33 +0000 (UTC) X-FDA: 77175701106.13.glue44_3c036b02703c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id A9EA01803A554 for ; Fri, 21 Aug 2020 20:23:33 +0000 (UTC) X-HE-Tag: glue44_3c036b02703c X-Filterd-Recvd-Size: 6146 Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Fri, 21 Aug 2020 20:23:33 +0000 (UTC) Received: by mail-lj1-f195.google.com with SMTP id f26so3202715ljc.8 for ; Fri, 21 Aug 2020 13:23:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3D+TqH2GckoXVS0G3AVPPpXHl/Ts1q0PzrQAkDG5DxU=; b=Iaf2NJFcLLPjJhCFY4NPJilmEIWG1EFZPPdHf4a8cj0cg5EIjHpega0AiSsQdtW2bk gfJ+fc6kt7IQS7SnbVWnC7nVl1NCVvIvAYMA+W7ZX4lygUpP1+w1ZAYWXppaTBAf8FnJ HLiubgJccGNPYTJixoFrXXnbWGuO3t08zDeHSeMZCXjnotaLbkFq91VPkpSg8AOzFma2 6iZ7V4Oefj3vBgGenVmlNikMMYEnqUWK1a+A4pNOYTR11AA0IqAS6HeY4XIaHwSMRWmH w3QNtXRLNxeUZuRdcDTgKqZ6ih6/11rJX2eAqK4u7o5a+KWL4L4g4AZjl5yls4ZEKP7/ G2Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3D+TqH2GckoXVS0G3AVPPpXHl/Ts1q0PzrQAkDG5DxU=; b=pIpVgVI/Jh0tbICqOG5+Fhrm8mKNL/hSLilz5qtBSgbGxKDnLUpNnRQYXY36sRrV3F X9FdMRGh8XK6s4aDFkoX8TWl7paidaiAL9XNLA3IG6aUQ02mWsUkrhMkti+06fFR6iax Qdn7P8mWw8UlqIYLAMcTLXEWC6rffupMrr7tv32YOXwNCb1q9H9umyJTPKhtVBHmdOsp 6ztlQDHr38mcs/L8jECZVwXDRU44/5pHuqlQz4rPO0GAsH7UcE4/uzg2LH5fDlIvgH23 GjBO/Ygg4/7rbwmrNAKGB5wl8yC67cEL3fOX9RuHEXsIhkU9gc/dY1tCqBwROFqJmcB4 Wbbg== X-Gm-Message-State: AOAM532tcEmMwQBusdnJ62qJPIPZpNqMyUy/eVqSHfDc3AU+3TSUmgN3 kjXOpUQMBn0Z6Yb46HrfJr5qFqkmBWUu/s/oCvJP2Q== X-Google-Smtp-Source: ABdhPJxtB3gytKgy43PrfoEOXffDzmegXgekhXTFkNzcg9j+nkrkWcOxp0q7UZtL0bR4N1sDGWoc4+ZBzIS8qEtpwWY= X-Received: by 2002:a05:651c:330:: with SMTP id b16mr2290021ljp.77.1598041411383; Fri, 21 Aug 2020 13:23:31 -0700 (PDT) MIME-Version: 1.0 References: <20200528135444.11508-1-schatzberg.dan@gmail.com> <20200821150405.GA4137@dschatzberg-fedora-PC0Y6AEN.dhcp.thefacebook.com> <20200821160128.GA2233370@carbon.dhcp.thefacebook.com> <20200821200530.GA2250889@carbon.dhcp.thefacebook.com> In-Reply-To: <20200821200530.GA2250889@carbon.dhcp.thefacebook.com> From: Shakeel Butt Date: Fri, 21 Aug 2020 13:23:20 -0700 Message-ID: Subject: Re: [PATCH v6 0/4] Charge loop device i/o to issuing cgroup To: Roman Gushchin Cc: Dan Schatzberg , Jens Axboe , Alexander Viro , Jan Kara , Amir Goldstein , Tejun Heo , Li Zefan , Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Hugh Dickins , Chris Down , Yang Shi , Thomas Gleixner , "Peter Zijlstra (Intel)" , Ingo Molnar , Mathieu Desnoyers , Andrea Arcangeli , "open list:BLOCK LAYER" , open list , "open list:FILESYSTEMS (VFS and infrastructure)" , "open list:CONTROL GROUP (CGROUP)" , "open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: A9EA01803A554 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 21, 2020 at 1:05 PM Roman Gushchin wrote: > > On Fri, Aug 21, 2020 at 09:27:56AM -0700, Shakeel Butt wrote: > > On Fri, Aug 21, 2020 at 9:02 AM Roman Gushchin wrote: > > > > > > On Fri, Aug 21, 2020 at 11:04:05AM -0400, Dan Schatzberg wrote: > > > > On Thu, Aug 20, 2020 at 10:06:44AM -0700, Shakeel Butt wrote: > > > > > On Thu, May 28, 2020 at 6:55 AM Dan Schatzberg wrote: > > > > > > > > > > > > Much of the discussion about this has died down. There's been a > > > > > > concern raised that we could generalize infrastructure across loop, > > > > > > md, etc. This may be possible, in the future, but it isn't clear to me > > > > > > how this would look like. I'm inclined to fix the existing issue with > > > > > > loop devices now (this is a problem we hit at FB) and address > > > > > > consolidation with other cases if and when those need to be addressed. > > > > > > > > > > > > > > > > What's the status of this series? > > > > > > > > Thanks for reminding me about this. I haven't got any further > > > > feedback. I'll bug Jens to take a look and see if he has any concerns > > > > and if not send a rebased version. > > > > > > Just as a note, I stole a patch from this series called > > > "mm: support nesting memalloc_use_memcg()" to use for the bpf memory accounting. > > > I rewrote the commit log and rebased to the tot with some trivial changes. > > > > > > I just sent it upstream: > > > https://lore.kernel.org/bpf/20200821150134.2581465-1-guro@fb.com/T/#md7edb6b5b940cee1c4d15e3cef17aa8b07328c2e > > > > > > It looks like we need it for two independent sub-systems, so I wonder > > > if we want to route it first through the mm tree as a standalone patch? > > > > > > > Another way is to push that patch to 5.9-rc2 linus tree, so both block > > and mm branches for 5.10 will have it. (Not sure if that's ok.) > > Ok, it looks like the patch provides a generally useful API enhancement. > And we do have at least two potential use cases for it. > Let me send it as a standalone patch to linux-mm@. > > Btw, Shakeel, what do you think of s/memalloc_use_memcg()/set_active_memcg() ? > I am fine with it.