linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Shakeel Butt <shakeelb@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
	Yang Shi <shy828301@gmail.com>,
	 Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
	 Naresh Kamboju <naresh.kamboju@linaro.org>,
	linux-mm <linux-mm@kvack.org>,
	 Mel Gorman <mgorman@techsingularity.net>,
	Michal Hocko <mhocko@kernel.org>,
	 Dan Schatzberg <schatzberg.dan@gmail.com>
Subject: Re: fs/buffer.c: WARNING: alloc_page_buffers while mke2fs
Date: Mon, 20 Apr 2020 09:41:33 -0700	[thread overview]
Message-ID: <CALvZod7uc59aOSuaCNZMpYJL83vaE5zUeHaj1knd5Gh1gmaG_g@mail.gmail.com> (raw)
In-Reply-To: <20200303162948.a383cb88c4a1b0bfd3817798@linux-foundation.org>

On Tue, Mar 3, 2020 at 4:29 PM Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Tue, 3 Mar 2020 15:22:00 -0800 Shakeel Butt <shakeelb@google.com> wrote:
>
> > > doesn't corrupt its state.
> > >
> > > I.e. this is safe:
> > >
> > >   process:                            interrupt:
> > >   old = current->active_memcg
> > >                                       old = current->active_memcg
> > >                                       current->active_memcg = new
> > >                                       allocate
> > >                                       current->active_memcg = old
> > >   current->active_memcg = new
> > >   return old
> > >
> > > This is safe as well:
> > >
> > >   process:                            interrupt:
> > >   old = current->active_memcg
> > >   current->active_memcg = new
> > >                                       old = current->active_memcg
> > >                                       current->active_memcg = new
> > >                                       allocate
> > >                                       current->active_memcg = old
> > >   return old
> >
> > Yes, you are right. Thanks for the explanation.
>
> Thanks, all.
>
> Dan, I dropped the three-patch series
>
> loop-use-worker-per-cgroup-instead-of-kworker.patch
> mm-charge-active-memcg-when-no-mm-is-set.patch
> loop-charge-i-o-to-mem-and-blk-cg.patch
>
> When convenient, could you please prepend Johannes' patch to the
> series, retest and resend?  While doing so, please figure out why you
> didn't also see this warning in your testing and make the appropriate
> changes!
>

Hi Dan, did you get the chance to follow up on Andrew's request?

Shakeel


  reply	other threads:[~2020-04-20 16:41 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CA+G9fYs==eMEmY_OpdhyCHO_1Z5f_M8CAQQTh-AOf5xAvBHKAQ@mail.gmail.com>
2020-03-03 10:52 ` fs/buffer.c: WARNING: alloc_page_buffers while mke2fs Tetsuo Handa
2020-03-03 17:47   ` Yang Shi
2020-03-03 18:14     ` Shakeel Butt
2020-03-03 18:34       ` Yang Shi
2020-03-03 19:42       ` Yang Shi
2020-03-03 20:26         ` Shakeel Butt
2020-03-03 20:33         ` Johannes Weiner
2020-03-03 20:59           ` Yang Shi
2020-03-03 20:26       ` Johannes Weiner
2020-03-03 20:40         ` Shakeel Butt
2020-03-03 21:06           ` Johannes Weiner
2020-03-03 23:22             ` Shakeel Butt
2020-03-04  0:29               ` Andrew Morton
2020-04-20 16:41                 ` Shakeel Butt [this message]
2020-04-20 22:45                   ` Dan Schatzberg
2020-04-21  5:02                     ` Naresh Kamboju
2020-03-03 20:57         ` Yang Shi
2020-03-03 18:40     ` Naresh Kamboju
2020-03-03 19:04       ` Yang Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALvZod7uc59aOSuaCNZMpYJL83vaE5zUeHaj1knd5Gh1gmaG_g@mail.gmail.com \
    --to=shakeelb@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=mhocko@kernel.org \
    --cc=naresh.kamboju@linaro.org \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=schatzberg.dan@gmail.com \
    --cc=shy828301@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).