From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A6D6C433E0 for ; Wed, 17 Jun 2020 01:52:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1EA102085B for ; Wed, 17 Jun 2020 01:52:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="HeT5Exh5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1EA102085B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8F0D56B0002; Tue, 16 Jun 2020 21:52:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A1BF6B0003; Tue, 16 Jun 2020 21:52:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 790D16B0005; Tue, 16 Jun 2020 21:52:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0049.hostedemail.com [216.40.44.49]) by kanga.kvack.org (Postfix) with ESMTP id 5E6C56B0002 for ; Tue, 16 Jun 2020 21:52:23 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id F2AC33568 for ; Wed, 17 Jun 2020 01:52:22 +0000 (UTC) X-FDA: 76937028924.09.love81_4b018c926e03 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id CC237180AD804 for ; Wed, 17 Jun 2020 01:52:22 +0000 (UTC) X-HE-Tag: love81_4b018c926e03 X-Filterd-Recvd-Size: 4626 Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Wed, 17 Jun 2020 01:52:22 +0000 (UTC) Received: by mail-lj1-f193.google.com with SMTP id 9so859179ljc.8 for ; Tue, 16 Jun 2020 18:52:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Hs8Cat8bZTOs/g3e5u5zu4I8c3QADLQ9ogPtTS3pDjQ=; b=HeT5Exh5fEtOJpP//JnKtRjulLeFEmNguq4snh/ycH/k8l1/xgJXSTeONIWqNrNwbk Dh3R7WwjUOPd8YAXlE/2Syp+7ZZD8ajyyrTVPP92h2pfUclYacudqJ1MycXtqx6DS6lP j1XMVtKsUdK9PPBqtzue5nI1/AjJmuCaoY0RaD2GX3IqM8kK6V47CiCLddl1pgjJI/y1 I9o5eYIsVGMh47jO0kTMI7z9cAwZ4NQlhYH0KIn/qGVGBIWWmw1ItXIf156cwVzZFEzv 0TEU6ez+9EnAtjUOyAewoI1Hw4fdOoL2q1Qn80o9FklGP6ot7ds1gDAQ0K5wAeiDVgFu mBpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Hs8Cat8bZTOs/g3e5u5zu4I8c3QADLQ9ogPtTS3pDjQ=; b=R/2HzlQtB+bOp9LAvQKxBBVXcslF6n5uF/YgDORxTCJ06Prs5JAMRLsVsGK7PFqxVe 0MF0ffJvdlaeWYqS4KSWi6MQ8W9EovdGTOhsrroH+o8pclX5T86qxKb0UGLBr+BmbIAz Wr4b5KDs3MgVsgBaNga2lakRgyihra2K6HWfFIsFcCmtWRRAvD2AzG1neDUfhYOUs+bh kbvyfxOkyDnwVeQ3BWm/X/JSomkNA9owk8AlxzS25+AU9WjrGbLLtrZmHsDy/pofXDYU iGXcbozlNwtihoDz4JWKZLk0jqhP/d94SmNkSRw8l5hbq7opbiRpIUf+Lw1116uRd79h H9sw== X-Gm-Message-State: AOAM531RiOU1YyGBMCAcJPXU/a/x7UMc8Nl+54YF3y24t5/RiD64FGAJ 2jmycl7MSn+Jd6wceqrULNo0QzOZ+2xbx5SKlnjjvA== X-Google-Smtp-Source: ABdhPJwDS8HadRR7DfyOCxHk13sgCYSWmuDmmAtr6leoevRVwgAlb9iHKtjEpLx/xEhXbTWRULjmZcUEwC6nURs67GU= X-Received: by 2002:a2e:9ac4:: with SMTP id p4mr3013566ljj.446.1592358740700; Tue, 16 Jun 2020 18:52:20 -0700 (PDT) MIME-Version: 1.0 References: <20200608230654.828134-1-guro@fb.com> <20200608230654.828134-2-guro@fb.com> In-Reply-To: <20200608230654.828134-2-guro@fb.com> From: Shakeel Butt Date: Tue, 16 Jun 2020 18:52:09 -0700 Message-ID: Subject: Re: [PATCH v6 01/19] mm: memcg: factor out memcg- and lruvec-level changes out of __mod_lruvec_state() To: Roman Gushchin Cc: Andrew Morton , Christoph Lameter , Johannes Weiner , Michal Hocko , Linux MM , Vlastimil Babka , Kernel Team , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: CC237180AD804 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 8, 2020 at 4:07 PM Roman Gushchin wrote: > > To convert memcg and lruvec slab counters to bytes there must be > a way to change these counters without touching node counters. > Factor out __mod_memcg_lruvec_state() out of __mod_lruvec_state(). > > Signed-off-by: Roman Gushchin > Acked-by: Johannes Weiner > Reviewed-by: Vlastimil Babka > --- > include/linux/memcontrol.h | 17 +++++++++++++++ > mm/memcontrol.c | 43 +++++++++++++++++++++----------------- > 2 files changed, 41 insertions(+), 19 deletions(-) > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index bbf624a7f5a6..93dbc7f9d8b8 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -679,11 +679,23 @@ static inline unsigned long lruvec_page_state_local(struct lruvec *lruvec, > return x; > } > > +void __mod_memcg_lruvec_state(struct lruvec *lruvec, enum node_stat_item idx, > + int val); > void __mod_lruvec_state(struct lruvec *lruvec, enum node_stat_item idx, > int val); > void __mod_lruvec_slab_state(void *p, enum node_stat_item idx, int val); > void mod_memcg_obj_state(void *p, int idx, int val); > > +static inline void mod_memcg_lruvec_state(struct lruvec *lruvec, > + enum node_stat_item idx, int val) Is this function used in later patches? Any benefit introducing it here instead of in the patch where it is used for the first time? > +{ > + unsigned long flags; > + > + local_irq_save(flags); > + __mod_memcg_lruvec_state(lruvec, idx, val); > + local_irq_restore(flags); > +} > + [...]