linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Vitaly Wool <vitaly.wool@konsulko.com>
To: Tian Tao <tiantao6@hisilicon.com>
Cc: Seth Jennings <sjenning@redhat.com>,
	Dan Streetman <ddstreet@ieee.org>,
	 Andrew Morton <akpm@linux-foundation.org>,
	Barry Song <song.bao.hua@hisilicon.com>,
	 Linux-MM <linux-mm@kvack.org>, Mike Galbraith <efault@gmx.de>,
	 Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [RFC mm/zswap 0/2] Fix the compatibility of zsmalloc and zswap
Date: Thu, 14 Jan 2021 19:46:06 +0100	[thread overview]
Message-ID: <CAM4kBBJmGxKo7Z1g716WetmP7jWnN7Fo24VMak4opDqCDvZHvg@mail.gmail.com> (raw)
In-Reply-To: <1608894171-54174-1-git-send-email-tiantao6@hisilicon.com>

On Fri, Dec 25, 2020 at 12:02 PM Tian Tao <tiantao6@hisilicon.com> wrote:
>
> patch #1 add a flag to zpool, then zswap used to determine if zpool
> drivers such as zbud/z3fold/zsmalloc whether can sleep in atoimc context.
> patch #2 set flag sleep_mapped to true indicates that zbud/z3fold can
> sleep in atomic context. zsmalloc didin't support sleep in atomic context,
> so not set that flag to true.
>
> Tian Tao (2):
>   mm/zswap: add the flag can_sleep_mapped
>   mm: set the sleep_mapped to true for zbud and z3fold
>
>  include/linux/zpool.h |  3 +++
>  mm/z3fold.c           |  1 +
>  mm/zbud.c             |  1 +
>  mm/zpool.c            | 13 +++++++++++++
>  mm/zswap.c            | 50 +++++++++++++++++++++++++++++++++++++++++++++-----
>  5 files changed, 63 insertions(+), 5 deletions(-)

Haven't been able to actually test these yet, but looks good to me so far, so

Reviewed-by: Vitaly Wool <vitaly.wool@konsulko.com>

Please wait a bit for Mike, Sebastian or me to actually test this.
Also, keep them CC'd explicitly if you are to come up with a new
version for some reason.

Best regards,
   Vitaly


  parent reply	other threads:[~2021-01-14 18:46 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-25 11:02 [RFC mm/zswap 0/2] Fix the compatibility of zsmalloc and zswap Tian Tao
2020-12-25 11:02 ` [RFC mm/zswap 1/2] mm/zswap: add the flag can_sleep_mapped Tian Tao
2021-01-14 18:28   ` Minchan Kim
2021-01-14 18:40     ` Vitaly Wool
2021-01-14 18:56       ` Minchan Kim
2021-01-14 19:05         ` Vitaly Wool
2021-01-14 19:21           ` Shakeel Butt
2021-01-14 19:23             ` Minchan Kim
2021-01-14 19:53             ` Vitaly Wool
2021-01-14 21:09               ` Shakeel Butt
2021-01-14 22:41                 ` Vitaly Wool
2021-01-19  1:28                   ` tiantao (H)
2021-01-14 18:43     ` Shakeel Butt
2021-01-14 18:53       ` Vitaly Wool
2021-01-21  9:17   ` Vitaly Wool
2021-01-21 23:15     ` Song Bao Hua (Barry Song)
2020-12-25 11:02 ` [RFC mm/zswap 2/2] mm: set the sleep_mapped to true for zbud and z3fold Tian Tao
2021-01-14 18:46 ` Vitaly Wool [this message]
2021-01-15  1:17   ` [RFC mm/zswap 0/2] Fix the compatibility of zsmalloc and zswap tiantao (H)
2021-01-19  1:31     ` tiantao (H)
2021-01-19  2:39       ` Mike Galbraith
2021-01-18 13:44   ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAM4kBBJmGxKo7Z1g716WetmP7jWnN7Fo24VMak4opDqCDvZHvg@mail.gmail.com \
    --to=vitaly.wool@konsulko.com \
    --cc=akpm@linux-foundation.org \
    --cc=bigeasy@linutronix.de \
    --cc=ddstreet@ieee.org \
    --cc=efault@gmx.de \
    --cc=linux-mm@kvack.org \
    --cc=sjenning@redhat.com \
    --cc=song.bao.hua@hisilicon.com \
    --cc=tiantao6@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).