From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FB98C3F2D4 for ; Mon, 2 Mar 2020 08:54:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C6F6D24695 for ; Mon, 2 Mar 2020 08:54:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="euznFhb2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C6F6D24695 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 085A76B0005; Mon, 2 Mar 2020 03:54:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 011656B0006; Mon, 2 Mar 2020 03:54:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1A296B0007; Mon, 2 Mar 2020 03:54:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0248.hostedemail.com [216.40.44.248]) by kanga.kvack.org (Postfix) with ESMTP id C53ED6B0005 for ; Mon, 2 Mar 2020 03:54:40 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 90F8A181AC9B6 for ; Mon, 2 Mar 2020 08:54:40 +0000 (UTC) X-FDA: 76549811520.13.price25_28c8b8de7841b X-HE-Tag: price25_28c8b8de7841b X-Filterd-Recvd-Size: 3796 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Mon, 2 Mar 2020 08:54:40 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id n7so3530609wrt.11 for ; Mon, 02 Mar 2020 00:54:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JcY8uAoMmF9oPjf8la7A7KSa8FWV9Bilp23gxzOHZ7Q=; b=euznFhb2tLlnOqb+aC0lZTtc9IPKZksse6Gbmtw087QomR/zYNeNblnIluE34zduLr P2UinbWk73yfsT8akFxz69iEwmeWsgPAA2CU73cYcoNFAuNvGnPN4umo/lT11wWhrWZr L6snZxyl2CFOIlocJ3+i5emtR3TM0KJ6N1ts0RHWym41oOseWxhJhV/+3VVuPFkkCKkV yhfhTE2ro4IqNeyaS5Vwne9gCi1L9JKfpHxUSXuOXcW45eJc2zqxNAL9QyW+dGTbT342 qZm1tJIhhpD0xEKAIhRu0O0ihw3YaBB/C5WL4h3Jq9swgLLk+9djyfQylssTfMyjEwEL UQpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JcY8uAoMmF9oPjf8la7A7KSa8FWV9Bilp23gxzOHZ7Q=; b=jK8scx9MzJyQH1UOLeqTN6XhjymYzlwHoXA6Sj3qdI2dRO4Ix8l2nwydfsjXYJONo3 6KIo7lGm7jjmW3TKllAa7BbaTAMfgEkYbSuAOzMOFdMpfelV8o8mL8F8L66uKXGXaj8o G19O/r3dnGAt8RfDefhuXBAxTaOEtGaZOwcP56KiP7LhdbNTuY1xTFATJUBZDNSx5Pnt /Wo4sTGGG6PMJ/mMeaxZIdVnzjP171x3WgsypclELSNSHoenJLq2vQ8bzK+JViDt2tWu mLJziHQ6zxyQIqLhKWbbFwMUwTwFIBcPaAueWvvvLC4paRl8MKiHFnU5knz/nYGfcuCo wivw== X-Gm-Message-State: APjAAAVOp1fUYtgB9EvzuWxMOu0lmVfhQdyZ8VK8AB5DHVRflb5GGUgz 3ZNipd9qDkMeKnhP1ta/Y40IxucT/jukqPk+AwY= X-Google-Smtp-Source: APXvYqyH9uPrYTI9EcU6q0qWpH1FPeqFwmIpaXV4DbdNPahu6bc5sTQrWiQ9qrudrCDWDmR/HxP4TIPdilN/Oaa+jvQ= X-Received: by 2002:adf:f604:: with SMTP id t4mr21632196wrp.96.1583139278737; Mon, 02 Mar 2020 00:54:38 -0800 (PST) MIME-Version: 1.0 References: <20200301152832.24595-1-mateusznosek0@gmail.com> In-Reply-To: <20200301152832.24595-1-mateusznosek0@gmail.com> From: Pankaj Gupta Date: Mon, 2 Mar 2020 09:54:27 +0100 Message-ID: Subject: Re: [PATCH] mm/shmem.c: Clean code by removing unnecessary assignment To: mateusznosek0@gmail.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, hughd@google.com, Andrew Morton Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > From: Mateusz Nosek > > Previously 0 was assigned to variable 'error' > but the variable was never read before reassignemnt later. > So the assignment can be removed. > > Signed-off-by: Mateusz Nosek > --- > mm/shmem.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/mm/shmem.c b/mm/shmem.c > index 31b4bcc95f17..84eb14f5509c 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -3116,12 +3116,9 @@ static int shmem_symlink(struct inode *dir, struct dentry *dentry, const char *s > > error = security_inode_init_security(inode, dir, &dentry->d_name, > shmem_initxattrs, NULL); > - if (error) { > - if (error != -EOPNOTSUPP) { > - iput(inode); > - return error; > - } > - error = 0; > + if (error && error != -EOPNOTSUPP) { > + iput(inode); > + return error; > } > > inode->i_size = len-1; > -- > 2.17.1 Acked-by : Pankaj Gupta > >