From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F3FCC10F25 for ; Mon, 9 Mar 2020 19:18:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 50A7520848 for ; Mon, 9 Mar 2020 19:18:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RbWSxsuk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 50A7520848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DDFE36B0005; Mon, 9 Mar 2020 15:18:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D90426B0006; Mon, 9 Mar 2020 15:18:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA5216B0007; Mon, 9 Mar 2020 15:18:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0210.hostedemail.com [216.40.44.210]) by kanga.kvack.org (Postfix) with ESMTP id B01A06B0005 for ; Mon, 9 Mar 2020 15:18:36 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 863AB180AD811 for ; Mon, 9 Mar 2020 19:18:36 +0000 (UTC) X-FDA: 76576785432.16.trip75_4b20b3da5a613 X-HE-Tag: trip75_4b20b3da5a613 X-Filterd-Recvd-Size: 4192 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Mon, 9 Mar 2020 19:18:36 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id s5so8771106wrg.3 for ; Mon, 09 Mar 2020 12:18:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nel37kuibzHaBYDLpoHBKpnBf47njnU3CDEWJgpq/NE=; b=RbWSxsukphGqbbZl7oSXM/0cMKq6FDH/jcL5RDqzZun2enlU+iE8HRnqcFs9DuY4+L h0DucJvizxGZac3siquyn+jo775ZlymbWlZ1KCriexSMduZOlnzugBWQhWUW3R8qH1Tr mYyrpWU4fMzF77R6H2OfTj6l/iZSRmx0RAjAJGtsV11n8+VjOes22WAZ5sEX7AIubj39 fQftet+hvjQGIv7tiNr8PGwnzQaWNRNfVJQ9KCRgm6kymJ1ZlTsKcO4zx7b0o+sM1T0e /SoygHxw5l3zJfYUzdTxOTIdW9Ad9vaUnSHf2gcxynjxBD/2D5OxsGXBCDk6LDSHxe/R PbmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nel37kuibzHaBYDLpoHBKpnBf47njnU3CDEWJgpq/NE=; b=ZY8xM8Zk1yrNhp0DLRk7nE6x/Xu2DHOjuwVIZ9qEne+QLbBg27rSCitdOTGe8Kfk9t Sh8H0qj1DHXNghCI97r5PVJuxy2UHAq2CSLBGSuEUlIyMVJfDxa/cUlIgEzqXWmkghIh RwbiF9iq78KQgw9MOT4s8RZJGSiWu1udRNmbXpIBQBNbP4+Za4fJytq2wasVnb2BCi3s E8cECjPuvdPcZll1CNMkHOaKNMCwi09PqQICA8Bg6ZdDPHDtA6Y8+pQpGJ1wS1Kle2eu jyPSxbdzw9ZQZdq6KGN8Udx/6NGxWvgu+hSutAyC40TN7BDFa1Ljs15kMUYjxNmmHMI7 aunA== X-Gm-Message-State: ANhLgQ35a1FoyaCQ7tL5bzR72Yz7WPuWLtc4Xt49W6yr4Le5QsP7mAXm Rd+6+XeijMSWZDZ26qgSJM784tCjj/kccLQMRiQ= X-Google-Smtp-Source: ADFU+vvVrvmykSnxgpCT7ali6/YfDZ3hmfiCa29AZU3Y/9wlfF5/Kuo/CTcHw0z3ORa8mZbLhCAptUfS+ppJFMTSm9U= X-Received: by 2002:a5d:6544:: with SMTP id z4mr3994019wrv.298.1583781514817; Mon, 09 Mar 2020 12:18:34 -0700 (PDT) MIME-Version: 1.0 References: <1583655036-5025-1-git-send-email-qiwuchen55@gmail.com> In-Reply-To: <1583655036-5025-1-git-send-email-qiwuchen55@gmail.com> From: Pankaj Gupta Date: Mon, 9 Mar 2020 20:18:23 +0100 Message-ID: Subject: Re: [PATCH] mm/page_alloc: simplify page_is_buddy() for better code readability To: qiwuchen55@gmail.com Cc: Andrew Morton , linux-mm@kvack.org, chenqiwu Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > From: chenqiwu > > Simplify page_is_buddy() to reduce the redundant code for better > code readability. > > Signed-off-by: chenqiwu > --- > mm/page_alloc.c | 13 +++---------- > 1 file changed, 3 insertions(+), 10 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 79e950d..c6eef38 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -797,16 +797,8 @@ static inline void set_page_order(struct page *page, unsigned int order) > static inline int page_is_buddy(struct page *page, struct page *buddy, > unsigned int order) > { > - if (page_is_guard(buddy) && page_order(buddy) == order) { > - if (page_zone_id(page) != page_zone_id(buddy)) > - return 0; > - > - VM_BUG_ON_PAGE(page_count(buddy) != 0, buddy); > - > - return 1; > - } > - > - if (PageBuddy(buddy) && page_order(buddy) == order) { > + if ((page_is_guard(buddy) || PageBuddy(buddy)) > + && page_order(buddy) == order) { > /* > * zone check is done late to avoid uselessly > * calculating zone/node ids for pages that could > @@ -819,6 +811,7 @@ static inline int page_is_buddy(struct page *page, struct page *buddy, > > return 1; > } > + > return 0; > } Looks good to me. Acked-by: Pankaj Gupta > > -- > 1.9.1 > >