From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28F4DC433DF for ; Thu, 15 Oct 2020 20:31:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 847972074A for ; Thu, 15 Oct 2020 20:31:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="c0u0Re/d" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 847972074A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 937DF6B0062; Thu, 15 Oct 2020 16:31:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E98B6B0068; Thu, 15 Oct 2020 16:31:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 826516B006E; Thu, 15 Oct 2020 16:31:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0147.hostedemail.com [216.40.44.147]) by kanga.kvack.org (Postfix) with ESMTP id 5556A6B0062 for ; Thu, 15 Oct 2020 16:31:15 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id DABA7180AD811 for ; Thu, 15 Oct 2020 20:31:14 +0000 (UTC) X-FDA: 77375304468.13.brake97_010849027217 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id B1A2018140B70 for ; Thu, 15 Oct 2020 20:31:14 +0000 (UTC) X-HE-Tag: brake97_010849027217 X-Filterd-Recvd-Size: 4917 Received: from mail-il1-f195.google.com (mail-il1-f195.google.com [209.85.166.195]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Thu, 15 Oct 2020 20:31:14 +0000 (UTC) Received: by mail-il1-f195.google.com with SMTP id z2so4770668ilh.11 for ; Thu, 15 Oct 2020 13:31:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KMEoBpSpf5ITv96lwr1E/oq/2FCY57jpAaduGuTPcdI=; b=c0u0Re/dOCSPaDfhhy9zAOz8zbYQs1/ORCwhrN5/0vmsDvcgn6i3yy6b7/rbmWY/cF 69vGTKrvnq1NvAFGCeaa0mer8JhGOMG0/neIUwtuHP1DMlA+2X+u21nu6X2nmMJEocp9 aJj1dFh7UogkZAScFWdWOPmz9En2d2rttEIAZ+5/Wl1umvnhp+BcQibIgQEVjJmaja6t jwnAGrfExUXeQf3xI4CpJVse2KZBsNEBajuW4GzWVtxXEBazAv3Y2s9RVIfmECugvMDR J9+MRKV1gZhCKz8e5Ue93ZuwzW5XSfyr3UJhpFy83w2lyHvTJe+A9gxI43dMmirBf69J /uqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KMEoBpSpf5ITv96lwr1E/oq/2FCY57jpAaduGuTPcdI=; b=no1PUg/iYCNZMAnJcM48xVZZM1x3gWGyja0NjB9uCCyRvzQzfMHLYcWDtm9ykyCAEq FNrvxcAhPcgSY5p3d5i7MPBhzOPBMcrE3mFvIr3xoLYPzNkStr9N1HQ2S+ZydMZats+N poD2E1bWlnXHGIwdFDwCyu8nF/veUMUE05adO2eh3ZDgjrairo975cHdZ7yGuvsPefmH HqHrvCr3j4oKSr257Ged7TzZ4nXLp6ltGaiPa6DmQkVsJeTuIvKxSWAHB9Av7UHBQZLB VoZrZqYC26kqBBnMfM0YugK/wIHVNYhQsoowVQQ+zjzGSXiwWZe7CAD0nhOBwZYomNhi 8jiQ== X-Gm-Message-State: AOAM530cmfkRLm3QDYdAfSHAxnBRlsLXBW/jGSE7TTVN7kCy/r3kkUdU NTjf+vCsc261Tb99CFKIT7FHojXd9Iplf3yKxOU= X-Google-Smtp-Source: ABdhPJw27itUGJwpE6ecTiJLPMcG+8G7avBYojcFJaZYKj3gfLThWSK9B2UYHnLOzIVMPQddockt9gKmy3btJT/dxrI= X-Received: by 2002:a92:180b:: with SMTP id 11mr273536ily.89.1602793873755; Thu, 15 Oct 2020 13:31:13 -0700 (PDT) MIME-Version: 1.0 References: <20201012125323.17509-1-david@redhat.com> <20201012125323.17509-12-david@redhat.com> In-Reply-To: <20201012125323.17509-12-david@redhat.com> From: Pankaj Gupta Date: Thu, 15 Oct 2020 22:31:02 +0200 Message-ID: Subject: Re: [PATCH v1 11/29] virtio-mem: use "unsigned long" for nr_pages when fake onlining/offlining To: David Hildenbrand Cc: LKML , Linux MM , virtualization@lists.linux-foundation.org, Andrew Morton , "Michael S . Tsirkin" , Jason Wang Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > No harm done, but let's be consistent. > > Cc: "Michael S. Tsirkin" > Cc: Jason Wang > Cc: Pankaj Gupta > Signed-off-by: David Hildenbrand > --- > drivers/virtio/virtio_mem.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c > index cb2e8f254650..00d1cfca4713 100644 > --- a/drivers/virtio/virtio_mem.c > +++ b/drivers/virtio/virtio_mem.c > @@ -766,7 +766,7 @@ static int virtio_mem_memory_notifier_cb(struct notifier_block *nb, > * (via generic_online_page()) using PageDirty(). > */ > static void virtio_mem_set_fake_offline(unsigned long pfn, > - unsigned int nr_pages, bool onlined) > + unsigned long nr_pages, bool onlined) > { > for (; nr_pages--; pfn++) { > struct page *page = pfn_to_page(pfn); > @@ -785,7 +785,7 @@ static void virtio_mem_set_fake_offline(unsigned long pfn, > * (via generic_online_page()), clear PageDirty(). > */ > static void virtio_mem_clear_fake_offline(unsigned long pfn, > - unsigned int nr_pages, bool onlined) > + unsigned long nr_pages, bool onlined) > { > for (; nr_pages--; pfn++) { > struct page *page = pfn_to_page(pfn); > @@ -800,10 +800,10 @@ static void virtio_mem_clear_fake_offline(unsigned long pfn, > * Release a range of fake-offline pages to the buddy, effectively > * fake-onlining them. > */ > -static void virtio_mem_fake_online(unsigned long pfn, unsigned int nr_pages) > +static void virtio_mem_fake_online(unsigned long pfn, unsigned long nr_pages) > { > const unsigned long max_nr_pages = MAX_ORDER_NR_PAGES; > - int i; > + unsigned long i; > > /* > * We are always called at least with MAX_ORDER_NR_PAGES Reviewed-by: Pankaj Gupta