From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2951CC433E6 for ; Mon, 31 Aug 2020 10:11:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C0E7A2083E for ; Mon, 31 Aug 2020 10:11:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aIfzL5aq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C0E7A2083E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 309326B0002; Mon, 31 Aug 2020 06:11:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2DF876B0003; Mon, 31 Aug 2020 06:11:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1CE986B0005; Mon, 31 Aug 2020 06:11:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0145.hostedemail.com [216.40.44.145]) by kanga.kvack.org (Postfix) with ESMTP id 04C356B0002 for ; Mon, 31 Aug 2020 06:11:01 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id B0DD6180AD811 for ; Mon, 31 Aug 2020 10:11:00 +0000 (UTC) X-FDA: 77210445480.06.tooth89_361109c2708e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id 845C61003980C for ; Mon, 31 Aug 2020 10:11:00 +0000 (UTC) X-HE-Tag: tooth89_361109c2708e X-Filterd-Recvd-Size: 4940 Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Mon, 31 Aug 2020 10:10:59 +0000 (UTC) Received: by mail-io1-f65.google.com with SMTP id j2so5243823ioj.7 for ; Mon, 31 Aug 2020 03:10:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0k+KQgm9kL6xww1fb1hoPu9g9hiRqIgB5Qw8A8UEDhE=; b=aIfzL5aqvj0wBTArEigzQuLx+zj75KaYySwRSY8/D4rEZysbo2YOlmDn+O1NMl8vDM wVvXXeDT8UIyWHwaxU3JDGMWQZEH/3qv7/ddqX1Y8Ge5N1GQk29uRiXZLFavn7Jtw1Yl 4WIgcwjkYWw3jHV7fV2Q3fGerCWhDu/X80Me9Zf6PUYl++z4GD2hfwqfMegD1+t49mdi Y9MYAqysWoR9+12U/HG7VbDYTJ8SaCzdeelRfonWTCnvA9GISHk9Rw9qzcaoeuzdBw+i J8DwuTUifhuovofDUayp3GKiKl7bT9B6348vTH2bmq991ewpk7NviidcDXKTYUTirrLn t94w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0k+KQgm9kL6xww1fb1hoPu9g9hiRqIgB5Qw8A8UEDhE=; b=fD1gINdImdArmpyKXl/qjbfKJebm9Hcwk3SxMzznP2gH0GB3M1E+YK5//t2q+15CLT +bjL+5fkbyGBOe7xXEuPL2zTFlGO9EXYEC448Guv8iFDZsiN9DzG0whK/OoGkB78yXhE pUcmXXM8v6szH9glFk2rNN4tAvPWR6VlluwQSgHOk2kMTXMgpTK3bJgwU7TUbIjI518W j01NIVxUfVWu28ZRXP/HBuwVH+kpl01kPdED43jLA3SIyaxOedPac80Ipu9/SIWtK4Dp f1LFfRvW76jJnRFnow/c5xAjfKI2j/a/T3wa+9sRADRr5p/HP5NfMTRd5s9FANImkAib 7Eog== X-Gm-Message-State: AOAM531plUxo55Ck/ziPGXIPGt6WkwvCA33ucWu4u57fqG8kHKeHqd1I qebLcD7xE6KyERfPZ8mzd6IgnK2cAeRcOGMjYyw= X-Google-Smtp-Source: ABdhPJxJ681pHHMHEeJmyAbxBqrvgyKgkzH+yeDo1dHdsAqBtZbasXyu/MHqugwTFLjVIviPZUxFwhhqdJr2qcTpt28= X-Received: by 2002:a5e:8707:: with SMTP id y7mr653272ioj.49.1598868659544; Mon, 31 Aug 2020 03:10:59 -0700 (PDT) MIME-Version: 1.0 References: <20200819101157.12723-1-david@redhat.com> <20200819101157.12723-4-david@redhat.com> In-Reply-To: <20200819101157.12723-4-david@redhat.com> From: Pankaj Gupta Date: Mon, 31 Aug 2020 12:10:48 +0200 Message-ID: Subject: Re: [PATCH v1 03/11] mm/memory_hotplug: simplify checking if all pages are isolated in offline_pages() To: David Hildenbrand Cc: LKML , Linux MM , Andrew Morton , Michal Hocko , Wei Yang , Baoquan He , Oscar Salvador Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 845C61003980C X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > We make sure that we cannot have any memory holes right at the beginning > of offline_pages(). We no longer need walk_system_ram_range() and can > call test_pages_isolated() directly. > > Cc: Andrew Morton > Cc: Michal Hocko > Cc: Wei Yang > Cc: Baoquan He > Cc: Pankaj Gupta > Cc: Oscar Salvador > Signed-off-by: David Hildenbrand > --- > mm/memory_hotplug.c | 16 +--------------- > 1 file changed, 1 insertion(+), 15 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 6856702af68d9..f64478349148d 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1384,17 +1384,6 @@ offline_isolated_pages_cb(unsigned long start, unsigned long nr_pages, > return 0; > } > > -/* > - * Check all pages in range, recorded as memory resource, are isolated. > - */ > -static int > -check_pages_isolated_cb(unsigned long start_pfn, unsigned long nr_pages, > - void *data) > -{ > - return test_pages_isolated(start_pfn, start_pfn + nr_pages, > - MEMORY_OFFLINE); > -} > - > static int __init cmdline_parse_movable_node(char *p) > { > movable_node_enabled = true; > @@ -1579,10 +1568,7 @@ int __ref offline_pages(unsigned long start_pfn, unsigned long nr_pages) > reason = "failure to dissolve huge pages"; > goto failed_removal_isolated; > } > - /* check again */ > - ret = walk_system_ram_range(start_pfn, end_pfn - start_pfn, > - NULL, check_pages_isolated_cb); > - } while (ret); > + } while (test_pages_isolated(start_pfn, end_pfn, MEMORY_OFFLINE)); > > /* Ok, all of our target is isolated. > We cannot do rollback at this point. */ > -- > 2.26.2 Acked-by: Pankaj Gupta