From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44263C433DF for ; Tue, 20 Oct 2020 09:22:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 707322237B for ; Tue, 20 Oct 2020 09:22:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EDKxuR4E" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 707322237B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9AE326B005C; Tue, 20 Oct 2020 05:22:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 95E666B0062; Tue, 20 Oct 2020 05:22:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 84CE56B006E; Tue, 20 Oct 2020 05:22:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0252.hostedemail.com [216.40.44.252]) by kanga.kvack.org (Postfix) with ESMTP id 57DA76B005C for ; Tue, 20 Oct 2020 05:22:57 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id E5E11180AD802 for ; Tue, 20 Oct 2020 09:22:56 +0000 (UTC) X-FDA: 77391764352.25.wrist50_38164642723e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id D3F811804E3A0 for ; Tue, 20 Oct 2020 09:22:56 +0000 (UTC) X-HE-Tag: wrist50_38164642723e X-Filterd-Recvd-Size: 4332 Received: from mail-il1-f195.google.com (mail-il1-f195.google.com [209.85.166.195]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Tue, 20 Oct 2020 09:22:56 +0000 (UTC) Received: by mail-il1-f195.google.com with SMTP id j17so1333250ilr.2 for ; Tue, 20 Oct 2020 02:22:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wWmw1NV7gbWNc2BoUTFwu8FGKZUBcJpPXw0NA4jr4Bk=; b=EDKxuR4EF785e5FhWc5bAAo35H3YMcr75neMvBR5SA6OpTLU2UxaqTvB+dzjheFuUY nSSCIdMUg7u2EmPyHfEHbo/cPxAuyDUZs7GJXMkSjGh4pj4RIw3jnWZ1v2vGeFS9PYpQ qHvuMAe2n+UHlnsZCBRMqLyqlrP4Lfu8fcUNdFoB5VwXEooCom3oAO5jcYK9PwS8lCNk L3U2o6TFqod2uOs9IcWezcd1bB78LvJKEllgAHnBtVQFJV2qwIMtwANCOJ4AXlnyqxHI i2XJSXhDYZAG08oos6LHJxlMq29f+GB+Wn7Z+ydeeGurwT6JunzkwQ4f8ANe0qwONtpV 9FHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wWmw1NV7gbWNc2BoUTFwu8FGKZUBcJpPXw0NA4jr4Bk=; b=kactCfX5smJ5ZwMAHDXObaW9BToFRcktV6nNqvrvMeE96XR3EzQgRxjm0MRj1jv+Lg aY2MvUZ5tqKvKjRBrwWMmanzQOXnqkYYuNsWD9pKv2+sm24jrQykEOrqvA0Mfed66Qk5 jEu7DuECupOQOirUOfzMRfJ0tw2U8h3eLU1xAl0/Mc3C6R2e8cuYUHY4wcilEMeI1MwA hEo40IwAuYUAJGRQKn80Q0UfoUZOxY60k+t+UUwAvREW4AoK04YPDmG/9ct39TLVW/20 6WvxHSW3WzTVYV78B00MZ5jUx9ws7dxUqfYdWAMBJ77yy8kSDDssTgtunYzVkTxBDf6w F6cg== X-Gm-Message-State: AOAM532u2PuzBx11N7/2q9m7eaApdDXNoRAhU0Sb7DFoqhUCnqIB+YG6 a6hUfUEn/JsCCyWq8jx7vwh0rvQ/16hyV/CcSsgkVzXox0eDmw== X-Google-Smtp-Source: ABdhPJxC+ot7T75FkO1+J7+MSBrDulfWIWZX0EZ1N+ymQwTAx7MbhOvrWo8aFRRXyJXXAYSqJ7JWigVNX8dWGt9hUYo= X-Received: by 2002:a92:180b:: with SMTP id 11mr1207045ily.89.1603185775910; Tue, 20 Oct 2020 02:22:55 -0700 (PDT) MIME-Version: 1.0 References: <20201012125323.17509-1-david@redhat.com> <20201012125323.17509-8-david@redhat.com> In-Reply-To: <20201012125323.17509-8-david@redhat.com> From: Pankaj Gupta Date: Tue, 20 Oct 2020 11:22:45 +0200 Message-ID: Subject: Re: [PATCH v1 07/29] virtio-mem: generalize virtio_mem_overlaps_range() To: David Hildenbrand Cc: LKML , Linux MM , virtualization@lists.linux-foundation.org, Andrew Morton , "Michael S . Tsirkin" , Jason Wang Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Avoid using memory block ids. While at it, use uint64_t for > address/size. > > Cc: "Michael S. Tsirkin" > Cc: Jason Wang > Cc: Pankaj Gupta > Signed-off-by: David Hildenbrand > --- > drivers/virtio/virtio_mem.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c > index 821143db14fe..37a0e338ae4a 100644 > --- a/drivers/virtio/virtio_mem.c > +++ b/drivers/virtio/virtio_mem.c > @@ -489,14 +489,10 @@ static int virtio_mem_translate_node_id(struct virtio_mem *vm, uint16_t node_id) > * Test if a virtio-mem device overlaps with the given range. Can be called > * from (notifier) callbacks lockless. > */ > -static bool virtio_mem_overlaps_range(struct virtio_mem *vm, > - unsigned long start, unsigned long size) > +static bool virtio_mem_overlaps_range(struct virtio_mem *vm, uint64_t start, > + uint64_t size) > { > - unsigned long dev_start = virtio_mem_mb_id_to_phys(vm->first_mb_id); > - unsigned long dev_end = virtio_mem_mb_id_to_phys(vm->last_mb_id) + > - memory_block_size_bytes(); > - > - return start < dev_end && dev_start < start + size; > + return start < vm->addr + vm->region_size && vm->addr < start + size; > } Reviewed-by: Pankaj Gupta