From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8F7DC47420 for ; Mon, 28 Sep 2020 20:12:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5A435205ED for ; Mon, 28 Sep 2020 20:12:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TDPgclhn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A435205ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B69836B005D; Mon, 28 Sep 2020 16:12:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF2316B0070; Mon, 28 Sep 2020 16:12:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9EABA6B0071; Mon, 28 Sep 2020 16:12:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7FCDE6B005D for ; Mon, 28 Sep 2020 16:12:12 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 45105282D for ; Mon, 28 Sep 2020 20:12:12 +0000 (UTC) X-FDA: 77313566904.19.swing07_0e0c0bb27184 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id 200CC1ACEAD for ; Mon, 28 Sep 2020 20:12:12 +0000 (UTC) X-HE-Tag: swing07_0e0c0bb27184 X-Filterd-Recvd-Size: 7306 Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Mon, 28 Sep 2020 20:12:11 +0000 (UTC) Received: by mail-io1-f66.google.com with SMTP id g7so2456946iov.13 for ; Mon, 28 Sep 2020 13:12:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xZKymCvf/3hB0NedV8stXCWKWuXrWGW8+XBJgCfh+LE=; b=TDPgclhnBlWg5VXfidWvaVODif2Ky2Ysrfbe6qlsall+wU6K4b9E0/tbX04SDmq9EQ jTaWRxt9S1JvFQXXdGnFm2JLjA3fOSc827Wdz7c3b27/bT7K90mdObWR39grRzS2YgWk CwpRDvAOYYt8KmZNc0+eN5dqSXCAtB+9sjeZ+WDr1ClzwF20lChfVuJSdvGqhsu4ujlC R4VXPQ8KsQM0k/4GV8k2EEPRsNcwIcBrzAn0s+XXZ/iBi+b2galei+43oEog2fHYBSJF qEQZ/wcEqdEq0I0im8TxSAzTKEpZns5PrYvPNIEtTSuSjQ+vkU5R1ArhwXV4hkv6K+BB 1c7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xZKymCvf/3hB0NedV8stXCWKWuXrWGW8+XBJgCfh+LE=; b=ByG9HTakjmX1y0Nwq6H/KY3X34u/TR9CAOhxDEGeObfNMJTNsOJ0Rb3OoDSGek0pWC +Yc3WoBWc+z4L7KmiUo/VxSlDXEN2GsBICH5+UPLYgElZHYkH4fJiamPlCfwfsFzPrfs 9h9nEAdxrLAqLrD6Kd6gAe3k2tjDB5G7qlBWPKQkYcAejDVS/CEpvIJz4D4v1npQ2xri EUMHviNQRBoGOReh3vdkcLG4jVCCmPC4Y+yFmK4doDMr+iOrXglZ9B3E5vrlyHwayAO1 6sEiL4I/EIOTd1j3g7uTMrMjaief9psTTBAmwzve7EwGjyg11uNvCUeU8QGsRAQjmvlM jhhA== X-Gm-Message-State: AOAM532xnZ8DJ+tu+wAl9GJIxDbjNS0yqtnI/d2SCzq5u7EHi2w3JHiY 4/g63BPttbicsVbSmdwslcpoUuuVKDNsjYuiPOw= X-Google-Smtp-Source: ABdhPJwRZYvxUM8BpdXgvXa6N707vOvCxbfH4iYi81EiZ5QMYe/87ZNldkSa6kbFMWFqlFO15K6N5K6tS6C14JIcttA= X-Received: by 2002:a6b:2b45:: with SMTP id r66mr8189635ior.159.1601323930836; Mon, 28 Sep 2020 13:12:10 -0700 (PDT) MIME-Version: 1.0 References: <20200928182110.7050-1-david@redhat.com> <20200928182110.7050-2-david@redhat.com> In-Reply-To: <20200928182110.7050-2-david@redhat.com> From: Pankaj Gupta Date: Mon, 28 Sep 2020 22:11:59 +0200 Message-ID: Subject: Re: [PATCH v1 1/5] mm/page_alloc: convert "report" flag of __free_one_page() to a proper flag To: David Hildenbrand Cc: LKML , Linux MM , linux-hyperv@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, Andrew Morton , Alexander Duyck , Vlastimil Babka , Oscar Salvador , Mel Gorman , Michal Hocko , Dave Hansen , Wei Yang , Mike Rapoport Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Let's prepare for additional flags and avoid long parameter lists of bools. > Follow-up patches will also make use of the flags in __free_pages_ok(), > however, I wasn't able to come up with a better name for the type - should > be good enough for internal purposes. > > Reviewed-by: Alexander Duyck > Reviewed-by: Vlastimil Babka > Reviewed-by: Oscar Salvador > Cc: Andrew Morton > Cc: Alexander Duyck > Cc: Mel Gorman > Cc: Michal Hocko > Cc: Dave Hansen > Cc: Vlastimil Babka > Cc: Wei Yang > Cc: Oscar Salvador > Cc: Mike Rapoport > Signed-off-by: David Hildenbrand > --- > mm/page_alloc.c | 28 ++++++++++++++++++++-------- > 1 file changed, 20 insertions(+), 8 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index df90e3654f97..daab90e960fe 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -77,6 +77,18 @@ > #include "shuffle.h" > #include "page_reporting.h" > > +/* Free One Page flags: for internal, non-pcp variants of free_pages(). */ > +typedef int __bitwise fop_t; > + > +/* No special request */ > +#define FOP_NONE ((__force fop_t)0) > + > +/* > + * Skip free page reporting notification for the (possibly merged) page. (will > + * *not* mark the page reported, only skip the notification). > + */ > +#define FOP_SKIP_REPORT_NOTIFY ((__force fop_t)BIT(0)) > + > /* prevent >1 _updater_ of zone percpu pageset ->high and ->batch fields */ > static DEFINE_MUTEX(pcp_batch_high_lock); > #define MIN_PERCPU_PAGELIST_FRACTION (8) > @@ -948,10 +960,9 @@ buddy_merge_likely(unsigned long pfn, unsigned long buddy_pfn, > * -- nyc > */ > > -static inline void __free_one_page(struct page *page, > - unsigned long pfn, > - struct zone *zone, unsigned int order, > - int migratetype, bool report) > +static inline void __free_one_page(struct page *page, unsigned long pfn, > + struct zone *zone, unsigned int order, > + int migratetype, fop_t fop_flags) > { > struct capture_control *capc = task_capc(zone); > unsigned long buddy_pfn; > @@ -1038,7 +1049,7 @@ static inline void __free_one_page(struct page *page, > add_to_free_list(page, zone, order, migratetype); > > /* Notify page reporting subsystem of freed page */ > - if (report) > + if (!(fop_flags & FOP_SKIP_REPORT_NOTIFY)) > page_reporting_notify_free(order); > } > > @@ -1379,7 +1390,7 @@ static void free_pcppages_bulk(struct zone *zone, int count, > if (unlikely(isolated_pageblocks)) > mt = get_pageblock_migratetype(page); > > - __free_one_page(page, page_to_pfn(page), zone, 0, mt, true); > + __free_one_page(page, page_to_pfn(page), zone, 0, mt, FOP_NONE); > trace_mm_page_pcpu_drain(page, 0, mt); > } > spin_unlock(&zone->lock); > @@ -1395,7 +1406,7 @@ static void free_one_page(struct zone *zone, > is_migrate_isolate(migratetype))) { > migratetype = get_pfnblock_migratetype(page, pfn); > } > - __free_one_page(page, pfn, zone, order, migratetype, true); > + __free_one_page(page, pfn, zone, order, migratetype, FOP_NONE); > spin_unlock(&zone->lock); > } > > @@ -3288,7 +3299,8 @@ void __putback_isolated_page(struct page *page, unsigned int order, int mt) > lockdep_assert_held(&zone->lock); > > /* Return isolated page to tail of freelist. */ > - __free_one_page(page, page_to_pfn(page), zone, order, mt, false); > + __free_one_page(page, page_to_pfn(page), zone, order, mt, > + FOP_SKIP_REPORT_NOTIFY); > } Reviewed-by: Pankaj Gupta