From: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
To: David Hildenbrand <david@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>,
virtio-dev@lists.oasis-open.org,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
Michal Hocko <mhocko@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"Michael S . Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v4 11/15] virtio-mem: Add parent resource for all added "System RAM"
Date: Thu, 7 May 2020 16:06:30 +0200 [thread overview]
Message-ID: <CAM9Jb+jXy6Adhg=GstpMZN3roo1uQuikj2hpsxGj6-JUQU3oGA@mail.gmail.com> (raw)
In-Reply-To: <20200507140139.17083-12-david@redhat.com>
> Let's add a parent resource, named after the virtio device (inspired by
> drivers/dax/kmem.c). This allows user space to identify which memory
> belongs to which virtio-mem device.
>
> With this change and two virtio-mem devices:
> :/# cat /proc/iomem
> 00000000-00000fff : Reserved
> 00001000-0009fbff : System RAM
> [...]
> 140000000-333ffffff : virtio0
> 140000000-147ffffff : System RAM
> 148000000-14fffffff : System RAM
> 150000000-157ffffff : System RAM
> [...]
> 334000000-3033ffffff : virtio1
> 338000000-33fffffff : System RAM
> 340000000-347ffffff : System RAM
> 348000000-34fffffff : System RAM
> [...]
>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> drivers/virtio/virtio_mem.c | 52 ++++++++++++++++++++++++++++++++++++-
> 1 file changed, 51 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
> index eb4c16d634e0..80cdb9e6b3c4 100644
> --- a/drivers/virtio/virtio_mem.c
> +++ b/drivers/virtio/virtio_mem.c
> @@ -99,6 +99,9 @@ struct virtio_mem {
> /* Id of the next memory bock to prepare when needed. */
> unsigned long next_mb_id;
>
> + /* The parent resource for all memory added via this device. */
> + struct resource *parent_resource;
> +
> /* Summary of all memory block states. */
> unsigned long nb_mb_state[VIRTIO_MEM_MB_STATE_COUNT];
> #define VIRTIO_MEM_NB_OFFLINE_THRESHOLD 10
> @@ -1741,6 +1744,44 @@ static int virtio_mem_init(struct virtio_mem *vm)
> return 0;
> }
>
> +static int virtio_mem_create_resource(struct virtio_mem *vm)
> +{
> + /*
> + * When force-unloading the driver and removing the device, we
> + * could have a garbage pointer. Duplicate the string.
> + */
> + const char *name = kstrdup(dev_name(&vm->vdev->dev), GFP_KERNEL);
> +
> + if (!name)
> + return -ENOMEM;
> +
> + vm->parent_resource = __request_mem_region(vm->addr, vm->region_size,
> + name, IORESOURCE_SYSTEM_RAM);
> + if (!vm->parent_resource) {
> + kfree(name);
> + dev_warn(&vm->vdev->dev, "could not reserve device region\n");
> + return -EBUSY;
> + }
> +
> + /* The memory is not actually busy - make add_memory() work. */
> + vm->parent_resource->flags &= ~IORESOURCE_BUSY;
> + return 0;
> +}
> +
> +static void virtio_mem_delete_resource(struct virtio_mem *vm)
> +{
> + const char *name;
> +
> + if (!vm->parent_resource)
> + return;
> +
> + name = vm->parent_resource->name;
> + release_resource(vm->parent_resource);
> + kfree(vm->parent_resource);
> + kfree(name);
> + vm->parent_resource = NULL;
> +}
> +
> static int virtio_mem_probe(struct virtio_device *vdev)
> {
> struct virtio_mem *vm;
> @@ -1770,11 +1811,16 @@ static int virtio_mem_probe(struct virtio_device *vdev)
> if (rc)
> goto out_del_vq;
>
> + /* create the parent resource for all memory */
> + rc = virtio_mem_create_resource(vm);
> + if (rc)
> + goto out_del_vq;
> +
> /* register callbacks */
> vm->memory_notifier.notifier_call = virtio_mem_memory_notifier_cb;
> rc = register_memory_notifier(&vm->memory_notifier);
> if (rc)
> - goto out_del_vq;
> + goto out_del_resource;
> rc = register_virtio_mem_device(vm);
> if (rc)
> goto out_unreg_mem;
> @@ -1788,6 +1834,8 @@ static int virtio_mem_probe(struct virtio_device *vdev)
> return 0;
> out_unreg_mem:
> unregister_memory_notifier(&vm->memory_notifier);
> +out_del_resource:
> + virtio_mem_delete_resource(vm);
> out_del_vq:
> vdev->config->del_vqs(vdev);
> out_free_vm:
> @@ -1848,6 +1896,8 @@ static void virtio_mem_remove(struct virtio_device *vdev)
> vm->nb_mb_state[VIRTIO_MEM_MB_STATE_ONLINE_PARTIAL] ||
> vm->nb_mb_state[VIRTIO_MEM_MB_STATE_ONLINE_MOVABLE])
> dev_warn(&vdev->dev, "device still has system memory added\n");
> + else
> + virtio_mem_delete_resource(vm);
>
> /* remove all tracking data - no locking needed */
> vfree(vm->mb_state);
> --
Reviewed-by: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
next prev parent reply other threads:[~2020-05-07 14:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 14:01 [PATCH v4 00/15] virtio-mem: paravirtualized memory David Hildenbrand
2020-05-07 14:01 ` [PATCH v4 01/15] virtio-mem: Paravirtualized memory hotplug David Hildenbrand
2020-05-07 14:01 ` [PATCH v4 02/15] MAINTAINERS: Add myself as virtio-mem maintainer David Hildenbrand
2020-05-07 14:01 ` [PATCH v4 03/15] virtio-mem: Allow to specify an ACPI PXM as nid David Hildenbrand
2020-05-07 14:01 ` [PATCH v4 04/15] virtio-mem: Paravirtualized memory hotunplug part 1 David Hildenbrand
2020-05-07 14:01 ` [PATCH v4 05/15] virtio-mem: Paravirtualized memory hotunplug part 2 David Hildenbrand
2020-05-07 14:01 ` [PATCH v4 06/15] mm: Allow to offline unmovable PageOffline() pages via MEM_GOING_OFFLINE David Hildenbrand
2020-05-07 14:01 ` [PATCH v4 07/15] virtio-mem: Allow to offline partially unplugged memory blocks David Hildenbrand
2020-05-07 14:01 ` [PATCH v4 08/15] mm/memory_hotplug: Introduce offline_and_remove_memory() David Hildenbrand
2020-05-07 14:01 ` [PATCH v4 09/15] virtio-mem: Offline and remove completely unplugged memory blocks David Hildenbrand
2020-05-07 14:01 ` [PATCH v4 10/15] virtio-mem: Better retry handling David Hildenbrand
2020-05-07 14:01 ` [PATCH v4 11/15] virtio-mem: Add parent resource for all added "System RAM" David Hildenbrand
2020-05-07 14:06 ` Pankaj Gupta [this message]
2020-05-07 14:01 ` [PATCH v4 12/15] virtio-mem: Drop manual check for already present memory David Hildenbrand
2020-05-07 14:01 ` [PATCH v4 13/15] virtio-mem: Unplug subblocks right-to-left David Hildenbrand
2020-05-07 14:01 ` [PATCH v4 14/15] virtio-mem: Use -ETXTBSY as error code if the device is busy David Hildenbrand
2020-05-07 14:01 ` [PATCH v4 15/15] virtio-mem: Try to unplug the complete online memory block first David Hildenbrand
2020-05-15 10:14 ` [PATCH v4 16/15] virtio-mem: Don't rely on implicit compiler padding for requests David Hildenbrand
2020-05-20 5:25 ` [PATCH v4 00/15] virtio-mem: paravirtualized memory teawater
2020-05-20 7:56 ` David Hildenbrand
2020-06-02 7:09 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM9Jb+jXy6Adhg=GstpMZN3roo1uQuikj2hpsxGj6-JUQU3oGA@mail.gmail.com' \
--to=pankaj.gupta.linux@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mst@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).