From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81D85C433DF for ; Thu, 15 Oct 2020 20:30:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7BCA52074D for ; Thu, 15 Oct 2020 20:30:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m6ii6kwg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7BCA52074D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C6DDE6B005C; Thu, 15 Oct 2020 16:30:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C1EFC6B0062; Thu, 15 Oct 2020 16:30:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B36996B0068; Thu, 15 Oct 2020 16:30:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0107.hostedemail.com [216.40.44.107]) by kanga.kvack.org (Postfix) with ESMTP id 86DB56B005C for ; Thu, 15 Oct 2020 16:30:22 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 12816362D for ; Thu, 15 Oct 2020 20:30:22 +0000 (UTC) X-FDA: 77375302284.24.cat54_3d06a9d27217 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id E570A1A4A0 for ; Thu, 15 Oct 2020 20:30:21 +0000 (UTC) X-HE-Tag: cat54_3d06a9d27217 X-Filterd-Recvd-Size: 4640 Received: from mail-il1-f194.google.com (mail-il1-f194.google.com [209.85.166.194]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Thu, 15 Oct 2020 20:30:21 +0000 (UTC) Received: by mail-il1-f194.google.com with SMTP id l16so6244270ilj.9 for ; Thu, 15 Oct 2020 13:30:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/jxSiXUFHPKoVWvB4Kho7bLX6BXoNLesB/In+yGJN0M=; b=m6ii6kwgw2MTT+gIs1qNafQgE+1wC+HcGAAG5DVQ5N3c3MvWoIXwbtkLrgEcdSgU0l cSfpLzmsmliwsAlSTufVFgaFTuvLQUpxLV4emLR/kOzjLAQ5hmhKZOeJsXwwdxtXlOgS 0TkZmDN3hxDZfKMgysOzQzhim1wrGGbaPvEhOtFYO4Ty6Orh+Ze0lHxl7/XoSWBSs1HY +2vxlJbtwJUYtT2unuAe5so9kivgiAD0exdzlHNc9wcNnlv8K+3adk5y7C1N0sUz2yM3 Fgodn3vHy8t6uW/pyIjWMYNgGM11tmEJ2q4iTfDBaeS7izoo39dvGzZSqBJ4vlOjlLeQ 8/ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/jxSiXUFHPKoVWvB4Kho7bLX6BXoNLesB/In+yGJN0M=; b=thUr8618L/rT2UgIkq1/z7iB1xZfduOr0T2FTBeamXlez2ObMVxityKy9Xi1Iht1g+ nthoC8ZLKt1bDtsVbxSq0LYpKn5rmc8EPjL7yQ0rV7VY6GY6y5D7j6QXcZdnAmxPd8WO 777bmSstwdGW8vlZ7VCwXxx+IHDCW1b+lm4XUqWDCMaFQ05I+XTDwP+ya45vI0BqK+a2 77ZlX7qXECr3lrgtEYewqz/SY+W63fWJVAe102k8lf4YypInNuf23hcxrRmqPjGzxuJU NMCo5YiK6F05qYUpCdrHNXB0pYEjvQrVPTHryJ52cOAdKCFU/CNtkY4AKZzp4OMjJhv8 vGoQ== X-Gm-Message-State: AOAM532L4xdFChNmNzjn3gkI6RllJWLPyhss3Yq4ptXYcZrGVaOpdsqG zpiRtM1BK7+tB900YMBC//yU4TV9pw40IqsJWVbCTgpGBwH/tQ== X-Google-Smtp-Source: ABdhPJxrvvur8NSNW89vwNQf2R2zgjfbt7aEEQH/uFDV4MhjdyOqjUYvpc8A3zFlbMc353x3cPkxpQ8F04dofE3zYAQ= X-Received: by 2002:a92:874a:: with SMTP id d10mr274971ilm.163.1602793820977; Thu, 15 Oct 2020 13:30:20 -0700 (PDT) MIME-Version: 1.0 References: <20201012125323.17509-1-david@redhat.com> <20201012125323.17509-7-david@redhat.com> In-Reply-To: <20201012125323.17509-7-david@redhat.com> From: Pankaj Gupta Date: Thu, 15 Oct 2020 22:30:09 +0200 Message-ID: Subject: Re: [PATCH v1 06/29] virtio-mem: generalize virtio_mem_owned_mb() To: David Hildenbrand Cc: LKML , Linux MM , virtualization@lists.linux-foundation.org, Andrew Morton , "Michael S . Tsirkin" , Jason Wang Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Avoid using memory block ids. Rename it to virtio_mem_contains_range(). > > Cc: "Michael S. Tsirkin" > Cc: Jason Wang > Cc: Pankaj Gupta > Signed-off-by: David Hildenbrand > --- > drivers/virtio/virtio_mem.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c > index 6bbd1cfd10d3..821143db14fe 100644 > --- a/drivers/virtio/virtio_mem.c > +++ b/drivers/virtio/virtio_mem.c > @@ -500,12 +500,13 @@ static bool virtio_mem_overlaps_range(struct virtio_mem *vm, > } > > /* > - * Test if a virtio-mem device owns a memory block. Can be called from > + * Test if a virtio-mem device contains a given range. Can be called from > * (notifier) callbacks lockless. > */ > -static bool virtio_mem_owned_mb(struct virtio_mem *vm, unsigned long mb_id) > +static bool virtio_mem_contains_range(struct virtio_mem *vm, uint64_t start, > + uint64_t size) > { > - return mb_id >= vm->first_mb_id && mb_id <= vm->last_mb_id; > + return start >= vm->addr && start + size <= vm->addr + vm->region_size; > } > > static int virtio_mem_notify_going_online(struct virtio_mem *vm, > @@ -800,7 +801,7 @@ static void virtio_mem_online_page_cb(struct page *page, unsigned int order) > */ > rcu_read_lock(); > list_for_each_entry_rcu(vm, &virtio_mem_devices, next) { > - if (!virtio_mem_owned_mb(vm, mb_id)) > + if (!virtio_mem_contains_range(vm, addr, PFN_PHYS(1 << order))) > continue; > > sb_id = virtio_mem_phys_to_sb_id(vm, addr); Looks good. Reviewed-by: Pankaj Gupta