From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC919C43331 for ; Sun, 29 Mar 2020 15:41:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 412942073E for ; Sun, 29 Mar 2020 15:41:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JPSdiZiR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 412942073E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 951996B0010; Sun, 29 Mar 2020 11:41:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 901B76B0032; Sun, 29 Mar 2020 11:41:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F0F56B0036; Sun, 29 Mar 2020 11:41:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0156.hostedemail.com [216.40.44.156]) by kanga.kvack.org (Postfix) with ESMTP id 650006B0010 for ; Sun, 29 Mar 2020 11:41:27 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 35A22A8ED for ; Sun, 29 Mar 2020 15:41:27 +0000 (UTC) X-FDA: 76648814214.09.bird44_46dbc6e6e2852 X-HE-Tag: bird44_46dbc6e6e2852 X-Filterd-Recvd-Size: 5359 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Sun, 29 Mar 2020 15:41:26 +0000 (UTC) Received: by mail-wr1-f66.google.com with SMTP id p10so17938615wrt.6 for ; Sun, 29 Mar 2020 08:41:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=H2oEr4rtYq7eZA0dkqG0zoVVshpwZANdfGBsNxxUn38=; b=JPSdiZiRXV8x0YY6PaSnyNrrI6wCcO+UprNjXMSGLe8TVQ4nkWf/h87iB4mbM/FjpE MxFK1gGUdvWU5KJP/1Mha2Zou4bqyr97JtFerGq4nVfYqHCiLfIOVG+tLoXnY3liG9I0 FkYONcVcPMW/VR0ZKoctrzPnPyWm1J2ehqZVlRxAh9qMbvu3pjhRJwsE3YKYBAV7nT8N vq2qEzYBDi1hj9OlewSTxqyKZj7IIyK2PJ1mUPvulP0fk+bYllI027qYpAD1nTqZUbfY ORSpuzeIBoZ5nIc5WAvSufxtJum0k0WARTpEn5jUl0oaR5cxt8X+IJcLgiWnhbj/9JPZ eXwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=H2oEr4rtYq7eZA0dkqG0zoVVshpwZANdfGBsNxxUn38=; b=LIV+7wjjk8zWz5OGiWva6Q7wH+K1NS3OSGf4w7lBasSOoNMfokAcwnDmi8MmG7TUOv yBavlpVuKojAyLmap2comoPqdks3iP5zFp9Ib4k17wDv2C/TDkblbAcJzaH5VoCrfXMG T69uAYmMq5RK5vR253SR2g1EhMkrjBYFa1hpJyGPPpj3KmuDR4AOdvBZbUBBBcsuWZRc WBq1WmPPwI2jHt3QlIPQdkOqriLaWuES4oqJrSzv8NF4Tr5qTkKwq45uNrdbBqKQLx7T 0O1FkWvvRq33Ci5UjhY+xIxHT6Q327x5bXd/5xY8QZGyQQU0YgRcr1RKMnGVTib4MeS6 zUBA== X-Gm-Message-State: ANhLgQ2CwV2MkyLf2YzmGMRnqMjQnthyK1xndLjU3R9pqIQYXv32B42k qyMj9CladyD6WQbBP+MaWRJIS94UklRSUg/4XmQ= X-Google-Smtp-Source: ADFU+vsV8jzRWuHYOAA089AR+shUjNO4rmsDCQRnKzdjlt6pysT09Bdt7QBzKnRQjbk2BQWoJRrPJ8I6vTTCRwZehdk= X-Received: by 2002:a5d:674f:: with SMTP id l15mr10083350wrw.196.1585496485499; Sun, 29 Mar 2020 08:41:25 -0700 (PDT) MIME-Version: 1.0 References: <20200311171422.10484-1-david@redhat.com> <6858c4d8-7570-2c2b-5d53-1a7f994c14ee@redhat.com> In-Reply-To: <6858c4d8-7570-2c2b-5d53-1a7f994c14ee@redhat.com> From: Pankaj Gupta Date: Sun, 29 Mar 2020 17:41:14 +0200 Message-ID: Subject: Re: [PATCH v2 00/10] virtio-mem: paravirtualized memory To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtio-dev@lists.oasis-open.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, Michal Hocko , Andrew Morton , "Michael S . Tsirkin" , Sebastien Boeuf , Samuel Ortiz , Robert Bradford , Luiz Capitulino , teawater , Igor Mammedov , "Dr . David Alan Gilbert" , Alexander Duyck , Alexander Potapenko , Anshuman Khandual , Anthony Yznaga , Dan Williams , Dave Young , Jason Wang , Johannes Weiner , Juergen Gross , Konrad Rzeszutek Wilk , Len Brown , Mel Gorman , Michal Hocko , Mike Rapoport , Oscar Salvador , Oscar Salvador , Pavel Tatashin , Pavel Tatashin , Pingfan Liu , Qian Cai , "Rafael J. Wysocki" , "Rafael J. Wysocki" , Stefan Hajnoczi , Vlastimil Babka , Wei Yang Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > Hi David, > > > > Trying to test the series with the Qemu branch(virtio-mem) mentioned. > > Unfortunately, > > not able to hotplug memory. Is anything changed from your previous posting > > or I am doing something wrong? > > > > After giving value to "requested-size", I see size as zero. > > > > (qemu) qom-set vm0 requested-size 10G > > (qemu) info memory-devices > > Memory device [virtio-mem]: "vm0" > > memaddr: 0x240000000 > > node: 0 > > requested-size: 10737418240 > > size: 0 > > max-size: 107374182400 > > block-size: 2097152 > > memdev: /objects/mem0 > > > > Guest kernel: 5.6.0-rc4 > > Using same Qemu commandline arguments mentioned in cover-letter. > > Are you booting from an initrd? Are you compiling virtio-mem as a kernel > module or into the kernel binary? Ah was booting into wrong kernel version. Sorry! for the noise. Working perfectly for me. Tried various cmbinations for both hotplug/unplug with multiple NUMA nodes and verified result in guest. For the series, you can add: Tested-by: Pankaj Gupta > > -- > Thanks, > > David / dhildenb >