From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17C6EC4363A for ; Thu, 29 Oct 2020 16:33:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3D25F20790 for ; Thu, 29 Oct 2020 16:33:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bytedance-com.20150623.gappssmtp.com header.i=@bytedance-com.20150623.gappssmtp.com header.b="f6D+/uNP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D25F20790 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AA0236B006E; Thu, 29 Oct 2020 12:33:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A50B46B0070; Thu, 29 Oct 2020 12:33:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93D8A6B0071; Thu, 29 Oct 2020 12:33:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0248.hostedemail.com [216.40.44.248]) by kanga.kvack.org (Postfix) with ESMTP id 662806B006E for ; Thu, 29 Oct 2020 12:33:06 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id F17CC181AEF07 for ; Thu, 29 Oct 2020 16:33:05 +0000 (UTC) X-FDA: 77425507530.02.thing36_470f3c52728e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id CC10110097AA2 for ; Thu, 29 Oct 2020 16:33:05 +0000 (UTC) X-HE-Tag: thing36_470f3c52728e X-Filterd-Recvd-Size: 4387 Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Thu, 29 Oct 2020 16:33:04 +0000 (UTC) Received: by mail-pg1-f196.google.com with SMTP id f38so2801697pgm.2 for ; Thu, 29 Oct 2020 09:33:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CNp60uz7U6o1WyBX9AAMogQVRcPxcfAiqCLR+bSZ8wY=; b=f6D+/uNPO6HW47eS+XdsuzOWR1OMKIbf1tDWGNa/eHlbdNS1fFyq73++vFXANcz6x2 ytHLCE17oAxpQhTZeiOQrmqhH4JsQDnMKEzIq5jZmBroArNr7f6GsZp52FWH2KkhY3sM H8KsLn2uIX0lXXKFtXSbrA4roiZkm9N/rx+aLZ7Z/aAg0vhgc/QNYZtvX+naxEa054tr J0G6xItBIlWQ5zhq1bPzfF1wq31Xu/yYiQL3OtYyEzqwyevlKs28VqyQLH4Vw4YcJ7ti 8EQJyl5qnkFrglTZQ6jMXOEWKksSQAolyC8ztjX4eIQqPqjYVEB+NEeUU6DztL2Vnx9B 0Pjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CNp60uz7U6o1WyBX9AAMogQVRcPxcfAiqCLR+bSZ8wY=; b=hqGWiA0F6GmdMB35BM71W7kEUtluMs8FjkYc8E0D8/HQsB5zXg4ZM/kWLhCtmmoCNb r4GWqRTceSV1FTPQTiej+BFQMOo8697UHkLbsG8d3tNA/G9AWaSUNorouqzHjNZmcxIS 3fBXo6cJbPppZ+G6L81/ro4RoOuNNpWQP0LuV6Ts9POi+iuLeZ7KJcCvsB/NAQinPzEX WJzSj4jnX8nHC+6nHkDwcqrOHy/sty2S5O5Diy3nMKWR5WDN8IHL4OsxiA7ckePZa2+T vS35mlaN5JdgDeghjvGHLCwpLwSnW7dMsqOo4+7el1uPvGwYKGslFYFyEhYhzVVKvcNV wYyQ== X-Gm-Message-State: AOAM532CvslwNQzmF85ggeLAyxRaqDBaFGKmfRRAMvhPDpmnLMzbcij1 o7u+OzhDuxuZJNx9OgGNowIumzo12SThNCt7hLnWfg== X-Google-Smtp-Source: ABdhPJy1+WefzaCmcrBy2LFwrFD2Wq5MJeAwQJ74F2m6AHO5xCmR0PebTW6H1Op74Lq4+jARizRrOxwrObc2Oo0XhDY= X-Received: by 2002:a17:90b:198d:: with SMTP id mv13mr599421pjb.13.1603989183738; Thu, 29 Oct 2020 09:33:03 -0700 (PDT) MIME-Version: 1.0 References: <20201028035013.99711-1-songmuchun@bytedance.com> In-Reply-To: From: Muchun Song Date: Fri, 30 Oct 2020 00:32:26 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v2] mm: memcg/slab: Fix return child memcg objcg for root memcg To: Shakeel Butt Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Roman Gushchin , Joonsoo Kim , Yafang Shao , Chris Down , Christian Brauner , "Peter Zijlstra (Intel)" , Ingo Molnar , Kees Cook , Thomas Gleixner , esyr@redhat.com, Suren Baghdasaryan , areber@redhat.com, Marco Elver , LKML , Cgroups , Linux MM Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 30, 2020 at 12:18 AM Shakeel Butt wrote: > > On Thu, Oct 29, 2020 at 9:09 AM Muchun Song wrote: > > > > On Thu, Oct 29, 2020 at 11:48 PM Shakeel Butt wrote: > > > > > > On Tue, Oct 27, 2020 at 8:50 PM Muchun Song wrote: > > > > > > > > Consider the following memcg hierarchy. > > > > > > > > root > > > > / \ > > > > A B > > > > > > > > If we get the objcg of memcg A failed, > > > > > > Please fix the above statement. > > > > Sorry, could you be more specific, I don't quite understand. > > Fix the grammar. Something like "If we failed to get the reference on > objcg of memcg A..." Got it. Sorry for my poor English, Thanks. -- Yours, Muchun