From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F52BC433FE for ; Sat, 5 Dec 2020 16:53:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1333B22C7D for ; Sat, 5 Dec 2020 16:53:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1333B22C7D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1A4A16B005C; Sat, 5 Dec 2020 11:53:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1556F6B005D; Sat, 5 Dec 2020 11:53:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 06B666B0068; Sat, 5 Dec 2020 11:53:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0133.hostedemail.com [216.40.44.133]) by kanga.kvack.org (Postfix) with ESMTP id E5E0A6B005C for ; Sat, 5 Dec 2020 11:53:12 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id A6F4F1EE6 for ; Sat, 5 Dec 2020 16:53:12 +0000 (UTC) X-FDA: 77559823824.07.base16_1903393273ce Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id 89F131803F9A5 for ; Sat, 5 Dec 2020 16:53:12 +0000 (UTC) X-HE-Tag: base16_1903393273ce X-Filterd-Recvd-Size: 6812 Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Sat, 5 Dec 2020 16:53:11 +0000 (UTC) Received: by mail-pg1-f195.google.com with SMTP id f17so5540665pge.6 for ; Sat, 05 Dec 2020 08:53:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4TjBWxHeiYLGN2gLQ9wB5wlqIelnuKaJ3NWlRad2iWo=; b=lHercq+HFs9Uw4tBCUBPVfm4XBHEjObQ2+zuVWYecpGDyqFLGynsD/AS+5i0AyeHq/ K6ze34AxmCpza061G3nwgZIiUh0OmEOpNFMg+6zIIGochjQhJZMMclJbcnWaQjNFl4jH FHmt9G4qXYxRcmaDVviFYXWC40swpwKncRblXHFOMLT/bPiCU6AjbLED5NF2oKlJJBoV jkVuZmlzv7QfSJNzrIohVAVf6pxyKeWq6LyIcowmbgYTxrkUjlB7EThoh9ahUzcwn5um OgPX+0xIn0N6nmIBXwGoSm3purEI2y21/BPelFRc0s9F5r0ZH9z63jHb+Tu4eBj/mOre eBJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4TjBWxHeiYLGN2gLQ9wB5wlqIelnuKaJ3NWlRad2iWo=; b=ZMGJChIeKmbpL2guvQqsNZ7iZh31bkWI5nWZcP+drVpINWB83lya+R5YR9iQjqbdvj qvOhZ+7lyint9Oxm9TB2FmFsxkzc9dxCMTTo3FhFTXQ3+3MUG61pUas9GTCXprEQcg/n 9IhCayOTUeGfdAPbNd+y3ZlG4TviDCX+VqvyHuZCwtdAmkJnufPa3yCm0NdF6FipcOvW O2zn6pzKfesKQodDzRtivVRIbv2aDWUD5UR5owxo/u2t/hGmsHRAUleJ1cYkTx4FVhzw RF6c89a1efRGI8l8eZ6KXuBdQboFoz8giwcPWn/4pqhz2dKXYwcYLGbsDbaOeBCMFu7G u1fg== X-Gm-Message-State: AOAM533tH9Hi/OxKcU6iVU97lstmbxci9UMi15DeP55No85n7pNHW+uq I2SIvR/Zj5zMnEaWKsYJ/pKw3VV/RrD2LIXhUBCx7w== X-Google-Smtp-Source: ABdhPJzev4SOyNkd0pIPjnjQ1qaDF4+LzMeAeeaiv9OetFzM0zk1Ry1aFRwDmwtFpgLA7fSbZT5Ksai4SYr2hR54uZU= X-Received: by 2002:a63:c15:: with SMTP id b21mr12035007pgl.341.1607187190737; Sat, 05 Dec 2020 08:53:10 -0800 (PST) MIME-Version: 1.0 References: <20201205130224.81607-1-songmuchun@bytedance.com> <20201205130224.81607-6-songmuchun@bytedance.com> In-Reply-To: From: Muchun Song Date: Sun, 6 Dec 2020 00:52:34 +0800 Message-ID: Subject: Re: [External] Re: [PATCH 5/9] mm: memcontrol: convert NR_FILE_THPS account to pages To: Greg KH Cc: rafael@kernel.org, Alexey Dobriyan , Andrew Morton , Johannes Weiner , Michal Hocko , Vladimir Davydov , Hugh Dickins , Will Deacon , Roman Gushchin , Mike Rapoport , Thomas Gleixner , esyr@redhat.com, peterx@redhat.com, krisman@collabora.com, Suren Baghdasaryan , avagin@openvz.org, Marco Elver , Randy Dunlap , Joonsoo Kim , LKML , linux-fsdevel , Linux Memory Management List , Cgroups Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Dec 6, 2020 at 12:32 AM Greg KH wrote: > > On Sat, Dec 05, 2020 at 11:39:24PM +0800, Muchun Song wrote: > > On Sat, Dec 5, 2020 at 11:32 PM Greg KH wrote: > > > > > > On Sat, Dec 05, 2020 at 11:29:26PM +0800, Muchun Song wrote: > > > > On Sat, Dec 5, 2020 at 10:09 PM Greg KH wrote: > > > > > > > > > > On Sat, Dec 05, 2020 at 09:02:20PM +0800, Muchun Song wrote: > > > > > > Converrt NR_FILE_THPS account to pages. > > > > > > > > > > > > Signed-off-by: Muchun Song > > > > > > --- > > > > > > drivers/base/node.c | 3 +-- > > > > > > fs/proc/meminfo.c | 2 +- > > > > > > mm/filemap.c | 2 +- > > > > > > mm/huge_memory.c | 3 ++- > > > > > > mm/khugepaged.c | 2 +- > > > > > > mm/memcontrol.c | 5 ++--- > > > > > > 6 files changed, 8 insertions(+), 9 deletions(-) > > > > > > > > > > > > diff --git a/drivers/base/node.c b/drivers/base/node.c > > > > > > index 05c369e93e16..f6a9521bbcf8 100644 > > > > > > --- a/drivers/base/node.c > > > > > > +++ b/drivers/base/node.c > > > > > > @@ -466,8 +466,7 @@ static ssize_t node_read_meminfo(struct device *dev, > > > > > > HPAGE_PMD_NR), > > > > > > nid, K(node_page_state(pgdat, NR_SHMEM_PMDMAPPED) * > > > > > > HPAGE_PMD_NR), > > > > > > - nid, K(node_page_state(pgdat, NR_FILE_THPS) * > > > > > > - HPAGE_PMD_NR), > > > > > > + nid, K(node_page_state(pgdat, NR_FILE_THPS)), > > > > > > > > > > Again, is this changing a user-visable value? > > > > > > > > > > > > > Of course not. > > > > > > > > In the previous, the NR_FILE_THPS account is like below: > > > > > > > > __mod_lruvec_page_state(page, NR_FILE_THPS, 1); > > > > > > > > With this patch, it is: > > > > > > > > __mod_lruvec_page_state(page, NR_FILE_THPS, HPAGE_PMD_NR); > > > > > > > > So the result is not changed from the view of user space. > > > > > > So you "broke" it on the previous patch and "fixed" it on this one? Why > > > not just do it all in one patch? > > > > Sorry for the confusion. I mean that the "previous" is without all of this patch > > series. So this series is aimed to convert the unit of all different THP vmstat > > counters from HPAGE_PMD_NR to pages. Thanks. > > I'm sorry, I still do not understand. It looks to me that you are > changing the number printed to userspace here. Where is the > corrisponding change that changed the units for this function? Is it in > this patch? If so, sorry, I did not see that at all... Sorry, actually, this patch does not change the number printed to userspace. It only changes the unit of the vmstat counter. Without this patch, every counter of NR_FILE_THPS represents NR_FILE_THPS pages. However, with this patch, every counter represents only one page. And why do I want to do this? Can reference to the cover letter. Thanks very much. > > thanks, > > greg k-h -- Yours, Muchun