From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65385C433DB for ; Mon, 15 Feb 2021 11:52:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B2C0464DFD for ; Mon, 15 Feb 2021 11:52:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B2C0464DFD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 272798D00F1; Mon, 15 Feb 2021 06:52:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 224698D00E6; Mon, 15 Feb 2021 06:52:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C5CD8D00F1; Mon, 15 Feb 2021 06:52:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0053.hostedemail.com [216.40.44.53]) by kanga.kvack.org (Postfix) with ESMTP id E37758D00E6 for ; Mon, 15 Feb 2021 06:52:06 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id AF7B962F4 for ; Mon, 15 Feb 2021 11:52:06 +0000 (UTC) X-FDA: 77820338652.02.shoe30_0613fc12763a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id 9602A10097AA1 for ; Mon, 15 Feb 2021 11:52:06 +0000 (UTC) X-HE-Tag: shoe30_0613fc12763a X-Filterd-Recvd-Size: 7271 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Mon, 15 Feb 2021 11:52:06 +0000 (UTC) Received: by mail-pj1-f54.google.com with SMTP id l18so3771341pji.3 for ; Mon, 15 Feb 2021 03:52:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ELXsaA6h2gd3/2XQSUpZtIfYlq6fHEtAZT6xqmaOGS4=; b=Dh6h6aUxZyxT9mZOEFDApEmhokQpI3yJ+/bpvDReNio8+/wY/9QxWqG2Rf9jWS+LBm WEgYVe5iGG4CVZzCxLPhdAS2BB5wSLWkyhr+/+2yug9QKh0mNDnRJH8PXryXuxT5yhhe Yj/0vEXgC8cr/5h8zU+Lsup3t3R4Fxsg3+YGw7xQ+ko1nfmnuI3cWS/49c2KMuCvRFRF 6bwOlDCyKKfQTv8wv6j2JZ8F869L2CkSbhG8m+pkbgy+a0Dj9mojgJ+FM593mk7ohaWP fGZOs7zgayE35XhJfH/Jyd4dgSMze+hzpttwNy1vXWLWm2vXB97Ydssjj6YmLk+Ic3/F NUyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ELXsaA6h2gd3/2XQSUpZtIfYlq6fHEtAZT6xqmaOGS4=; b=neBUEbzSZZsNeQgyaGq9EJxB7sei69NMqqwIWM8Tasj8RYx1FxAASBRv7J6jT2dxM4 BV4aT8W1jZ/FM4vrvD5r2JBL4P6PvgoHfc4ks5oheBSE/MCtCiI3YVMagvK2ue+LW6Lu vXRO0Pw+z1PPXl0x4QHO01PP31vW6D6Lpc4ii1+V4PhVzJOyPbMHCQfv9j0iJLtedq5v LeITd4/dvjPTeIiT8qfrE/bA8CWPwyUIEKoapDo2PLc679lGxmuebEo7lP0ke8m9V4Li 2UP+Cl0V2xyQPwe0Dne8c4WKLG55oaK8CvolCzA8pEgaxyvnVCu4GjmhgWqUJiB5ARvV DQWg== X-Gm-Message-State: AOAM533NYO+VNAlqYqkRwhojxMMa1JXOWVw5aZAJk/DbsT8uDt9xeAii W6iTz5DQdtmM9D/TR12TkpfA3/gKxc0saJ9wFOH9Qg== X-Google-Smtp-Source: ABdhPJzKyCtml9leEi1lmizMczQoWM9KaThCAeZnS9YTLYJ5Ia67P/pubrmRAW/pcM7dVvToP5VuRY7YIJH81Qa7d2I= X-Received: by 2002:a17:90b:1096:: with SMTP id gj22mr15623262pjb.229.1613389923470; Mon, 15 Feb 2021 03:52:03 -0800 (PST) MIME-Version: 1.0 References: <20210208085013.89436-1-songmuchun@bytedance.com> <20210208085013.89436-5-songmuchun@bytedance.com> In-Reply-To: From: Muchun Song Date: Mon, 15 Feb 2021 19:51:26 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v15 4/8] mm: hugetlb: alloc the vmemmap pages associated with each HugeTLB page To: Michal Hocko Cc: Jonathan Corbet , Mike Kravetz , Thomas Gleixner , mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, Peter Zijlstra , viro@zeniv.linux.org.uk, Andrew Morton , paulmck@kernel.org, mchehab+huawei@kernel.org, pawan.kumar.gupta@linux.intel.com, Randy Dunlap , oneukum@suse.com, anshuman.khandual@arm.com, jroedel@suse.de, Mina Almasry , David Rientjes , Matthew Wilcox , Oscar Salvador , "Song Bao Hua (Barry Song)" , David Hildenbrand , =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= , Joao Martins , Xiongchun duan , linux-doc@vger.kernel.org, LKML , Linux Memory Management List , linux-fsdevel Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 15, 2021 at 6:33 PM Michal Hocko wrote: > > On Mon 15-02-21 18:05:06, Muchun Song wrote: > > On Fri, Feb 12, 2021 at 11:32 PM Michal Hocko wrote: > [...] > > > > +int alloc_huge_page_vmemmap(struct hstate *h, struct page *head) > > > > +{ > > > > + int ret; > > > > + unsigned long vmemmap_addr = (unsigned long)head; > > > > + unsigned long vmemmap_end, vmemmap_reuse; > > > > + > > > > + if (!free_vmemmap_pages_per_hpage(h)) > > > > + return 0; > > > > + > > > > + vmemmap_addr += RESERVE_VMEMMAP_SIZE; > > > > + vmemmap_end = vmemmap_addr + free_vmemmap_pages_size_per_hpage(h); > > > > + vmemmap_reuse = vmemmap_addr - PAGE_SIZE; > > > > + > > > > + /* > > > > + * The pages which the vmemmap virtual address range [@vmemmap_addr, > > > > + * @vmemmap_end) are mapped to are freed to the buddy allocator, and > > > > + * the range is mapped to the page which @vmemmap_reuse is mapped to. > > > > + * When a HugeTLB page is freed to the buddy allocator, previously > > > > + * discarded vmemmap pages must be allocated and remapping. > > > > + */ > > > > + ret = vmemmap_remap_alloc(vmemmap_addr, vmemmap_end, vmemmap_reuse, > > > > + GFP_ATOMIC | __GFP_NOWARN | __GFP_THISNODE); > > > > > > I do not think that this is a good allocation mode. GFP_ATOMIC is a non > > > sleeping allocation and a medium memory pressure might cause it to > > > fail prematurely. I do not think this is really an atomic context which > > > couldn't afford memory reclaim. I also do not think we want to grant > > > > Because alloc_huge_page_vmemmap is called under hugetlb_lock > > now. So using GFP_ATOMIC indeed makes the code more simpler. > > You can have a preallocated list of pages prior taking the lock. A discussion about this can refer to here: https://patchwork.kernel.org/project/linux-mm/patch/20210117151053.24600-5-songmuchun@bytedance.com/ > Moreover do we want to manipulate vmemmaps from under spinlock in > general. I have to say I have missed that detail when reviewing. Need to > think more. > > > From the document of the kernel, I learned that __GFP_NOMEMALLOC > > can be used to explicitly forbid access to emergency reserves. So if > > we do not want to use the reserve memory. How about replacing it to > > > > GFP_ATOMIC | __GFP_NOMEMALLOC | __GFP_NOWARN | __GFP_THISNODE > > The whole point of GFP_ATOMIC is to grant access to memory reserves so > the above is quite dubious. If you do not want access to memory reserves Look at the code of gfp_to_alloc_flags(). static inline unsigned int gfp_to_alloc_flags(gfp_t gfp_mask) { [...] if (gfp_mask & __GFP_ATOMIC) { /* * Not worth trying to allocate harder for __GFP_NOMEMALLOC even * if it can't schedule. */ if (!(gfp_mask & __GFP_NOMEMALLOC)) alloc_flags |= ALLOC_HARDER; [...] } Seems to allow this operation (GFP_ATOMIC | __GFP_NOMEMALLOC). > then use GFP_NOWAIT instead. But failures are much more easier to happen > then. > > NOMEMALLOC is meant to be used from paths which are allowed to consume > memory reserves - e.g. when invoked from the memory reclaim path. > -- > Michal Hocko > SUSE Labs