From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECCB1C2B9F7 for ; Wed, 26 May 2021 03:20:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 698CB6117A for ; Wed, 26 May 2021 03:20:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 698CB6117A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DD2FC6B0081; Tue, 25 May 2021 23:19:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D82286B0083; Tue, 25 May 2021 23:19:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BFC1A6B0085; Tue, 25 May 2021 23:19:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0160.hostedemail.com [216.40.44.160]) by kanga.kvack.org (Postfix) with ESMTP id 900226B0081 for ; Tue, 25 May 2021 23:19:59 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 22A498249980 for ; Wed, 26 May 2021 03:19:59 +0000 (UTC) X-FDA: 78181928118.28.D3705AF Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf23.hostedemail.com (Postfix) with ESMTP id DBEA5A0001C8 for ; Wed, 26 May 2021 03:19:51 +0000 (UTC) Received: by mail-pl1-f171.google.com with SMTP id s4so15860306plg.12 for ; Tue, 25 May 2021 20:19:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=N+H2pDGWEKuBFdY6ChyAya4zIt6sBYmEXl2erhR5ofE=; b=OriOIyeg9pc73YkFlgtCpnpDR7K9qibVy6dqFv/Vj3uXtxskI6DVzaCd1FWiVlowTe UBKPd+zsAp+lDJZTqjLN9UbwuuPZouwv/UAjstcAw+Z4nYNP67hVfiJI/lSPpL5PaspH nlk9rOVBCOqFIGEDM0g1af4n2WRqqgW3gu6RmmSI5BuKkjjfIzyJ4/sTnHjarvggzLZQ rrLJERs7sWzJdeCEHXVQ9l0MRc+FpSBLq3Ukr4QHyJRVwrCllWjXuK9uAZO7pfBvhp5i QNsinnl0EltmRgJ+EqJVypm+d8xjpd7NWu3lhIw6exfFbdpmj/W8COYkoYEWcRSZZ1tk aGMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=N+H2pDGWEKuBFdY6ChyAya4zIt6sBYmEXl2erhR5ofE=; b=bMHpJP8RDd9kEvIF3x8S8j15PTCOpysRlyYw6nFBPdnl4S+qnHoWDT8UyB6emvG7/o WjvByPgpiLFEc8RR/3BAv24kDmrTNT6wqgER487xMTlpyyPNBBcw2FIoVy2XGaR6pGX3 OdxnvBdUdsx4N6f2cZqEOc+gnmSfj1v0ZuG0oGpJbILUiz5RPiE60KFGD8URiA+znXu9 v6bvt9AUa7SlcWgmqt8jNhZKeRMh1ACn++7ktx3yNj+9pYqZ4O2C68qOhfIHnJxbcfag vsDPwkE+dyVlVOExT+Kd1P4t11wa65sdqYgQetReuaEs7DQv8SGcAC+cuXi4Rl44VKr8 ye9Q== X-Gm-Message-State: AOAM531Ezlv3zEFcDyFvqfqMJIFV9MLjXzLtXi0Gw9qMtVhgAQBpsDLn GgnrIjN4fpGmuQeHsbZcTJa9eMcJuSSZUZY+7DKSMw== X-Google-Smtp-Source: ABdhPJxNMYe56WEowG8StlDp6sujKEGUeTaH+nLVbzQzcuXRJaJG8lkhaP3gvNuM7Em3+UQD9kpBuDzNGNmvuUhKsZA= X-Received: by 2002:a17:90a:bd05:: with SMTP id y5mr33612908pjr.229.1621999196385; Tue, 25 May 2021 20:19:56 -0700 (PDT) MIME-Version: 1.0 References: <78359cf0-6e28-2aaa-d17e-6519b117b3db@oracle.com> <20210525233134.246444-1-mike.kravetz@oracle.com> In-Reply-To: <20210525233134.246444-1-mike.kravetz@oracle.com> From: Muchun Song Date: Wed, 26 May 2021 11:19:20 +0800 Message-ID: Subject: Re: [External] [PATCH 0/2] Track reserve map changes to restore on error To: Mike Kravetz Cc: Mina Almasry , Linux-MM , open list , Axel Rasmussen , Peter Xu , Andrew Morton Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=OriOIyeg; spf=pass (imf23.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: DBEA5A0001C8 X-Stat-Signature: ghq4815a5caypfaw1qn9z33gcwtygxeh X-HE-Tag: 1621999191-73610 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 26, 2021 at 7:31 AM Mike Kravetz wrote: > > Here is a modification to the reservation tracking for fixup on errors. > It is a more general change, but should work for the hugetlb_mcopy_pte_atomic > case as well. > > Perhaps use this as a prerequisite for your fix(es)? Pretty sure this > will eliminate the need for the call to hugetlb_unreserve_pages. Hi Mike, It seems like someone is fixing a bug, right? Maybe a link should be placed in the cover letter so that someone can know what issue we are facing. Thanks. > > Mike Kravetz (2): > hugetlb: rename HPageRestoreReserve flag to HPageRestoreRsvCnt > hugetlb: add new hugetlb specific flag HPG_restore_rsv_map > > fs/hugetlbfs/inode.c | 3 +- > include/linux/hugetlb.h | 17 +++++-- > mm/hugetlb.c | 108 ++++++++++++++++++++++++++++------------ > mm/userfaultfd.c | 14 +++--- > 4 files changed, 99 insertions(+), 43 deletions(-) > > -- > 2.31.1 >