From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEF0AC433E4 for ; Tue, 28 Jul 2020 13:04:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 81423206D8 for ; Tue, 28 Jul 2020 13:04:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bytedance-com.20150623.gappssmtp.com header.i=@bytedance-com.20150623.gappssmtp.com header.b="fuVbdu4k" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 81423206D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DCC3C8D0011; Tue, 28 Jul 2020 09:04:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D7C4A8D0003; Tue, 28 Jul 2020 09:04:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6C498D0011; Tue, 28 Jul 2020 09:04:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0177.hostedemail.com [216.40.44.177]) by kanga.kvack.org (Postfix) with ESMTP id B1EDB8D0003 for ; Tue, 28 Jul 2020 09:04:19 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 660531EF1 for ; Tue, 28 Jul 2020 13:04:19 +0000 (UTC) X-FDA: 77087503038.26.nerve04_4902f3b26f6a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id 7B6C81804A31F for ; Tue, 28 Jul 2020 13:04:09 +0000 (UTC) X-HE-Tag: nerve04_4902f3b26f6a X-Filterd-Recvd-Size: 8959 Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Tue, 28 Jul 2020 13:03:50 +0000 (UTC) Received: by mail-pf1-f196.google.com with SMTP id z188so3080768pfc.6 for ; Tue, 28 Jul 2020 06:03:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=LlxNk1zIi8yGHdhZuUAKBshbG8msBSfKJxj73MCTTLY=; b=fuVbdu4kg8Y99dAbxJpvJBuhav/4G0H89oQkPKu/UwNUVa4/ENuFAawGrvnbJFgoBt b6c+/PdHdm+0fvfYLSNGfWwutyT8zJ00cYHAaOS6f9zTafyFXhSpDOlRg7QaVDBaxrDo TzhYbLtsg4hf97K1fgAhkWfDPZmffE/6AGln3ZeHZU372/2HZl7YG4qqjRmhnkxiVeX8 kbqg+AAQnrsAw3LqjOtGcWjoadgMoWDoBHty5NSeyzn4HWaFAoR5Hzrn3wuFVoxhwOyQ 9CBgCvBr131KH9KAuci0tTV/fM03zcREGkuUISWapCiTryHcr5GWvASIH8JbIEz3hDV/ OCZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=LlxNk1zIi8yGHdhZuUAKBshbG8msBSfKJxj73MCTTLY=; b=PV84fYcRjwnuLGvkrz9h9RD5swygYKQV603agl6532WRzIEmtwYmNEGflfUCvre03/ atagkBFrQkR6l4TrWR/c7dDmrMuvKYmSL9BxUjJRKO1spc3fNUdot3qMxhhz+PAddNka 4fInUdpjcQ/PSC+NqLfO4YrgfO8kTBFHwCSxpHJ4LZgm3n0q7uvU0kGxESO5V+ydZ5tJ KcW4+Xef0nEif5zXITDKKvyJ8977Pb3BLFTlbkN+cj2LC9znHHoiaJ3rZS9apZI/MJEH FNnzBAMAZj46l6RVK69B4Xs3A73sDpi+4ooZ8KZWePpf3NGZ86DHZ+SBORfbkdCHIOAQ spnA== X-Gm-Message-State: AOAM532BibJr6c9bN26xIyU+N1EBWviVpx36Lax4QKH3+WCZUHUGdQq0 kY+JhxIJDUamHqzDx/Xj/YnKDed0iaE8/3fiQVlD3w== X-Google-Smtp-Source: ABdhPJxXOos+AHvLu5t5Nmre7lPk3d4zzmjsRfGAu0xPh4r4M1Eyh6Y94iVlrv2joUOb/+jXZjClcy6GDG72xjzZbIg= X-Received: by 2002:a63:7e52:: with SMTP id o18mr1089996pgn.273.1595941427207; Tue, 28 Jul 2020 06:03:47 -0700 (PDT) MIME-Version: 1.0 References: <20200727134914.312934924@linuxfoundation.org> In-Reply-To: From: Muchun Song Date: Tue, 28 Jul 2020 21:03:11 +0800 Message-ID: Subject: Re: [External] Re: [PATCH 4.19 00/86] 4.19.135-rc1 review To: Naresh Kamboju Cc: Greg Kroah-Hartman , open list , Linus Torvalds , Andrew Morton , Guenter Roeck , Shuah Khan , patches@kernelci.org, Ben Hutchings , linux- stable , Hugh Dickins , Christoph Lameter , Roman Gushchin , Joonsoo Kim , linux-mm , mm-commits@vger.kernel.org, Pekka Enberg , David Rientjes , Shakeel Butt , Vlastimil Babka , Arnd Bergmann , lkft-triage@lists.linaro.org, clang-built-linux@googlegroups.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 7B6C81804A31F X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Thanks for your test. I have reviewed the patch: [PATCH 4.19 76/86] mm: memcg/slab: fix memory leak at non-root kmem_cache destroy There is a backport problem and I have pointed out the problem in that emai= l. On Tue, Jul 28, 2020 at 4:34 PM Naresh Kamboju wrote: > > On Mon, 27 Jul 2020 at 19:40, Greg Kroah-Hartman > wrote: > > > > This is the start of the stable review cycle for the 4.19.135 release. > > There are 86 patches in this series, all will be posted as a response > > to this one. If anyone has any issues with these being applied, please > > let me know. > > > > Responses should be made by Wed, 29 Jul 2020 13:48:51 +0000. > > Anything received after that time might be too late. > > > > The whole patch series can be found in one patch at: > > https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patc= h-4.19.135-rc1.gz > > or in the git tree and branch at: > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stab= le-rc.git linux-4.19.y > > and the diffstat can be found below. > > > > thanks, > > > > greg k-h > > > > ------------- > > Pseudo-Shortlog of commits: > > > Results from Linaro=E2=80=99s test farm. > Regressions detected on x86_64. > > Boot failures on x86_64 devices running 4.19.135-rc1 kernel. > > Summary > ------------------------------------------------------------------------ > > kernel: 4.19.135-rc1 > git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-st= able-rc.git > git branch: linux-4.19.y > git commit: e11702667f84474535b156dbb194deffa0a6cdb4 > git describe: v4.19.134-87-ge11702667f84 > Test details: https://qa-reports.linaro.org/lkft/linux-stable-rc-4.19-oe/= build/v4.19.134-87-ge11702667f84 > > > Muchun Song > > mm: memcg/slab: fix memory leak at non-root kmem_cache destroy > > [ 2.510884] =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > [ 2.510884] WARNING: possible recursive locking detected > [ 2.510884] 4.19.135-rc1 #1 Not tainted > [ 2.510884] -------------------------------------------- > [ 2.510884] swapper/0/1 is trying to acquire lock: > [ 2.510884] 0000000088703397 (slab_mutex){+.+.}, at: > kmem_cache_destroy+0x9a/0x2b0 > [ 2.510884] > [ 2.510884] but task is already holding lock: > [ 2.510884] 0000000088703397 (slab_mutex){+.+.}, at: > kmem_cache_destroy+0x45/0x2b0 > [ 2.510884] > [ 2.510884] other info that might help us debug this: > [ 2.510884] Possible unsafe locking scenario: > [ 2.510884] > [ 2.510884] CPU0 > [ 2.510884] ---- > [ 2.510884] lock(slab_mutex); > [ 2.510884] lock(slab_mutex); > [ 2.510884] > [ 2.510884] *** DEADLOCK *** > [ 2.510884] > [ 2.510884] May be due to missing lock nesting notation > [ 2.510884] > [ 2.510884] 3 locks held by swapper/0/1: > [ 2.510884] #0: 000000008702dddc (cpu_hotplug_lock.rw_sem){++++}, > at: kmem_cache_destroy+0x32/0x2b0 > [ 2.510884] #1: 0000000050103e4d (mem_hotplug_lock.rw_sem){++++}, > at: kmem_cache_destroy+0x37/0x2b0 > [ 2.510884] #2: 0000000088703397 (slab_mutex){+.+.}, at: > kmem_cache_destroy+0x45/0x2b0 > [ 2.510884] > [ 2.510884] stack backtrace: > [ 2.510884] CPU: 2 PID: 1 Comm: swapper/0 Not tainted 4.19.135-rc1 #1 > [ 2.510884] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS > 2.0b 07/27/2017 > [ 2.510884] Call Trace: > [ 2.510884] dump_stack+0x7a/0xa5 > [ 2.510884] __lock_acquire+0x6f1/0x1380 > [ 2.510884] ? ret_from_fork+0x3a/0x50 > [ 2.510884] lock_acquire+0x95/0x190 > [ 2.510884] ? lock_acquire+0x95/0x190 > [ 2.510884] ? kmem_cache_destroy+0x9a/0x2b0 > [ 2.510884] ? kmem_cache_destroy+0x9a/0x2b0 > [ 2.510884] __mutex_lock+0x83/0x990 > [ 2.510884] ? kmem_cache_destroy+0x9a/0x2b0 > [ 2.510884] ? kmem_cache_destroy+0x60/0x2b0 > [ 2.510884] ? set_debug_rodata+0x17/0x17 > [ 2.510884] ? set_debug_rodata+0x17/0x17 > [ 2.510884] mutex_lock_nested+0x1b/0x20 > [ 2.510884] ? get_online_mems+0x5f/0x90 > [ 2.510884] ? mutex_lock_nested+0x1b/0x20 > [ 2.510884] kmem_cache_destroy+0x9a/0x2b0 > [ 2.510884] ? set_debug_rodata+0x17/0x17 > [ 2.510884] intel_iommu_init+0x11c6/0x1326 > [ 2.510884] ? kfree+0xc4/0x240 > [ 2.510884] ? lockdep_hardirqs_on+0xef/0x180 > [ 2.510884] ? kfree+0xc4/0x240 > [ 2.510884] ? trace_hardirqs_on+0x4c/0x100 > [ 2.510884] ? unpack_to_rootfs+0x272/0x29a > [ 2.510884] ? e820__memblock_setup+0x64/0x64 > [ 2.510884] ? set_debug_rodata+0x17/0x17 > [ 2.510884] pci_iommu_init+0x1a/0x44 > [ 2.510884] ? e820__memblock_setup+0x64/0x64 > [ 2.510884] ? pci_iommu_init+0x1a/0x44 > [ 2.510884] do_one_initcall+0x61/0x2b4 > [ 2.510884] ? set_debug_rodata+0xa/0x17 > [ 2.510884] ? rcu_read_lock_sched_held+0x81/0x90 > [ 2.510884] kernel_init_freeable+0x1d8/0x270 > [ 2.510884] ? rest_init+0x190/0x190 > [ 2.510884] kernel_init+0xe/0x110 > [ 2.510884] ret_from_fork+0x3a/0x50 > > > Full test log: > https://pastebin.com/PWkk0YaF > > -- > Linaro LKFT > https://lkft.linaro.org -- Yours, Muchun