From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAFCCC4167B for ; Mon, 7 Dec 2020 12:16:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2BA04233CF for ; Mon, 7 Dec 2020 12:16:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2BA04233CF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 54E578D0005; Mon, 7 Dec 2020 07:16:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D6F48D0001; Mon, 7 Dec 2020 07:16:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39F018D0005; Mon, 7 Dec 2020 07:16:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0044.hostedemail.com [216.40.44.44]) by kanga.kvack.org (Postfix) with ESMTP id 1DD1F8D0001 for ; Mon, 7 Dec 2020 07:16:47 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D1B66181AEF1E for ; Mon, 7 Dec 2020 12:16:46 +0000 (UTC) X-FDA: 77566384812.23.lock73_1114e2f273de Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id B242937608 for ; Mon, 7 Dec 2020 12:16:46 +0000 (UTC) X-HE-Tag: lock73_1114e2f273de X-Filterd-Recvd-Size: 4882 Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Mon, 7 Dec 2020 12:16:45 +0000 (UTC) Received: by mail-pj1-f65.google.com with SMTP id o7so7332461pjj.2 for ; Mon, 07 Dec 2020 04:16:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2jD4wHcJJlBIQx2668YfWwft0+hoWgNC83Bw+E+5vHU=; b=urv5yGIB55SdkAowinQ5hQNE4We7mRVn/jy61tXEo+c5qJikiNyPSAOANZcKoFVXCh JQ0T3BpdVoNDfuFySpVTHCLylsab91jHwBjvq5soJR3ST/M2x2My9gFuojp5nbBLNpto upQ9pq1liyxJFaO/7VXvevlieC6z4bnw9t/KkpXoO/gsbTaAZ6+z6QtnyLTH02Qyyl+6 PB70h6zoFvrpjbqIUoisTMNjlRSfGJf9KONB5K2j2uyUVwI+wqxFY81JzWK/68VamowZ 0b2SfHZxEvaf/EWswY/H4+6NEM/IoDl31NvbiGliB/iz+wIJN2URLSmT0+Qda2X+Jhex 572Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2jD4wHcJJlBIQx2668YfWwft0+hoWgNC83Bw+E+5vHU=; b=KiPMSko9aJuoH2XL6a391Z4PZyI1GvsjLuOEaHS1B0xQkKrB+iecfYRtdxvFEVe8DK +yJCnVtJv/esAI1r9ERQTU8qCWt6Sa3jGRSRcrQ46U+dm5akJAsPJude7HyuO17h0brX 2DKsutBTr21pe4dZIotolQwvjFkUlbnzaC7K0IyZnUl9cdc3nWNYdmMs46q6wEAcJVyI S1dAhcq8cNf+aJ2BmiFwNxRi486KCclPfsE98evmOYtsWLm9bANZHqU5J3ErJLU1/WYT 0VYBeUE0pu0XS4nb1ARGkKJ32zIAekRzmLpjN90KATkUVveyYBM6oP/WI+3wuB94WMo+ DBCg== X-Gm-Message-State: AOAM530vhjxMXmOwsb8/bjjZivpt6m7Dgr1ADgsN1I3zTpI1BV47UvEK CIdE8jXk5a5lNPUPN3uHJpOXxqDzMNyLUJEwGQWaTw== X-Google-Smtp-Source: ABdhPJx7dJV6HPyqzd41Q0ApDOhuD6KvtSFfq9vHWey0F0Shcc9vdI4nXgzDX3fwRfhjmHt9GIpXonvCDxH4DymN7Qs= X-Received: by 2002:a17:90a:ba88:: with SMTP id t8mr16138235pjr.229.1607343403421; Mon, 07 Dec 2020 04:16:43 -0800 (PST) MIME-Version: 1.0 References: <20201130151838.11208-1-songmuchun@bytedance.com> <20201130151838.11208-3-songmuchun@bytedance.com> <3840b0eb-bc65-6ad4-9ef9-f6e1603d1473@redhat.com> In-Reply-To: <3840b0eb-bc65-6ad4-9ef9-f6e1603d1473@redhat.com> From: Muchun Song Date: Mon, 7 Dec 2020 20:16:07 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v7 02/15] mm/memory_hotplug: Move {get,put}_page_bootmem() to bootmem_info.c To: David Hildenbrand Cc: Jonathan Corbet , Mike Kravetz , Thomas Gleixner , mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, Peter Zijlstra , viro@zeniv.linux.org.uk, Andrew Morton , paulmck@kernel.org, mchehab+huawei@kernel.org, pawan.kumar.gupta@linux.intel.com, Randy Dunlap , oneukum@suse.com, anshuman.khandual@arm.com, jroedel@suse.de, Mina Almasry , David Rientjes , Matthew Wilcox , Oscar Salvador , Michal Hocko , "Song Bao Hua (Barry Song)" , Xiongchun duan , linux-doc@vger.kernel.org, LKML , Linux Memory Management List , linux-fsdevel Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 7, 2020 at 8:14 PM David Hildenbrand wrote: > > On 30.11.20 16:18, Muchun Song wrote: > > In the later patch, we will use {get,put}_page_bootmem() to initialize > > the page for vmemmap or free vmemmap page to buddy. So move them out of > > CONFIG_MEMORY_HOTPLUG_SPARSE. This is just code movement without any > > functional change. > > > > Signed-off-by: Muchun Song > > Acked-by: Mike Kravetz > > Reviewed-by: Oscar Salvador > > --- > > arch/x86/mm/init_64.c | 2 +- > > include/linux/bootmem_info.h | 13 +++++++++++++ > > include/linux/memory_hotplug.h | 4 ---- > > mm/bootmem_info.c | 25 +++++++++++++++++++++++++ > > mm/memory_hotplug.c | 27 --------------------------- > > mm/sparse.c | 1 + > > 6 files changed, 40 insertions(+), 32 deletions(-) > > > > I'd squash this into the previous patch and name it like > > "mm/memory_hotplug: Factor out bootmem core functions to bootmem_info.c" OK, will do. Thanks for your suggestions. :) > > > -- > Thanks, > > David / dhildenb > -- Yours, Muchun