From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03791C388F7 for ; Tue, 10 Nov 2020 03:20:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7BDD72075E for ; Tue, 10 Nov 2020 03:20:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bytedance-com.20150623.gappssmtp.com header.i=@bytedance-com.20150623.gappssmtp.com header.b="V/8PpzAY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7BDD72075E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AE3346B0036; Mon, 9 Nov 2020 22:20:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A93216B005C; Mon, 9 Nov 2020 22:20:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9824A6B005D; Mon, 9 Nov 2020 22:20:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0092.hostedemail.com [216.40.44.92]) by kanga.kvack.org (Postfix) with ESMTP id 6532A6B0036 for ; Mon, 9 Nov 2020 22:20:24 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 0B9D1181AEF1A for ; Tue, 10 Nov 2020 03:20:24 +0000 (UTC) X-FDA: 77467055568.23.act82_420e0d2272f1 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id DEDD737608 for ; Tue, 10 Nov 2020 03:20:23 +0000 (UTC) X-HE-Tag: act82_420e0d2272f1 X-Filterd-Recvd-Size: 4936 Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Tue, 10 Nov 2020 03:20:23 +0000 (UTC) Received: by mail-pg1-f196.google.com with SMTP id z24so8952006pgk.3 for ; Mon, 09 Nov 2020 19:20:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RmZMs4GZmfJF8Fdhkv3dMimRPyWWITH+SYPWeKRj3iE=; b=V/8PpzAY+tj3MaT3pbJokjVFCPodRWTiKBOOsxnc5JOelQuZm4fKIz3aMJU/9mRavo 6sqeUvW5CF7aOdRtY24WWtf2pnqJpF6d8QJqegvaLZWlSk/lE5qKa8f9bUj7N5h1IQH/ itrE++Uoz4EefemYNYYiOcGrNoUn2daqWgwXx9XFCXw7jGEwXXw/A/mnlNz10/GU4On0 UIRYmMjY3KcKBgYFoGlwvJGK9vaTuP87RBUE8AxVQ8BegKaXClTX48zscvECI+cAzrC8 /hw44C1Mv1tGKJ4OEgTd0Cs5LFv7Mdj6tIPvPQt2S9UL1uhUyTDGWkF49IJYJTIM7OCB X3EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RmZMs4GZmfJF8Fdhkv3dMimRPyWWITH+SYPWeKRj3iE=; b=gR4e+eUPZ49RqVzA5wmaQgFML0kCcf649ukpxdxdWjvHUtkUHXiFzTvv0k9LaXRhAa SwIcYJj4D57oPprEfrhhpn+l7u53QEiLVQVd78LHHbUVYNIENDCwIbSzSqbAPJ9mZkaX UdFJkAj8dkHF5yjfn8h5mGoEVyVHGuzn43qxELnkuY3rik/NaGhYOgUJ2RxL0phYYc2H YBVUoClb19PvWVMGYwJ6+05qEXt1+zTTuN3/Id4CJpi5KVRGRLcNvkqk1eVxOqbCTosr r6FRyUFxTsLlhzO/Db5kEyz9IQRgA0GGyieXVZ1Nsj4TtVsqFSY7S2Q8ZW6J51elaWot zuqQ== X-Gm-Message-State: AOAM533Do6GK4in4x7x8g1DxsFVbPsgsj+Pveks6T4aFEtDNm32mfVg4 PYGsXCcBtQ8DJIsJ4cuPyR1ZDL37noWQk7MnvDf8Hg== X-Google-Smtp-Source: ABdhPJy4bpxnsO5pklMkzSdiRHsoNta+GW29EFNBoBI7DxyYuC5HlF/QzQP409Ri9BAAjtrnI8ByVVoN0Qb7Sm3Jyr4= X-Received: by 2002:a63:7408:: with SMTP id p8mr14936096pgc.273.1604978422039; Mon, 09 Nov 2020 19:20:22 -0800 (PST) MIME-Version: 1.0 References: <20201028035013.99711-1-songmuchun@bytedance.com> <20201028035013.99711-2-songmuchun@bytedance.com> In-Reply-To: <20201028035013.99711-2-songmuchun@bytedance.com> From: Muchun Song Date: Tue, 10 Nov 2020 11:19:46 +0800 Message-ID: Subject: Re: [PATCH v2] mm: memcg/slab: Fix use after free in obj_cgroup_charge To: Andrew Morton Cc: LKML , Michal Hocko , Roman Gushchin , Shakeel Butt , Johannes Weiner , Joonsoo Kim , Yafang Shao , Thomas Gleixner , Chris Down , Cgroups , esyr@redhat.com, Christian Brauner , Marco Elver , Peter Zijlstra , Linux Memory Management List , Ingo Molnar , Kees Cook , areber@redhat.com, Suren Baghdasaryan , Vladimir Davydov Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 28, 2020 at 11:50 AM Muchun Song wrote: > > The rcu_read_lock/unlock only can guarantee that the memcg will > not be freed, but it cannot guarantee the success of css_get to > memcg. > > If the whole process of a cgroup offlining is completed between > reading a objcg->memcg pointer and bumping the css reference on > another CPU, and there are exactly 0 external references to this > memory cgroup (how we get to the obj_cgroup_charge() then?), > css_get() can change the ref counter from 0 back to 1. > > Fixes: bf4f059954dc ("mm: memcg/slab: obj_cgroup API") > Signed-off-by: Muchun Song > Acked-by: Roman Gushchin Hi Andrew, Maybe you forgot to add this to the queue for the merge window? Thanks. > --- > changelog in v2: > 1. Add unlikely and update the commit log suggested by Roman. > > mm/memcontrol.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 8c8b4c3ed5a0..d9cdf899c6fc 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -3221,8 +3221,10 @@ int obj_cgroup_charge(struct obj_cgroup *objcg, gfp_t gfp, size_t size) > * independently later. > */ > rcu_read_lock(); > +retry: > memcg = obj_cgroup_memcg(objcg); > - css_get(&memcg->css); > + if (unlikely(!css_tryget(&memcg->css))) > + goto retry; > rcu_read_unlock(); > > nr_pages = size >> PAGE_SHIFT; > -- > 2.20.1 > -- Yours, Muchun