From: Muchun Song <songmuchun@bytedance.com>
To: Michal Hocko <mhocko@suse.com>
Cc: Mike Kravetz <mike.kravetz@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Andi Kleen <ak@linux.intel.com>,
Linux Memory Management List <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [External] Re: [PATCH v3 4/6] mm: hugetlb: add return -EAGAIN for dissolve_free_huge_page
Date: Tue, 12 Jan 2021 18:49:17 +0800 [thread overview]
Message-ID: <CAMZfGtVvrMegtXhZbPxgX_6ryJGoU6B64coLkBBUe4yf0jG-9A@mail.gmail.com> (raw)
In-Reply-To: <20210112100602.GL22493@dhcp22.suse.cz>
On Tue, Jan 12, 2021 at 6:06 PM Michal Hocko <mhocko@suse.com> wrote:
>
> On Tue 12-01-21 17:51:05, Muchun Song wrote:
> > On Tue, Jan 12, 2021 at 4:33 PM Michal Hocko <mhocko@suse.com> wrote:
> > >
> > > On Mon 11-01-21 17:20:51, Mike Kravetz wrote:
> > > > On 1/10/21 4:40 AM, Muchun Song wrote:
> > > > > There is a race between dissolve_free_huge_page() and put_page(),
> > > > > and the race window is quite small. Theoretically, we should return
> > > > > -EBUSY when we encounter this race. In fact, we have a chance to
> > > > > successfully dissolve the page if we do a retry. Because the race
> > > > > window is quite small. If we seize this opportunity, it is an
> > > > > optimization for increasing the success rate of dissolving page.
> > > > >
> > > > > If we free a HugeTLB page from a non-task context, it is deferred
> > > > > through a workqueue. In this case, we need to flush the work.
> > > > >
> > > > > The dissolve_free_huge_page() can be called from memory hotplug,
> > > > > the caller aims to free the HugeTLB page to the buddy allocator
> > > > > so that the caller can unplug the page successfully.
> > > > >
> > > > > Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> > > > > ---
> > > > > mm/hugetlb.c | 26 +++++++++++++++++++++-----
> > > > > 1 file changed, 21 insertions(+), 5 deletions(-)
> > > >
> > > > I am unsure about the need for this patch. The code is OK, there are no
> > > > issues with the code.
> > > >
> > > > As mentioned in the commit message, this is an optimization and could
> > > > potentially cause a memory offline operation to succeed instead of fail.
> > > > However, we are very unlikely to ever exercise this code. Adding an
> > > > optimization that is unlikely to be exercised is certainly questionable.
> > > >
> > > > Memory offline is the only code that could benefit from this optimization.
> > > > As someone with more memory offline user experience, what is your opinion
> > > > Michal?
> > >
> > > I am not a great fun of optimizations without any data to back them up.
> > > I do not see any sign this code has been actually tested and the
> > > condition triggered.
> >
> > This race is quite small. I only trigger this only once on my server.
> > And then the kernel panic. So I sent this patch series to fix some
> > bugs.
>
> Memory hotplug shouldn't panic when this race happens. Are you sure you
> have seen a race that is directly related to this patch?
I mean the panic is fixed by:
[PATCH v3 3/6] mm: hugetlb: fix a race between freeing and dissolving the page
>
> > > Besides that I have requested to have an explanation of why blocking on
> > > the WQ is safe and that hasn't happened.
> >
> > I have seen all the caller of dissolve_free_huge_page, some caller is under
> > page lock (via lock_page). Others are also under a sleep context.
> >
> > So I think that blocking on the WQ is safe. Right?
>
> I have requested to explicitly write your thinking why this is safe so
> that we can double check it. Dependency on a work queue progress is much
> more complex than any other locks because there is no guarantee that WQ
> will make forward progress (all workers might be stuck, new workers not
> able to be created etc.).
OK. I know about your concern. How about setting the page as temporary
when hitting this race?
int dissolve_free_huge_page(struct page *page)
{
@@ -1793,8 +1794,10 @@ int dissolve_free_huge_page(struct page *page)
* We should make sure that the page is already on the free list
* when it is dissolved.
*/
- if (unlikely(!PageHugeFreed(head)))
+ if (unlikely(!PageHugeFreed(head))) {
+ SetPageHugeTemporary(page)
goto out;
+ }
Setting the page as temporary and just return -EBUSY (do not flush
the work). __free_huge_page() will free it to the buddy allocator later.
> --
> Michal Hocko
> SUSE Labs
next prev parent reply other threads:[~2021-01-12 10:50 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-10 12:40 [PATCH v3 0/6] Fix some bugs about HugeTLB code Muchun Song
2021-01-10 12:40 ` [PATCH v3 1/6] mm: migrate: do not migrate HugeTLB page whose refcount is one Muchun Song
2021-01-12 9:42 ` Michal Hocko
2021-01-12 9:43 ` [External] " Muchun Song
2021-01-12 11:00 ` David Hildenbrand
2021-01-12 11:11 ` David Hildenbrand
2021-01-12 11:27 ` Michal Hocko
2021-01-12 11:34 ` David Hildenbrand
2021-01-12 12:16 ` Michal Hocko
2021-01-12 14:23 ` Michal Hocko
2021-01-12 14:41 ` David Hildenbrand
2021-01-12 14:53 ` Michal Hocko
2021-01-12 20:12 ` Mike Kravetz
2021-01-12 13:40 ` [External] " Muchun Song
2021-01-12 13:51 ` David Hildenbrand
2021-01-12 14:17 ` Muchun Song
2021-01-12 14:28 ` David Hildenbrand
2021-01-12 14:59 ` Muchun Song
2021-01-10 12:40 ` [PATCH v3 2/6] mm: hugetlbfs: fix cannot migrate the fallocated HugeTLB page Muchun Song
2021-01-11 23:04 ` Mike Kravetz
2021-01-12 9:45 ` Michal Hocko
2021-01-10 12:40 ` [PATCH v3 3/6] mm: hugetlb: fix a race between freeing and dissolving the page Muchun Song
2021-01-12 1:06 ` Mike Kravetz
2021-01-12 10:02 ` Michal Hocko
2021-01-12 10:13 ` [External] " Muchun Song
2021-01-12 11:17 ` Michal Hocko
2021-01-12 11:43 ` Muchun Song
2021-01-12 12:37 ` Michal Hocko
2021-01-12 15:05 ` Muchun Song
2021-01-10 12:40 ` [PATCH v3 4/6] mm: hugetlb: add return -EAGAIN for dissolve_free_huge_page Muchun Song
2021-01-12 1:20 ` Mike Kravetz
2021-01-12 8:33 ` Michal Hocko
2021-01-12 9:51 ` [External] " Muchun Song
2021-01-12 10:06 ` Michal Hocko
2021-01-12 10:49 ` Muchun Song [this message]
2021-01-12 11:11 ` Michal Hocko
2021-01-12 11:34 ` Muchun Song
2021-01-10 12:40 ` [PATCH v3 5/6] mm: hugetlb: fix a race between isolating and freeing page Muchun Song
2021-01-10 12:40 ` [PATCH v3 6/6] mm: hugetlb: remove VM_BUG_ON_PAGE from page_huge_active Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMZfGtVvrMegtXhZbPxgX_6ryJGoU6B64coLkBBUe4yf0jG-9A@mail.gmail.com \
--to=songmuchun@bytedance.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).