From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21BD8C56202 for ; Mon, 23 Nov 2020 08:02:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6DCA32075A for ; Mon, 23 Nov 2020 08:02:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bytedance-com.20150623.gappssmtp.com header.i=@bytedance-com.20150623.gappssmtp.com header.b="PsvMXAco" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6DCA32075A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9DE206B005D; Mon, 23 Nov 2020 03:02:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 98DB76B0070; Mon, 23 Nov 2020 03:02:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8565B6B0071; Mon, 23 Nov 2020 03:02:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0110.hostedemail.com [216.40.44.110]) by kanga.kvack.org (Postfix) with ESMTP id 590356B005D for ; Mon, 23 Nov 2020 03:02:42 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 03695180AD820 for ; Mon, 23 Nov 2020 08:02:42 +0000 (UTC) X-FDA: 77514941364.27.stove89_2408bc627363 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin27.hostedemail.com (Postfix) with ESMTP id D48643D663 for ; Mon, 23 Nov 2020 08:02:41 +0000 (UTC) X-HE-Tag: stove89_2408bc627363 X-Filterd-Recvd-Size: 4953 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Mon, 23 Nov 2020 08:02:41 +0000 (UTC) Received: by mail-pf1-f194.google.com with SMTP id b6so3724771pfp.7 for ; Mon, 23 Nov 2020 00:02:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LjW5kf1b1Fcrz9tIggA1cpzx5YJFFwp+TEs9UtQIZsw=; b=PsvMXAcoEQ4hU0UZyLqO+PoN3PXrPBxWC79QMPfmg/GeikUA+SP8/ijNRw21dSTXiJ xNPNUGCNDUPwI6ifrInTqzcWJKex5iemykaV2fHR+J5/zcJTfvCdDZCgfwNA4YMJg1k0 pnW3LHjw4DSuK+4v91P6GJ270fMdQtRMW5csIIxjxrv0croy/8qu2J0TkgMk3qbqE4O+ Urs14aeqs+PCcTeQPCDHwqqTnM9TUgBa+NlQongfRf9g7OD17aGWB8RxYwznDsxCxu5Z UJqU6o2Q7MvZRsBqPFfMaRzBB8oji3PoIckEUKR84XfDUAyhPSjqi4OR+g4Hd6uwP5B0 Yg2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LjW5kf1b1Fcrz9tIggA1cpzx5YJFFwp+TEs9UtQIZsw=; b=hw/udFe2eOH6M19twaBS5MnW/iUXcQb2CHwIPlVGgpQ4Ng8L+ziJIdjaV5Mk/A0cpC qjeVldkwPfa8W3rKEsKZZaIbWzExiVgKKF+AUDwbvk5mA30m/AX6DtzzrFsx8BhW+tQM tVliYgVpcDUr65GCqBYCim5j0MzXY8mqvNq0txLaqbIpOIClWdRKwq1UOKO7D/B3789S d9YTjU+xXTCU6HDoOMSPObvBL1wgANqnMJbeUBe12MWvo0rox0pS6Vs1JxHU5x782miK /dO1OwtAbfJ5BeB+W8wWmY9nWQ0eq2xztV1iWdw2SnMHQ5voq23INfxJmOQ4g2GXw+Id uLLw== X-Gm-Message-State: AOAM532VNOjK+0FZz3nNoi1QzX9DLYmVlm7cDTxyF0VgUHXWQz9IoZmM /rMjZsikUJxOK/WwGjDwyBJZKM8aP0+fjyKgdBghvQ== X-Google-Smtp-Source: ABdhPJz4q3i27WpndCtivA4jdkLBmsJFiWT7v+RK+RF8zB1bKuJ/sddH4D73BQja9ZIobFqLizBVKi+BNz073q7oDn8= X-Received: by 2002:aa7:8105:0:b029:18e:c8d9:2c24 with SMTP id b5-20020aa781050000b029018ec8d92c24mr23947117pfi.49.1606118559844; Mon, 23 Nov 2020 00:02:39 -0800 (PST) MIME-Version: 1.0 References: <20201120064325.34492-1-songmuchun@bytedance.com> <20201120064325.34492-14-songmuchun@bytedance.com> <20201120081638.GD3200@dhcp22.suse.cz> <20201123074804.GC27488@dhcp22.suse.cz> In-Reply-To: <20201123074804.GC27488@dhcp22.suse.cz> From: Muchun Song Date: Mon, 23 Nov 2020 16:01:59 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v5 13/21] mm/hugetlb: Use PG_slab to indicate split pmd To: Michal Hocko Cc: Jonathan Corbet , Mike Kravetz , Thomas Gleixner , mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, Peter Zijlstra , viro@zeniv.linux.org.uk, Andrew Morton , paulmck@kernel.org, mchehab+huawei@kernel.org, pawan.kumar.gupta@linux.intel.com, Randy Dunlap , oneukum@suse.com, anshuman.khandual@arm.com, jroedel@suse.de, Mina Almasry , David Rientjes , Matthew Wilcox , Oscar Salvador , "Song Bao Hua (Barry Song)" , Xiongchun duan , linux-doc@vger.kernel.org, LKML , Linux Memory Management List , linux-fsdevel Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 23, 2020 at 3:48 PM Michal Hocko wrote: > > On Fri 20-11-20 17:30:27, Muchun Song wrote: > > On Fri, Nov 20, 2020 at 4:16 PM Michal Hocko wrote: > > > > > > On Fri 20-11-20 14:43:17, Muchun Song wrote: > > > > When we allocate hugetlb page from buddy, we may need split huge pmd > > > > to pte. When we free the hugetlb page, we can merge pte to pmd. So > > > > we need to distinguish whether the previous pmd has been split. The > > > > page table is not allocated from slab. So we can reuse the PG_slab > > > > to indicate that the pmd has been split. > > > > > > PageSlab is used outside of the slab allocator proper and that code > > > might get confused by this AFAICS. > > > > I got your concerns. Maybe we can use PG_private instead of the > > PG_slab. > > Reusing a page flag arbitrarily is not that easy. Hugetlb pages have a > lot of spare room in struct page so I would rather use something else. This page is the PMD page table of vmemmap, not the vmemmap page of HugeTLB. And the page table does not use PG_private. Maybe it is enough. Thanks. > -- > Michal Hocko > SUSE Labs -- Yours, Muchun