From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85AC7C4363A for ; Thu, 29 Oct 2020 16:11:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D60652076E for ; Thu, 29 Oct 2020 16:11:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bytedance-com.20150623.gappssmtp.com header.i=@bytedance-com.20150623.gappssmtp.com header.b="aAk00euh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D60652076E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CFC676B0062; Thu, 29 Oct 2020 12:10:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CAE3C6B006C; Thu, 29 Oct 2020 12:10:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B9C7F6B006E; Thu, 29 Oct 2020 12:10:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0094.hostedemail.com [216.40.44.94]) by kanga.kvack.org (Postfix) with ESMTP id 87F9E6B0062 for ; Thu, 29 Oct 2020 12:10:59 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 214102493 for ; Thu, 29 Oct 2020 16:10:59 +0000 (UTC) X-FDA: 77425451838.29.time20_1817f152728e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id AF08418029D9C for ; Thu, 29 Oct 2020 16:09:39 +0000 (UTC) X-HE-Tag: time20_1817f152728e X-Filterd-Recvd-Size: 4873 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Thu, 29 Oct 2020 16:09:37 +0000 (UTC) Received: by mail-pf1-f194.google.com with SMTP id 10so2733660pfp.5 for ; Thu, 29 Oct 2020 09:09:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+mBWfRe+OIpv7WsNMP7DYo0jsOnffJofR1p3pyhBTUE=; b=aAk00euheapwS9xRA1bncmzHvN9I+6nyRyTCd3xMc2dkkXTXJBxXHQPbZj5LEfqx2a 5P+ylRRBoUhWmx7cNyr2tT/0FsGSiu3nvxnCMR60vF9ivHhn7fN6PfuI7sSI1nTmTQmo Cpv5WwRe5QSPQqqek07hNLOVeAKodbAY9krPKSDnktsyWuvqYizgHIugu8JcKb31NMV+ OkdSCjhNrEIJar/D7QI6ipEpTto94dnCyjP78etZHXvq5x1mi0cYudGrBkKUQoTv7PFr aKrrRWp/VwMw6wgCLeR+efWZkXG26cYmtDRxlzGMJkKASKCh05U6EQc7wd9f0/9YGzS6 Wz7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+mBWfRe+OIpv7WsNMP7DYo0jsOnffJofR1p3pyhBTUE=; b=tCp/s9khV8i4NFGTDG5pn0V9ddq5Qq6770AIF4THejaEgrG88oqsVPwI9aAwrXDruN KnD1gQA3wibsQqH2+tPqCIPYdxtOVkyPh5ngOsWOqo6/Zs0IbPcWwwdHIweGkD/MCB0D 0VaAmxrU+BWGoCUWgiN32Ms+KcBVvyH1IlsXzroIl4Bfy3NAgVy+pLBKuyrnmxk6XfET SgneG6+/sjYNQdzdf2B/NSb5Zfw+z0TCt8ZZurGSYtJPtZnbGKfL6cIQzVAFt7pAwiWS 7pCn3aihoqK+dFBDm6LujiIdcwsXeNk8HZR0ZLFNtaucXr1H+1yAZ8YbD8clMX4YPlob /VPg== X-Gm-Message-State: AOAM531kC3lrErqsruKHkuDu7h4XfZ+x1jrdyOwTF8B4sdSe+Wzae3OR CyHv/xZaPHL9Ll/2IoNefHHpoi7m3N2yY2OTQcZpQA== X-Google-Smtp-Source: ABdhPJyjZSv9zU0BpVf3RV54xkfmJECDMC0KfJwx2jtsWDnpqEhS8GqFik3yU3J6Jq1TgwaIlpsiZUFmG06Lkbixnj4= X-Received: by 2002:a17:90a:890f:: with SMTP id u15mr44881pjn.147.1603987776051; Thu, 29 Oct 2020 09:09:36 -0700 (PDT) MIME-Version: 1.0 References: <20201028035013.99711-1-songmuchun@bytedance.com> In-Reply-To: From: Muchun Song Date: Fri, 30 Oct 2020 00:08:58 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v2] mm: memcg/slab: Fix return child memcg objcg for root memcg To: Shakeel Butt Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Roman Gushchin , Joonsoo Kim , Yafang Shao , Chris Down , Christian Brauner , "Peter Zijlstra (Intel)" , Ingo Molnar , Kees Cook , Thomas Gleixner , esyr@redhat.com, Suren Baghdasaryan , areber@redhat.com, Marco Elver , LKML , Cgroups , Linux MM Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 29, 2020 at 11:48 PM Shakeel Butt wrote: > > On Tue, Oct 27, 2020 at 8:50 PM Muchun Song wrote: > > > > Consider the following memcg hierarchy. > > > > root > > / \ > > A B > > > > If we get the objcg of memcg A failed, > > Please fix the above statement. Sorry, could you be more specific, I don't quite understand. Thanks. > > > the get_obj_cgroup_from_current > > can return the wrong objcg for the root memcg. > > > > Fixes: bf4f059954dc ("mm: memcg/slab: obj_cgroup API") > > Signed-off-by: Muchun Song > > --- > > changelog in v2: > > 1. Do not use a comparison with the root_mem_cgroup > > > > mm/memcontrol.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > index 1337775b04f3..8c8b4c3ed5a0 100644 > > --- a/mm/memcontrol.c > > +++ b/mm/memcontrol.c > > @@ -2961,6 +2961,7 @@ __always_inline struct obj_cgroup *get_obj_cgroup_from_current(void) > > objcg = rcu_dereference(memcg->objcg); > > if (objcg && obj_cgroup_tryget(objcg)) > > break; > > + objcg = NULL; > > Roman, in your cleanup, are you planning to have objcg for root memcg as well? > > > } > > rcu_read_unlock(); > > > > -- > > 2.20.1 > > -- Yours, Muchun