From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C9F9C4361B for ; Thu, 10 Dec 2020 17:06:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3D0F223340 for ; Thu, 10 Dec 2020 17:06:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D0F223340 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C27396B0085; Thu, 10 Dec 2020 12:06:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BAFE76B0087; Thu, 10 Dec 2020 12:06:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A9EFA6B0088; Thu, 10 Dec 2020 12:06:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0173.hostedemail.com [216.40.44.173]) by kanga.kvack.org (Postfix) with ESMTP id 9148A6B0085 for ; Thu, 10 Dec 2020 12:06:35 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 583D7180AD82F for ; Thu, 10 Dec 2020 17:06:35 +0000 (UTC) X-FDA: 77578001550.26.pen16_1f04770273f9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id 34FB51804B668 for ; Thu, 10 Dec 2020 17:06:35 +0000 (UTC) X-HE-Tag: pen16_1f04770273f9 X-Filterd-Recvd-Size: 4514 Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Thu, 10 Dec 2020 17:06:34 +0000 (UTC) Received: by mail-pf1-f196.google.com with SMTP id w6so4702670pfu.1 for ; Thu, 10 Dec 2020 09:06:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OfRhTAas1NcetqsYHCdhKdRkmhDx/6FtHvtSU75aAas=; b=Mb7SoDls4nifj95yys/nowAqBSY/LC+BoX0EAbTxa/y37i1DCYf4rw1bYQJ4mH4vYL /1ttdgE5mTdf5ZZpBvmUxqILY8drb6/plJX6BwO2W8VE3YlkIQfaf51ZC2x1kQT0g3KR CIcHoj27fgpFrnmV3MYI9byhT8ZNtQzXErfG0CToemZtuHzIKA8WsjG+A5ykxbFi2KnZ yeCY2mGPMAlz+HrKB3/d/fc5YUhKBSIF4Yxg1cn0R7pweYEYK1VMPizYW8ntZY9wTL4Q 3UU9CuW31tWbcEDJ3/7Br6bxpfYVuEwjWp3JbOBj+6c/hfa3Fo4hoT+tfeHOuOoUXtyT mpJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OfRhTAas1NcetqsYHCdhKdRkmhDx/6FtHvtSU75aAas=; b=kL4quXQhFwS+RXhKJjit/gIjZGXNXt9WT3uLemx8jAGC5E1Ybb6dQ/UTu/hGABdC67 R53H5Hd9HzIzoz97dAZbZWqYhXngltwQGcIAzhidN/gpC/nmNw65zvUp32TYuwCtaf0x uDzoYyGNGcfG0t/3+5oQ5V01eb6wSSuHvKQn0yAEMb7DyXm/muYztY1XmNiSExQLr1Ty Ka3Ot3AYZDQjo35f4sMtSy3OVEEKzN7WjDeBu7WlvP2GeqJ7HbH6Gtx91xKKXTR1deir XhS5hOnZVVtqqoaV3kSccc2GDVnTski/4aOUYvvU3Hq4LQe8dgeuNjIin3A5Cg2WMcLB aG3A== X-Gm-Message-State: AOAM530hvW5NC9p/6dCYarvw6QgJu1SDWr36LXzos8FP1l2OqN9wMXTp 6o6huR9ivduavnjBRfGXymNWeyo19lQM1PS0k+KnmA== X-Google-Smtp-Source: ABdhPJwzwDINb3ns3Cp832HhOjuUTFM1ozT9iHLW2N0EKRAzFHGslaUcpij+yIP4IAk6go9O4lzqaBQwKLO9C1yk9vE= X-Received: by 2002:aa7:8105:0:b029:18e:c8d9:2c24 with SMTP id b5-20020aa781050000b029018ec8d92c24mr7623323pfi.49.1607619993694; Thu, 10 Dec 2020 09:06:33 -0800 (PST) MIME-Version: 1.0 References: <20201206101451.14706-1-songmuchun@bytedance.com> <20201206101451.14706-3-songmuchun@bytedance.com> <20201210161029.GI264602@cmpxchg.org> In-Reply-To: <20201210161029.GI264602@cmpxchg.org> From: Muchun Song Date: Fri, 11 Dec 2020 01:05:57 +0800 Message-ID: Subject: Re: [External] Re: [RESEND PATCH v2 02/12] mm: memcontrol: convert NR_ANON_THPS account to pages To: Johannes Weiner Cc: Greg KH , "Rafael J. Wysocki" , Alexey Dobriyan , Andrew Morton , Michal Hocko , Vladimir Davydov , Hugh Dickins , Will Deacon , Roman Gushchin , Mike Rapoport , Thomas Gleixner , esyr@redhat.com, peterx@redhat.com, krisman@collabora.com, Suren Baghdasaryan , avagin@openvz.org, Marco Elver , Randy Dunlap , Joonsoo Kim , LKML , linux-fsdevel , Linux Memory Management List , Cgroups Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 11, 2020 at 12:12 AM Johannes Weiner wrote: > > On Sun, Dec 06, 2020 at 06:14:41PM +0800, Muchun Song wrote: > > @@ -1144,7 +1144,8 @@ void do_page_add_anon_rmap(struct page *page, > > * disabled. > > */ > > if (compound) > > - __inc_lruvec_page_state(page, NR_ANON_THPS); > > + __mod_lruvec_page_state(page, NR_ANON_THPS, > > + HPAGE_PMD_NR); > > __mod_lruvec_page_state(page, NR_ANON_MAPPED, nr); > > What I mistakenly wrote about the previous patch applies to this and > the following patches, though: > > /proc/vmstat currently prints number of anon, file and shmem THPs; you > are changing it to print number of 4k pages in those THPs. > > That's an ABI change we cannot really do. Agree. Sorry. I forgot to fix the /proc/vmstat. Thanks for your reminder. -- Yours, Muchun