From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25FA0C433E0 for ; Mon, 15 Jun 2020 06:21:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DACD320679 for ; Mon, 15 Jun 2020 06:21:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bytedance-com.20150623.gappssmtp.com header.i=@bytedance-com.20150623.gappssmtp.com header.b="SwKnoN2L" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DACD320679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 87F376B0002; Mon, 15 Jun 2020 02:21:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 809166B0003; Mon, 15 Jun 2020 02:21:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D0656B0005; Mon, 15 Jun 2020 02:21:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0202.hostedemail.com [216.40.44.202]) by kanga.kvack.org (Postfix) with ESMTP id 52DC16B0002 for ; Mon, 15 Jun 2020 02:21:23 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 2031F3573 for ; Mon, 15 Jun 2020 06:21:23 +0000 (UTC) X-FDA: 76930449246.29.cap04_230ac9926df4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id EE70418086E24 for ; Mon, 15 Jun 2020 06:21:22 +0000 (UTC) X-HE-Tag: cap04_230ac9926df4 X-Filterd-Recvd-Size: 3813 Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Mon, 15 Jun 2020 06:21:22 +0000 (UTC) Received: by mail-io1-f68.google.com with SMTP id w18so16568608iom.5 for ; Sun, 14 Jun 2020 23:21:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=6UexJ591yY/0sBQwidfRyePuoEU/goCNRqDs0Bqn1P0=; b=SwKnoN2LBJMXiwPZLzjvgItvTNq5+bLqGvbDhWTsULRJeUMDolVhfaTo0DIqZ4UZ/r s8LNecQlyc4a/QhHY5SnWte0Mpo7QpV+jwOinyZHu9Fnm3Gy+3fEkIfPgUNqoay9puVC A9ftYAROGf4nyQpww/PevBIJJpBqiZ0w/5AqfXcDRZFveUv/Xm3ubxezEJzYcOXmTtjH UE01dgXoMSF+8fxTSN7cYllase901fFmRKat7AaWvHgbZCF9fQ24RxZ51WWbBwvftRqm CigC27toyhTGjXiTw0aWIHbUePGP4GBkBoQzwg4I3hWP39pJzRYNF4e1Tx2q/UjyNDGU lgDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=6UexJ591yY/0sBQwidfRyePuoEU/goCNRqDs0Bqn1P0=; b=ZuFfMADCLJlpCdZmM/ThZpdzpY1Ja6Ru8ONriguOr5bjf+FAitGrY41ngCMRBrVKeR OHj9CpIFQmswYrYZIvXhmBHwpYaj/KQx+Ebusb53jBCBDSzdDOFRmxrNMTu6+1V54CG5 HTgnXDC3kqQchE6EDX7vFsjy6yz4T/fECo42ZCkCzwB5vwZBZchk4QVn0+nSYllsq8QO g4mwh+oZfrQFHN/nV5g0pIrxBO/P0XgDhRJrnE6ubFD22gyqXiGopnopNsQoca7YaKQW 2GIl50i1Sik0+vtLcBhEqXkKKnS0vl0r7XkwXe/YTtmqPUfNEE7n85lCz7yjEJsQDH3z 5bDA== X-Gm-Message-State: AOAM533VNic5BzRYBLOgxSChLIvEchPRNnL34FkCvEdF9oSQ0OyIeQvg pGFdroDYwsMbWAjn3q5xj0Xinn2ke40THdWUGXC1uA== X-Google-Smtp-Source: ABdhPJz0qbxo88JZGJbwCkq5eq49FEpObhjkgWYBnJ3nngjmkA+GvLULUmZduP7VTteF5jmI93hTGQE13PkFgWQajks= X-Received: by 2002:a6b:1745:: with SMTP id 66mr26322154iox.151.1592202081507; Sun, 14 Jun 2020 23:21:21 -0700 (PDT) MIME-Version: 1.0 References: <20200614123923.99189-1-songmuchun@bytedance.com> <20200614123923.99189-3-songmuchun@bytedance.com> In-Reply-To: From: Muchun Song Date: Mon, 15 Jun 2020 14:20:45 +0800 Message-ID: Subject: Re: [External] Re: [PATCH 2/3] mm/slub: Use node_nr_slabs() instead of slabs_node() To: Joonsoo Kim Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: EE70418086E24 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 15, 2020 at 2:15 PM Joonsoo Kim wrote: > > 2020=EB=85=84 6=EC=9B=94 14=EC=9D=BC (=EC=9D=BC) =EC=98=A4=ED=9B=84 9:39,= Muchun Song =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84= =B1: > > > > In the some code, we already get the kmem_cache_node, so we can > > use node_nr_slabs() directly instead of slabs_node(). Check the > > condition of n->nr_partial can also be removed because we can get > > the correct result via node_nr_slabs(). > > > > Signed-off-by: Muchun Song > > If appying this patch, there is no reference to slabs_node(). Please remo= ve it. > > Thanks. OK, Thanks. I will remove it in the next version. --=20 Yours, Muchun