From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66813C5519F for ; Wed, 18 Nov 2020 03:28:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DFDD024699 for ; Wed, 18 Nov 2020 03:28:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bytedance-com.20150623.gappssmtp.com header.i=@bytedance-com.20150623.gappssmtp.com header.b="Z0Pooym/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DFDD024699 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 044DA6B0068; Tue, 17 Nov 2020 22:28:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 01B846B006C; Tue, 17 Nov 2020 22:28:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DFF786B006E; Tue, 17 Nov 2020 22:28:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0151.hostedemail.com [216.40.44.151]) by kanga.kvack.org (Postfix) with ESMTP id B26E36B0068 for ; Tue, 17 Nov 2020 22:28:36 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 363E8181AEF09 for ; Wed, 18 Nov 2020 03:28:36 +0000 (UTC) X-FDA: 77496106632.09.bulb81_0b0a64d27337 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id 1EF92180AD80F for ; Wed, 18 Nov 2020 03:28:36 +0000 (UTC) X-HE-Tag: bulb81_0b0a64d27337 X-Filterd-Recvd-Size: 4852 Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Wed, 18 Nov 2020 03:28:35 +0000 (UTC) Received: by mail-pf1-f193.google.com with SMTP id w14so530112pfd.7 for ; Tue, 17 Nov 2020 19:28:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vnppsZ7cWIbTMEPsAbpATqFowYN5orqZc7MbBDjuppY=; b=Z0Pooym/oNFad9Fe/S4QBekCIl4pMLqIVpkTAhSBjg8q8MTG2Hs2M2yTtaycmXUXMB DCWzShQbQD9VmvWsQar+Ba/TElkxIPONZ2xofnFJio2KvPpZU+7BpCOc3foRauQMCAQR b4qMuD8ipbbNSmgB2zuq4ltocv8d/92XOLEIg+9BURbLZVuJnhTCbpVcXpGJeLE23Zsh mNP5Yciiw7lqdZ7FmXJSDoSJDfTPZi9HzUNzYUiNSJMOKHyN0axH+F6Zbxsqf8864OlL BptbzgToMZ9iYyY2bFLg/dsjLr3/UvVWv1JYOMp3vP0raDRG2vtMfNH6Xq166w7wxiku AXiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vnppsZ7cWIbTMEPsAbpATqFowYN5orqZc7MbBDjuppY=; b=nWoJac57h9xlWZMoqkm/QJgPedDnVTCME1ap1OJlu0S1Oezx2FCv6rgP2tOpd0yp+J bQTlA7xX9vtyS+2lrX7jsCCbSIAksFrPY2Gj3t7kDtJYtHT4xHyu69dH4oHljcm1AHxJ R7OGWFF4jvKK65xv7tnvWKrfVFHU2rXyCalX/3bmPvdf4Tl/nHmOgJ9alR9YJujr+NDM 7nVn4gipvV2t1pd3ClZbEZezkUOLjXA0jdwwWH+8TnjdZY3Pww5V9SQKyVJYf+6Ed/5C cPPq3VQe4PyRIlsZ9ZoP8rFv5AX4yImGdFeQFvfgHJ9X3g6xvJTV/TT69/1f7JDDRPCK l44A== X-Gm-Message-State: AOAM532phG6rb2vKcMfaPpTPL754x6ty1wFYcOC6+7pRBkqP6W8/RsGR z9GY12YrozPh4gzLrDyOG3yl8qJdz5wQ/1pt94ns+w== X-Google-Smtp-Source: ABdhPJxFg2bZDDYdW5cu+c+X8qxklQebDNJ6tYNq3D6DCb4Egzt6LNdC6SdIChwp4gckYFi19M+npXEa9Q6dvYouWMU= X-Received: by 2002:a62:e116:0:b029:18b:d325:153f with SMTP id q22-20020a62e1160000b029018bd325153fmr2647216pfh.2.1605670114278; Tue, 17 Nov 2020 19:28:34 -0800 (PST) MIME-Version: 1.0 References: <20201113105952.11638-1-songmuchun@bytedance.com> <349168819c1249d4bceea26597760b0a@hisilicon.com> <714ae7d701d446259ab269f14a030fe9@hisilicon.com> In-Reply-To: From: Muchun Song Date: Wed, 18 Nov 2020 11:27:50 +0800 Message-ID: Subject: Re: [External] RE: [PATCH v4 00/21] Free some vmemmap pages of hugetlb page To: Oscar Salvador Cc: "Song Bao Hua (Barry Song)" , Jonathan Corbet , Mike Kravetz , Thomas Gleixner , mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, Peter Zijlstra , viro@zeniv.linux.org.uk, Andrew Morton , paulmck@kernel.org, mchehab+huawei@kernel.org, pawan.kumar.gupta@linux.intel.com, Randy Dunlap , oneukum@suse.com, anshuman.khandual@arm.com, jroedel@suse.de, Mina Almasry , David Rientjes , Matthew Wilcox , Michal Hocko , Xiongchun duan , linux-doc@vger.kernel.org, LKML , Linux Memory Management List , linux-fsdevel Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 18, 2020 at 3:45 AM Oscar Salvador wrote: > > On 2020-11-17 17:29, Muchun Song wrote: > > Now for the 2MB HugrTLB page, we only free 6 vmemmap pages. > > But your words woke me up. Maybe we really can free 7 vmemmap > > pages. In this case, we can see 8 of the 512 struct page structures > > has beed set PG_head flag. If we can adjust compound_head() > > slightly and make compound_head() return the real head struct > > page when the parameter is the tail struct page but with PG_head > > flag set. I will start an investigation and a test. > > I would not overcomplicate things at this stage, but rather keep it > simple as the code is already tricky enough(without counting the LOC > thatvit adds). > We can always build on top later on in order to improve things. I think that this improvement can be a separate patch. In this case, it can make the code evolution route clearer. Thanks. > > -- > Oscar Salvador > SUSE L3 -- Yours, Muchun