From: Muchun Song <songmuchun@bytedance.com>
To: Mina Almasry <almasrymina@google.com>
Cc: Linux Memory Management List <linux-mm@kvack.org>,
Mike Kravetz <mike.kravetz@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [External] [PATCH] mm, hugetlb: fix allocation error check and copy func name
Date: Sat, 5 Jun 2021 20:49:58 +0800 [thread overview]
Message-ID: <CAMZfGtWf3rx7MT88+t=H=5bVs_yNBFX5YTcWZs7in_+17i7+Fw@mail.gmail.com> (raw)
In-Reply-To: <20210605010626.1459873-1-almasrymina@google.com>
On Sat, Jun 5, 2021 at 9:07 AM Mina Almasry <almasrymina@google.com> wrote:
>
> The alloc_huge_page_vma() doesn't return error pointers, it returns
> NULL.
>
> There is an existing migrate_page_copy() which not only copies the page
> contents, but also page state/metadata. People could get confused that
> 'migrate_page_copy' and 'migrate_copy_huge_page' do not have the same
> functionality. Rename to 'copy_huge_page()' to make it less likely
> folks get confused.
>
> Fixes: 6a0badc266df ("mm, hugetlb: fix racy resv_huge_pages underflow on
> UFFDIO_COPY")
I think the commit id is not stable. So this really should squash
the commit of "mm, hugetlb: fix racy resv_huge_pages underflow
on UFFDIO_COPY". But anyway,
Reviewed-by: Muchun Song <songmuchun@bytedance.com>
>
> Signed-off-by: Mina Almasry <almasrymina@google.com>
> Cc: linux-mm@kvack.org
> Cc: Mike Kravetz <mike.kravetz@oracle.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: linux-kernel@vger.kernel.org
next prev parent reply other threads:[~2021-06-05 12:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 0:50 [PATCH v4] mm, hugetlb: fix racy resv_huge_pages underflow on UFFDIO_COPY Mina Almasry
2021-05-31 23:25 ` Andrew Morton
2021-06-01 0:11 ` Mina Almasry
2021-06-01 0:36 ` Andrew Morton
2021-06-01 2:48 ` Mina Almasry
2021-06-01 17:09 ` Mike Kravetz
2021-06-01 18:04 ` Mina Almasry
2021-06-01 18:05 ` Mina Almasry
2021-06-04 21:41 ` Mike Kravetz
2021-06-05 1:06 ` [PATCH] mm, hugetlb: fix allocation error check and copy func name Mina Almasry
2021-06-05 12:49 ` Muchun Song [this message]
2021-06-07 20:32 ` Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMZfGtWf3rx7MT88+t=H=5bVs_yNBFX5YTcWZs7in_+17i7+Fw@mail.gmail.com' \
--to=songmuchun@bytedance.com \
--cc=akpm@linux-foundation.org \
--cc=almasrymina@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).