From: Muchun Song <songmuchun@bytedance.com>
To: Shakeel Butt <shakeelb@google.com>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Roman Gushchin <guro@fb.com>, Cgroups <cgroups@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
linux- stable <stable@vger.kernel.org>
Subject: Re: [External] [PATCH 1/2] mm: memcg: fix memcg file_dirty numa stat
Date: Mon, 28 Dec 2020 13:40:54 +0800 [thread overview]
Message-ID: <CAMZfGtWqDLJkP1zk_W16F+ssiW5NujRF-LFoV2GJ-+gXvBswMQ@mail.gmail.com> (raw)
In-Reply-To: <20201227181310.3235210-1-shakeelb@google.com>
On Mon, Dec 28, 2020 at 2:13 AM Shakeel Butt <shakeelb@google.com> wrote:
>
> The kernel updates the per-node NR_FILE_DIRTY stats on page migration
> but not the memcg numa stats. That was not an issue until recently the
> commit 5f9a4f4a7096 ("mm: memcontrol: add the missing numa_stat interface
> for cgroup v2") exposed numa stats for the memcg. So fixing the
> file_dirty per-memcg numa stat.
>
> Fixes: 5f9a4f4a7096 ("mm: memcontrol: add the missing numa_stat interface for cgroup v2")
Thanks for catching this problem.
Reviewed-by: Muchun Song <songmuchun@bytedance.com>
> Signed-off-by: Shakeel Butt <shakeelb@google.com>
> Cc: <stable@vger.kernel.org>
> ---
> mm/migrate.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/migrate.c b/mm/migrate.c
> index ee5e612b4cd8..613794f6a433 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -500,9 +500,9 @@ int migrate_page_move_mapping(struct address_space *mapping,
> __inc_lruvec_state(new_lruvec, NR_SHMEM);
> }
> if (dirty && mapping_can_writeback(mapping)) {
> - __dec_node_state(oldzone->zone_pgdat, NR_FILE_DIRTY);
> + __dec_lruvec_state(old_lruvec, NR_FILE_DIRTY);
> __dec_zone_state(oldzone, NR_ZONE_WRITE_PENDING);
> - __inc_node_state(newzone->zone_pgdat, NR_FILE_DIRTY);
> + __inc_lruvec_state(new_lruvec, NR_FILE_DIRTY);
> __inc_zone_state(newzone, NR_ZONE_WRITE_PENDING);
> }
> }
> --
> 2.29.2.729.g45daf8777d-goog
>
--
Yours,
Muchun
next prev parent reply other threads:[~2020-12-28 5:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-27 18:13 [PATCH 1/2] mm: memcg: fix memcg file_dirty numa stat Shakeel Butt
2020-12-27 18:13 ` [PATCH 2/2] mm: fix numa stats for thp migration Shakeel Butt
2020-12-27 18:16 ` Shakeel Butt
2020-12-28 17:31 ` Yang Shi
2020-12-28 19:44 ` Roman Gushchin
2020-12-28 5:40 ` Muchun Song [this message]
2020-12-28 17:31 ` [PATCH 1/2] mm: memcg: fix memcg file_dirty numa stat Yang Shi
2020-12-28 19:40 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMZfGtWqDLJkP1zk_W16F+ssiW5NujRF-LFoV2GJ-+gXvBswMQ@mail.gmail.com \
--to=songmuchun@bytedance.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=shakeelb@google.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).