From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20C4DC433E0 for ; Mon, 22 Feb 2021 10:31:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9D5A460295 for ; Mon, 22 Feb 2021 10:31:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D5A460295 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 026606B006E; Mon, 22 Feb 2021 05:31:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EF1A36B0070; Mon, 22 Feb 2021 05:31:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE0D58D0001; Mon, 22 Feb 2021 05:31:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0130.hostedemail.com [216.40.44.130]) by kanga.kvack.org (Postfix) with ESMTP id C7D926B006E for ; Mon, 22 Feb 2021 05:31:51 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8D803824805A for ; Mon, 22 Feb 2021 10:31:51 +0000 (UTC) X-FDA: 77845538022.09.9F14AA3 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by imf30.hostedemail.com (Postfix) with ESMTP id 32532E0011E0 for ; Mon, 22 Feb 2021 10:31:50 +0000 (UTC) Received: by mail-pj1-f42.google.com with SMTP id ds5so933875pjb.2 for ; Mon, 22 Feb 2021 02:31:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8UWh8jduGRGu0Lvsdl9eBlyqHKjBe0P0nAH4NaZ9DMc=; b=CJhQTg5ewgzZcnE2MhOHrzTbe0C5iEgOrytZGTuvGqjQI+Uw34/pbKAhYfv55ZbEQ+ 3k1GnYlHjK3NlkzleMwne0BnkjHisb1fCE5MYMfn2irYh+FIKK5ZeBhC1r/gr4ou+UsQ 9C2upnSbHxCxznvPzFE1kIpgGUj7irS2BkklgdS3tSc5tHC4pXnPdWSCPGnbaaJGIjZk z/n8oOfCDpuoEI15EjK00iptRmFy5EsufKXUlVyopdACbYxxWNCbmWSqyS0QQZL39Rj/ K04D7A6saCRLnu+QLw3fVe/ammJfGSl6OwbFU82JpozB+uMI0V6xEqmTjXu8gGmgwe8c P3wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8UWh8jduGRGu0Lvsdl9eBlyqHKjBe0P0nAH4NaZ9DMc=; b=WUORE2wstQQxguipIjngnkBSLOQ+MGYBsm0UaCWT/O0CxiisHQ4g2MulzQg/NfLIsR 8dA7P3ckFwPjQyBqzvazjWi7gT6SdhlCJX+1lWeXRwtcHJ2+yPO6Hrp7Gy5N2Es0mZHk nIk0crq63wneJVfc8ZiAS5HmSxzw+rhO6ox5kL7eK4byDih5ktxVdjBg4dSaJbg4uwGG EZDBv/9Bl8/Kscje/KQDMUWT5x24WEUfQOJ2fKnwwtyIdOGj/8b4LNZHj0wFY4mZZr+z aeOErpDgrpwcOkA5bVA8XIDxvESKgzCPN4ocjM7ww8ei84BAjr0iFY3O3wK4cMErm5Oe 4//Q== X-Gm-Message-State: AOAM533Y+PdvpLjSwu1iXeBPKfY8m64ER5ghOk1rQZWEprMcGWsIRLec /LhX/t+pMEGXBAfuVP1p4DtoonCMCmg70GNOB822Mg== X-Google-Smtp-Source: ABdhPJxeUlmz8zPz9b/j2QjskVoGdhyZlrSI7oyLSmQ0kLy48DqKvUv7uDS1x5dDFWskiPN5ixGvTOLh0b8L9NlGn5M= X-Received: by 2002:a17:90a:f18d:: with SMTP id bv13mr1625214pjb.13.1613989908932; Mon, 22 Feb 2021 02:31:48 -0800 (PST) MIME-Version: 1.0 References: <20210219104954.67390-1-songmuchun@bytedance.com> <20210219104954.67390-5-songmuchun@bytedance.com> In-Reply-To: From: Muchun Song Date: Mon, 22 Feb 2021 18:31:12 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v16 4/9] mm: hugetlb: alloc the vmemmap pages associated with each HugeTLB page To: Michal Hocko Cc: Jonathan Corbet , Mike Kravetz , Thomas Gleixner , mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, Peter Zijlstra , viro@zeniv.linux.org.uk, Andrew Morton , paulmck@kernel.org, mchehab+huawei@kernel.org, pawan.kumar.gupta@linux.intel.com, Randy Dunlap , oneukum@suse.com, anshuman.khandual@arm.com, jroedel@suse.de, Mina Almasry , David Rientjes , Matthew Wilcox , Oscar Salvador , "Song Bao Hua (Barry Song)" , David Hildenbrand , =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= , Joao Martins , Xiongchun duan , linux-doc@vger.kernel.org, LKML , Linux Memory Management List , linux-fsdevel Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: ejjsjqpi83mnfaqsshg6zz6pi5hyigx4 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 32532E0011E0 Received-SPF: none (bytedance.com>: No applicable sender policy available) receiver=imf30; identity=mailfrom; envelope-from=""; helo=mail-pj1-f42.google.com; client-ip=209.85.216.42 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1613989910-938409 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 22, 2021 at 5:25 PM Michal Hocko wrote: > > On Sat 20-02-21 12:20:36, Muchun Song wrote: > > On Fri, Feb 19, 2021 at 10:12 PM Michal Hocko wrote: > [...] > > > What about hugetlb page poisoning on HW failure (resp. soft offlining)? > > > > If the HW poisoned hugetlb page failed to be dissolved, the page > > will go back to the free list with PG_HWPoison set. But the page > > will not be used, because we will check whether the page is HW > > poisoned when it is dequeued from the free list. If so, we will skip > > this page. > > Can this lead to an under provisioned pool then? Or is there a new > hugetlb allocated to replace the poisoned one? Actually, no page will be allocated. Your concern is right. But without this patch, the result does not change. e.g. The HW poisoned page can fail to be dissolved when h->free_huge_pages is equal to h->resv_huge_pages. But no one seems to have reported this issue so far. Maybe this behavior needs improvement in the feature. > > -- > Michal Hocko > SUSE Labs