From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BEA2C38A29 for ; Tue, 14 Apr 2020 14:40:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3687D2064A for ; Tue, 14 Apr 2020 14:40:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bytedance-com.20150623.gappssmtp.com header.i=@bytedance-com.20150623.gappssmtp.com header.b="Wwje0Rnt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3687D2064A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E04318E0005; Tue, 14 Apr 2020 10:40:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DB56F8E0001; Tue, 14 Apr 2020 10:40:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF2108E0005; Tue, 14 Apr 2020 10:40:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0235.hostedemail.com [216.40.44.235]) by kanga.kvack.org (Postfix) with ESMTP id B4B6A8E0001 for ; Tue, 14 Apr 2020 10:40:32 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 77655181AEF1D for ; Tue, 14 Apr 2020 14:40:32 +0000 (UTC) X-FDA: 76706721504.21.debt75_21c01847b2b02 X-HE-Tag: debt75_21c01847b2b02 X-Filterd-Recvd-Size: 4497 Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Tue, 14 Apr 2020 14:40:31 +0000 (UTC) Received: by mail-io1-f66.google.com with SMTP id n20so13470159ioa.4 for ; Tue, 14 Apr 2020 07:40:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=YbefgXjXgHeUC3P4hR4bxjpF4217ar6Ws14g5K+3oCQ=; b=Wwje0Rntf8ZnrrhqYnDu0SzHV0cPoc8qcICufXPzSHt4np2xlG+adB6yz6d0yfi5/t FFgDG4PgjM/yauxNSgZOCTwIj6893wuEoglOIXx3r004MbrRCwo9dXocnO5wlSvfJog+ W0+yY+0KD0b0zVRCNJfbuEz/+yWWAsVxObApzsBNxpNUBzCJdx6NGf/FW8puQhE227TT 4Lp4U1Wm6g0barnTOOSt/NAegtzSNCMcQ2PAE6mADnANg9fiu/V+r2ZMxOW1Ki8fR5Pu gLVTt1W8cC60zqsETdr9WgpVRoXG8UCjAuClt8OSYww44XXBdM8XDqtjX1FMHvxv+J1t dExg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=YbefgXjXgHeUC3P4hR4bxjpF4217ar6Ws14g5K+3oCQ=; b=ZQE3zNWLj0bt9omRjf0Lz2esZMx6wqVm3WZOVOFqe222G5iMUN3XvbxnwkQ13CHc4h NdDpr/hGvRc6gUPCJGM3z6Km2vL0ZrNtNHwqbMXlK9P6/czYcI52cJpfs4OecCB8QiMb whOantaEdq5Of9kZxmnlSHHyQce+SoGW7O12RqUBN8OVDFtpTEjGAhHc1a7ph4sCGSeL KnJbTJ7Vav8J5+EnnO0bsWz33Hvu87y/eSzbXhEJwUwgiPiQUdEfqZa+mhq1LqRGqFK/ e5a0NT4LOM8FoP5EmLA5qA359Ntcq3EGppOr1mf2lTXoU4y6AwEQOyR7K10U70YibfY4 zKRA== X-Gm-Message-State: AGi0PuYB6apbNZfbOjEVcFKKDs92FEfduIF8YamfOsB8UwU/mpaeSZGa I8mWlaO9los443+cc7x2iuyFOa6BgKSG9eDQ+drM9w== X-Google-Smtp-Source: APiQypIOEDWyBC+MJXnFhM3K3bceWhoQdw2kV3ecdpznyv+m3gsZ+ZKEJD7FpxP9SK4xSRSupxvj9RZtJnPi/kYxX+M= X-Received: by 2002:a02:cca3:: with SMTP id t3mr13412804jap.3.1586875231002; Tue, 14 Apr 2020 07:40:31 -0700 (PDT) MIME-Version: 1.0 References: <20200414075622.69822-1-songmuchun@bytedance.com> <36a7d091-440b-a3db-c93f-713fc7cfbb5c@web.de> In-Reply-To: <36a7d091-440b-a3db-c93f-713fc7cfbb5c@web.de> From: Muchun Song Date: Tue, 14 Apr 2020 22:39:55 +0800 Message-ID: Subject: Re: [External] Re: [v2] mm/ksm: Fix NULL pointer dereference when KSM zero page is enabled To: Markus Elfring Cc: Xiongchun Duan , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000021, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 14, 2020 at 10:17 PM Markus Elfring wro= te: > > >>> to crash when we access vma->vm_mm(its offset is 0x40) later in > >> > >> Will another fine-tuning become relevant also for this wording? > > > > Sorry, I don't understand what this means because of my poor English. > > Our language knowledge can evolve over time. > > > > Could you explain it again. > > You integrated a few of my suggestions into your message selection. - Tha= nks. > I wonder why you did not like the following small adjustment possibilitie= s > so far. > > to a crash =E2=80=A6 vm_mm (its =E2=80=A6 > Thanks a lot. I will fix it. > > >> Will any other tags become helpful in such a case? > > > > How about changing > > "following calltrace is captured in kernel 4.19 with KSM zero page" > > to > > "The following calltrace is captured with the following patch applie= d: > > e86c59b1b12d ("mm/ksm: improve deduplication of zero pages with > > colouring") > > " > > ? > > I find it unlikely that such a wording alternative would be more appropri= ate > while I became just curious for related development consequences around > the usage of a longterm kernel version. > > Would you like to reuse the term =E2=80=9Ccall trace=E2=80=9D? > OK, I will reuse the =E2=80=9Ccall trace=E2=80=9D. Thanks again. Anyone else have any suggestions? If not, I will post another v4 version to fix the commit message that Markus mentioned. --=20 Yours, Muchun