From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17DCAC433E0 for ; Thu, 14 Jan 2021 02:51:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id ACBA62368A for ; Thu, 14 Jan 2021 02:51:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ACBA62368A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D0FA28D00B4; Wed, 13 Jan 2021 21:51:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C98FC8D008E; Wed, 13 Jan 2021 21:51:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5FEB8D00B4; Wed, 13 Jan 2021 21:51:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0005.hostedemail.com [216.40.44.5]) by kanga.kvack.org (Postfix) with ESMTP id 9CF268D008E for ; Wed, 13 Jan 2021 21:51:30 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 587F8824556B for ; Thu, 14 Jan 2021 02:51:30 +0000 (UTC) X-FDA: 77702854740.29.rings50_4a058a227523 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id 30361180A555D for ; Thu, 14 Jan 2021 02:51:30 +0000 (UTC) X-HE-Tag: rings50_4a058a227523 X-Filterd-Recvd-Size: 4527 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Thu, 14 Jan 2021 02:51:29 +0000 (UTC) Received: by mail-pf1-f172.google.com with SMTP id h10so2491904pfo.9 for ; Wed, 13 Jan 2021 18:51:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vnXni1b9tGMKZsQyD1Z1Ra0F8lPxT5GkFopMevAsTu0=; b=pYQzB/dtAMuKglYrXj3uUgOV5H3ciR8TqPH6rKxps2HsuY0YD/UJTUTueQ924tV67x /nw9HW/y7yM+IdcquuDd6rg0qCOTGAyKdU4QdA3NnmK2VgnbP1SwW/2eIJr/f2z/KGg3 bxaEmS+PxFNRC3IjXGCYARb+tqBpoGLgDEK08LhlF/nnflVP+RHfgNAXtArQ4karKE7V 1TIbb8WdwuwY5l8k2HsX3cL+81dk1PaDAOTWANacxhnKOAW9UFbwmkA6bUQVA5Vjdo+A pyr2iP7Phr7B2FPaJRCikMvev+yUXrThxLpEMR9/Xve5A6Ks/H+mR80dJk1Nma2a+mlB shrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vnXni1b9tGMKZsQyD1Z1Ra0F8lPxT5GkFopMevAsTu0=; b=APOCSFPaoctqZmcsThWPmwUr+L3Y8jWV399kg3fWKwg+nKE+2wuZzPiRqQeTbb5okj Av1Em09K1Tudig1gUiGfCe47ErGLg4EbIUgFAf2zttoeKrgQUYPSc5LnkcSzODxKks1T XJlSHjD8JxAscV8SF6QSSXL+c4FB7bJu5Jvu1nOF+irB4Lh6XPtuCU7gjcL7d6bMtgnh FwaCDECgqB1vtq73Gb/SVxEocR6MOrApm2+IG8ZJvBHf3mrUhRHyC3M57mPMTMxWQBVO LxiCbq2X1rn6zPjgzMz214vhQu+rnEwa0jxKuzyp/9zHD/hEIK6UfxRgB5yY1yWyW4ue 1lfg== X-Gm-Message-State: AOAM532iSrUZe5d9TP6HA86fuCdJ6XHNYCd55CcXJBmENhQT95Pyz2t8 k83x0NWi7JJFCkKRiXBdTXaVgQ+gLICi5Ug30R41/A== X-Google-Smtp-Source: ABdhPJwLV2qDiUvnfgyZ4ayaL3nSZneYZNcN8beH+tlzxWuA16IAcL/EsRR5kgOQtXyBkHSnxPqgyqr59MPA1D9rT60= X-Received: by 2002:a63:480f:: with SMTP id v15mr5111575pga.341.1610592688709; Wed, 13 Jan 2021 18:51:28 -0800 (PST) MIME-Version: 1.0 References: <20210106141931.73931-1-songmuchun@bytedance.com> <20210106141931.73931-4-songmuchun@bytedance.com> <65b2103d-6198-3380-d36e-17dd774359bd@oracle.com> In-Reply-To: <65b2103d-6198-3380-d36e-17dd774359bd@oracle.com> From: Muchun Song Date: Thu, 14 Jan 2021 10:50:51 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v12 03/13] mm: Introduce VM_WARN_ON_PAGE macro To: Mike Kravetz Cc: Jonathan Corbet , Thomas Gleixner , mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, Peter Zijlstra , viro@zeniv.linux.org.uk, Andrew Morton , paulmck@kernel.org, mchehab+huawei@kernel.org, pawan.kumar.gupta@linux.intel.com, Randy Dunlap , oneukum@suse.com, anshuman.khandual@arm.com, jroedel@suse.de, Mina Almasry , David Rientjes , Matthew Wilcox , Oscar Salvador , Michal Hocko , "Song Bao Hua (Barry Song)" , David Hildenbrand , =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= , Xiongchun duan , linux-doc@vger.kernel.org, LKML , Linux Memory Management List , linux-fsdevel Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 14, 2021 at 6:31 AM Mike Kravetz wrote: > > On 1/6/21 6:19 AM, Muchun Song wrote: > > Very similar to VM_WARN_ON_ONCE_PAGE and VM_BUG_ON_PAGE, add > > VM_WARN_ON_PAGE macro. > > > > Signed-off-by: Muchun Song > > --- > > include/linux/mmdebug.h | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > I was going to question the use/need for this macro in the following > patch. Looks like Oscar has already done that, and free_bootmem_page > will now use VM_BUG_ON_PAGE. So, this patch can be dropped. In the previous version, Oscar suggested I use WARN_ON instead of BUG_ON. But he realised we actually should use BUG_ON in this version. So I will drop this in the next version. Thanks. > > -- > Mike Kravetz