From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA8CEC432BE for ; Thu, 29 Jul 2021 06:01:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 692AB6108E for ; Thu, 29 Jul 2021 06:01:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 692AB6108E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id D88546B0036; Thu, 29 Jul 2021 02:01:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D3A226B005D; Thu, 29 Jul 2021 02:01:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C00136B006C; Thu, 29 Jul 2021 02:01:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0204.hostedemail.com [216.40.44.204]) by kanga.kvack.org (Postfix) with ESMTP id A3E4D6B0036 for ; Thu, 29 Jul 2021 02:01:10 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 36865250A7 for ; Thu, 29 Jul 2021 06:01:10 +0000 (UTC) X-FDA: 78414577500.07.DE8270D Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by imf14.hostedemail.com (Postfix) with ESMTP id 4BC336005998 for ; Thu, 29 Jul 2021 06:01:09 +0000 (UTC) Received: by mail-pj1-f48.google.com with SMTP id mt6so8764805pjb.1 for ; Wed, 28 Jul 2021 23:01:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OgD5C61YbZ2KunWoqNcKnBbaf1qoas81IHhBsJLKfSM=; b=EnJl/Mx7QLBayu7Yl3kff+Gl9vL7axw9v4cntOhPsXkky2EN/GwFYc2ew6t5qU4Eh2 Csmn/NjeHBKpt1ddqOD9UIPc6Y+5weNm9lJ10a2LP9l52vxd3KmJvfvv4pjj570xYZ2c 6vgl2oDqrpEhPiidu4UN+GbhPO+VGurpaDrmVS9H7qqDQt03nEPD7vQzG9hFzVBG+VJy DnYKIPV4q9xCH+VnuBu4i9UFgJ8jBXx5mEyr59xxYIz+tHOdIoIR7/eYeKVljfdkTUPm VEvq0U525iIPHBay2MJF76CnO47yzAq93gYOmmAZAPnWb5eX0eWjmxxeRzlsq+EV/O1v Pp4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OgD5C61YbZ2KunWoqNcKnBbaf1qoas81IHhBsJLKfSM=; b=AM0A+0lbeK4LFaKVrX/SoVKIcPKvK5xMdUVUoXrKxYJjlwzoxB4yvy7V7XijHcCIyz YoIIaq0qZoRrsmQ/YGEzsGFJIUSreRvSBaqVjUKZpHrbeHLqzI3Sua9os2CJGaCXlLBz o1CuxvM5hnkwkf27KXq/VJxK4wCE2gC4c/ZOrhw9x0nSXgfG8DAiN60vEOqBBZm4hNh3 zg+TJFADarBPOdl4y+ikaLq6IXczm3+jMKVA2wXSwBron6aWYbe5ygNGrvuwc7906RdN DLyWuzefrXSyD1+rofb53PgRb2/fPdT2Vx/9S/6gpfybQHId/p0jwCoTodanhQIIjNF5 1qSQ== X-Gm-Message-State: AOAM532BvHXMC4ch2h+55x78KpQ9RDMdtGZB5nsvXlKq9xf6JwBUIsRv z91LPCuVSSBoo21r2qmMlnayVRfZG40XHSXsRFMB8g== X-Google-Smtp-Source: ABdhPJwgmmS8Q6Z8sSqxjFLXS+0lYHCYezXCZpuTpd9HoPdRfyijBwKfbyNCcV13ys534Nfd6x7nsXbkoqv2rbURjVE= X-Received: by 2002:a17:902:6ac9:b029:12c:3bac:8d78 with SMTP id i9-20020a1709026ac9b029012c3bac8d78mr3101247plt.34.1627538468213; Wed, 28 Jul 2021 23:01:08 -0700 (PDT) MIME-Version: 1.0 References: <20210714091800.42645-1-songmuchun@bytedance.com> <20210714091800.42645-2-songmuchun@bytedance.com> In-Reply-To: From: Muchun Song Date: Thu, 29 Jul 2021 14:00:28 +0800 Message-ID: Subject: Re: [PATCH 1/5] mm: introduce PAGEFLAGS_MASK to replace ((1UL << NR_PAGEFLAGS) - 1) To: Mike Kravetz Cc: Andrew Morton , Oscar Salvador , Michal Hocko , "Song Bao Hua (Barry Song)" , David Hildenbrand , Chen Huang , "Bodeddula, Balasubramaniam" , Jonathan Corbet , Xiongchun duan , fam.zheng@bytedance.com, linux-doc@vger.kernel.org, LKML , Linux Memory Management List , Qi Zheng Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 4BC336005998 Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b="EnJl/Mx7"; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf14.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.216.48 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Stat-Signature: eokq96zn1eagquodbknugrqbps14zjim X-HE-Tag: 1627538469-761820 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 27, 2021 at 2:27 PM Muchun Song wrote: > > On Tue, Jul 27, 2021 at 5:04 AM Mike Kravetz wrote: > > > > On 7/14/21 2:17 AM, Muchun Song wrote: > > > Instead of hard-coding ((1UL << NR_PAGEFLAGS) - 1) everywhere, introducing > > > PAGEFLAGS_MASK to make the code clear to get the page flags. > > > > > > Signed-off-by: Muchun Song > > > --- > > > include/linux/page-flags.h | 4 +++- > > > include/trace/events/page_ref.h | 4 ++-- > > > lib/test_printf.c | 2 +- > > > lib/vsprintf.c | 2 +- > > > 4 files changed, 7 insertions(+), 5 deletions(-) > > > > > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > > > index 5922031ffab6..358d3f6fa976 100644 > > > --- a/include/linux/page-flags.h > > > +++ b/include/linux/page-flags.h > > > @@ -178,6 +178,8 @@ enum pageflags { > > > PG_reported = PG_uptodate, > > > }; > > > > > > +#define PAGEFLAGS_MASK (~((1UL << NR_PAGEFLAGS) - 1)) > > > > Can you explain why you chose this definition instead of > > > > #define PAGEFLAGS_MASK ((1UL << NR_PAGEFLAGS) - 1) > > > > and mostly use ~PAGEFLAGS_MASK below? > > Hi Mike, > > Actually, I learned from PAGE_MASK. So I thought the macro > like xxx_MASK should be the format of 0x00...00ff...ff. I don't ^^^ Sorry. I mean 0xff...ff00...00 here. > know if this is an unwritten rule. Please correct me if I am > wrong. > > Thanks. > > > -- > > Mike Kravetz