From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 787BAC433B4 for ; Wed, 12 May 2021 07:59:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CC8B9613BE for ; Wed, 12 May 2021 07:59:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC8B9613BE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 222116B0036; Wed, 12 May 2021 03:59:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D2446B006E; Wed, 12 May 2021 03:59:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 04CBB6B0070; Wed, 12 May 2021 03:59:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0056.hostedemail.com [216.40.44.56]) by kanga.kvack.org (Postfix) with ESMTP id DDF236B0036 for ; Wed, 12 May 2021 03:59:46 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 9C29B6C1D for ; Wed, 12 May 2021 07:59:46 +0000 (UTC) X-FDA: 78131829972.16.9F680C6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf08.hostedemail.com (Postfix) with ESMTP id AFB0880192E4 for ; Wed, 12 May 2021 07:59:18 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id EAFD1613BF for ; Wed, 12 May 2021 07:59:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620806385; bh=/jbrQezTL8G/ui6Q5vjZ+00LR2hUCslIdKJk+xNCZgY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=dqUIkOHH4A0b11/IJHaaCwCI3sbOltoRHV8RLoBhbUg9wrc3JeVK66bUge4gOmfTd VI27E3h4zuKvm1vDW0+zxiofKuQ5ewAAf7whkg5H0wHe/Rr13KUwFx49LunR1lpJWH iatdg7FSlp5qY1qV+R9Vfn0MyaSWy4MM0N8zLi5FuezPQ7Ji/m2F8aQaQWpzuFGTxb BcPUKT2uSJ79VOF0N/OUYEHCrFcO3bcmUlSnDIBL4fj8feXm7pmQLlU04VX3TaSatn vBLdvuXGKRD6MC93+ifGXhhJqUOwpgbvDAht5+lfPUDjGxGLeCh7HnIwzHJt9zn5Js kuGyGnp6XjrdA== Received: by mail-oi1-f171.google.com with SMTP id d21so21488276oic.11 for ; Wed, 12 May 2021 00:59:44 -0700 (PDT) X-Gm-Message-State: AOAM533HFGPR6WVrytbrabQJKxcxcFOlaceXoVnq/7KItIj5LEH42AGf ynvFQVmRKJhYDOQ/TLdrS11PQ4P2RZlqXiIFIIc= X-Google-Smtp-Source: ABdhPJwiXQK1n/wBurFk/qMzA9zSmBQYyMp/smLZRpZ5mb6HG5OLIvzlMqKlDQM6+S8vLVEBuAav/8FG2yoiJ7+A87A= X-Received: by 2002:aca:4056:: with SMTP id n83mr6713227oia.47.1620806384150; Wed, 12 May 2021 00:59:44 -0700 (PDT) MIME-Version: 1.0 References: <20210511100550.28178-1-rppt@kernel.org> In-Reply-To: From: Ard Biesheuvel Date: Wed, 12 May 2021 09:59:33 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 0/4] arm64: drop pfn_valid_within() and simplify pfn_valid() To: Mike Rapoport Cc: Mike Rapoport , Andrew Morton , Anshuman Khandual , Catalin Marinas , David Hildenbrand , Marc Zyngier , Mark Rutland , Will Deacon , kvmarm , Linux ARM , Linux Kernel Mailing List , Linux Memory Management List Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=dqUIkOHH; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of ardb@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=ardb@kernel.org X-Stat-Signature: 6budwszcwogprjhqrfg6puf1paqgya4u X-Rspamd-Queue-Id: AFB0880192E4 X-Rspamd-Server: rspam02 Received-SPF: none (kernel.org>: No applicable sender policy available) receiver=imf08; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620806358-880876 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 12 May 2021 at 09:34, Mike Rapoport wrote: > > On Wed, May 12, 2021 at 09:00:02AM +0200, Ard Biesheuvel wrote: > > On Tue, 11 May 2021 at 12:05, Mike Rapoport wrote: > > > > > > From: Mike Rapoport > > > > > > Hi, > > > > > > These patches aim to remove CONFIG_HOLES_IN_ZONE and essentially hardwire > > > pfn_valid_within() to 1. > > > > > > The idea is to mark NOMAP pages as reserved in the memory map and restore > > > the intended semantics of pfn_valid() to designate availability of struct > > > page for a pfn. > > > > > > With this the core mm will be able to cope with the fact that it cannot use > > > NOMAP pages and the holes created by NOMAP ranges within MAX_ORDER blocks > > > will be treated correctly even without the need for pfn_valid_within. > > > > > > The patches are boot tested on qemu-system-aarch64. > > > > > > > Did you use EFI boot when testing this? The memory map is much more > > fragmented in that case, so this would be a good data point. > > Right, something like this: > Yes, although it is not always that bad. > [ 0.000000] Early memory node ranges > [ 0.000000] node 0: [mem 0x0000000040000000-0x00000000ffffbfff] > [ 0.000000] node 0: [mem 0x00000000ffffc000-0x00000000ffffffff] This is allocated below 4 GB by the firmware, for reasons that are only valid on x86 (where some of the early boot chain is IA32 only) > [ 0.000000] node 0: [mem 0x0000000100000000-0x00000004386fffff] > [ 0.000000] node 0: [mem 0x0000000438700000-0x000000043899ffff] > [ 0.000000] node 0: [mem 0x00000004389a0000-0x00000004389bffff] > [ 0.000000] node 0: [mem 0x00000004389c0000-0x0000000438b5ffff] > [ 0.000000] node 0: [mem 0x0000000438b60000-0x000000043be3ffff] > [ 0.000000] node 0: [mem 0x000000043be40000-0x000000043becffff] > [ 0.000000] node 0: [mem 0x000000043bed0000-0x000000043bedffff] > [ 0.000000] node 0: [mem 0x000000043bee0000-0x000000043bffffff] > [ 0.000000] node 0: [mem 0x000000043c000000-0x000000043fffffff] > > This is a pity really, because I don't see a fundamental reason for those > tiny holes all over the place. > There is a config option in the firmware build that allows these regions to be preallocated using larger windows, which greatly reduces the fragmentation. > I know that EFI/ACPI mandates "IO style" memory access for those regions, > but I fail to get why... > Not sure what you mean by 'IO style memory access'. > > > I beleive it would be best to route these via mmotm tree. > > > > > > v4: > > > * rebase on v5.13-rc1 > > > > > > v3: Link: https://lore.kernel.org/lkml/20210422061902.21614-1-rppt@kernel.org > > > * Fix minor issues found by Anshuman > > > * Freshen up the declaration of pfn_valid() to make it consistent with > > > pfn_is_map_memory() > > > * Add more Acked-by and Reviewed-by tags, thanks Anshuman and David > > > > > > v2: Link: https://lore.kernel.org/lkml/20210421065108.1987-1-rppt@kernel.org > > > * Add check for PFN overflow in pfn_is_map_memory() > > > * Add Acked-by and Reviewed-by tags, thanks David. > > > > > > v1: Link: https://lore.kernel.org/lkml/20210420090925.7457-1-rppt@kernel.org > > > * Add comment about the semantics of pfn_valid() as Anshuman suggested > > > * Extend comments about MEMBLOCK_NOMAP, per Anshuman > > > * Use pfn_is_map_memory() name for the exported wrapper for > > > memblock_is_map_memory(). It is still local to arch/arm64 in the end > > > because of header dependency issues. > > > > > > rfc: Link: https://lore.kernel.org/lkml/20210407172607.8812-1-rppt@kernel.org > > > > > > Mike Rapoport (4): > > > include/linux/mmzone.h: add documentation for pfn_valid() > > > memblock: update initialization of reserved pages > > > arm64: decouple check whether pfn is in linear map from pfn_valid() > > > arm64: drop pfn_valid_within() and simplify pfn_valid() > > > > > > arch/arm64/Kconfig | 3 --- > > > arch/arm64/include/asm/memory.h | 2 +- > > > arch/arm64/include/asm/page.h | 3 ++- > > > arch/arm64/kvm/mmu.c | 2 +- > > > arch/arm64/mm/init.c | 14 +++++++++++++- > > > arch/arm64/mm/ioremap.c | 4 ++-- > > > arch/arm64/mm/mmu.c | 2 +- > > > include/linux/memblock.h | 4 +++- > > > include/linux/mmzone.h | 11 +++++++++++ > > > mm/memblock.c | 28 ++++++++++++++++++++++++++-- > > > 10 files changed, 60 insertions(+), 13 deletions(-) > > > > > > > > > base-commit: 6efb943b8616ec53a5e444193dccf1af9ad627b5 > > > -- > > > 2.28.0 > > > > > -- > Sincerely yours, > Mike.