From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2764AC56202 for ; Wed, 21 Oct 2020 19:10:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8CB6122447 for ; Wed, 21 Oct 2020 19:10:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="gLg2ILm+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8CB6122447 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EFD256B005D; Wed, 21 Oct 2020 15:10:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EADC86B0062; Wed, 21 Oct 2020 15:10:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D07B96B0068; Wed, 21 Oct 2020 15:10:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0129.hostedemail.com [216.40.44.129]) by kanga.kvack.org (Postfix) with ESMTP id 9F5BC6B005D for ; Wed, 21 Oct 2020 15:10:00 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 4625A8991B20 for ; Wed, 21 Oct 2020 19:10:00 +0000 (UTC) X-FDA: 77396872560.01.fight91_3801c462724a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id 261521004C6C9 for ; Wed, 21 Oct 2020 19:10:00 +0000 (UTC) X-HE-Tag: fight91_3801c462724a X-Filterd-Recvd-Size: 3665 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Wed, 21 Oct 2020 19:09:59 +0000 (UTC) Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8A5952415B for ; Wed, 21 Oct 2020 19:09:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603307398; bh=3mlDknj7gWWP20636gbskByHmbYqyI43SuULks1EPec=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=gLg2ILm+s4gQls2IaDBWp6q28BNsfFHWgWqAIqg1EUPBkgNfd7BHL1Knac8P5TKsO 9zxCd9ExNHO35uuHe+5mmeIJlA+ASBXYF0BwNaTDyKbMkjOIZ74ATXRBXB5ORVY2ok 8ntewJ+KL98hBXWXsqjyAD9j4x/OqkX/+pv+4/Tw= Received: by mail-oi1-f172.google.com with SMTP id k27so579271oij.11 for ; Wed, 21 Oct 2020 12:09:58 -0700 (PDT) X-Gm-Message-State: AOAM5311XubSHladerSH4aG0mDBeheUftMs0DU1FIxB4DXZH8LBRhEFF rh6W3J4xLbkbgjiLLmqBQ34CfHIZRmqulgFMAsk= X-Google-Smtp-Source: ABdhPJxJL56gVA6ltf41CqMODH2MtrRNMi76eXVY5qQKdaQNTz9kdX34PxHKq+Fpybp1eN85dayNjJkiiqGJYxzT3PM= X-Received: by 2002:aca:5a56:: with SMTP id o83mr3085292oib.47.1603307397782; Wed, 21 Oct 2020 12:09:57 -0700 (PDT) MIME-Version: 1.0 References: <1cecfbfc853b2e71a96ab58661037c28a2f9280e.camel@perches.com> In-Reply-To: <1cecfbfc853b2e71a96ab58661037c28a2f9280e.camel@perches.com> From: Ard Biesheuvel Date: Wed, 21 Oct 2020 21:09:46 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH -next] treewide: Remove stringification from __alias macro definition To: Joe Perches Cc: Thomas Gleixner , Borislav Petkov , X86 ML , "H. Peter Anvin" , Miguel Ojeda , Marco Elver , Dmitry Vyukov , Herbert Xu , "David S. Miller" , Andrey Ryabinin , Alexander Potapenko , Andrew Morton , Nick Desaulniers , Linux Kernel Mailing List , linux-efi , kasan-dev , Linux Crypto Mailing List , linux-mm Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 21 Oct 2020 at 21:07, Joe Perches wrote: > > On Wed, 2020-10-21 at 21:02 +0200, Ard Biesheuvel wrote: > > On Wed, 21 Oct 2020 at 20:58, Joe Perches wrote: > > > Like the __section macro, the __alias macro uses > > > macro # stringification to create quotes around > > > the section name used in the __attribute__. > > > > > > Remove the stringification and add quotes or a > > > stringification to the uses instead. > > > > > > > Why? > > Using quotes in __section caused/causes differences > between clang and gcc. > > https://lkml.org/lkml/2020/9/29/2187 > > Using common styles for details like this is good. > > Ah, fair enough. With this rationale added to the commit log: Acked-by: Ard Biesheuvel