From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9FF3C433ED for ; Wed, 12 May 2021 20:08:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 57DEC61418 for ; Wed, 12 May 2021 20:08:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 57DEC61418 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 99CA56B0072; Wed, 12 May 2021 16:08:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 94C196B0073; Wed, 12 May 2021 16:08:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 813A86B0074; Wed, 12 May 2021 16:08:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0029.hostedemail.com [216.40.44.29]) by kanga.kvack.org (Postfix) with ESMTP id 4F6AD6B0072 for ; Wed, 12 May 2021 16:08:36 -0400 (EDT) Received: from smtpin37.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id DCAD18140 for ; Wed, 12 May 2021 20:08:35 +0000 (UTC) X-FDA: 78133666590.37.664F6E9 Received: from mail-il1-f178.google.com (mail-il1-f178.google.com [209.85.166.178]) by imf15.hostedemail.com (Postfix) with ESMTP id DB2FBA001A98 for ; Wed, 12 May 2021 20:08:27 +0000 (UTC) Received: by mail-il1-f178.google.com with SMTP id z1so13367774ils.0 for ; Wed, 12 May 2021 13:08:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=et7R7CkiBcOh5rPRy1gU5hlI1cNaBTCbqm4LHZg8Zx4=; b=nm8EgRh+Gznc4knANPDoo2ziBVaF3bSF5Yeo5IE5f7X0WiM1/Wjq/8K0w1boISLVdV zgWpHstuIhBcvhf4JQwHnGrPmTPuEHiWX27zhKI/Klmg+0GiGiIuJU+DZvae5wMLAdq8 HiaKAZo+48uHbn0xsv3IkSlD9KeiGZ05faRPXFF1kn4Ny8Qe74dpVt9XX565H2yZ4duB y7isslqTiJNEJvOF+Mg9LMHPNzPsfaCeIjt6ZV/J+yLB7Vms0EioMcuHILH560rNUNhp QI8uvmvhXUwzz5UyinP94aaIF7l8eHmAJ/nWEhXB/q3oeZvsqT15wldgDw+CGpvQqh44 WT6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=et7R7CkiBcOh5rPRy1gU5hlI1cNaBTCbqm4LHZg8Zx4=; b=QHso8qkQYw9y0xCjtHMDSjFkIqTKCXadXVyPnGivlsS8Sx6j74x90tECGf/4WH9rN3 KNovnwAIuYsto6Yws/m9eBpPiVrNAoYeHmzQ5vUtkkJaIQirF1wnktr7mRCVEi89FYdU 0xPs7sjxmKL2n8A+FcIklm0QqBq9MDaZTb3I/PB86uT5X/Z3m4L0vCRzhmskSEE71m3b b8T0D6uAGCAQ4HVkcygrs1ycKOA+B8KT+wyItz3pxLoDNgwWVjS1MyCU/F5hUSyquxQR SitD1HrPxASEvHexJOdyxEnKVmbQU54rslM+UXZ2BpG9H3viaguN+tBZWBUtz41OkneB XE5A== X-Gm-Message-State: AOAM532Bkob+Evdr6v6yKAjfyFbTD0++aXCE7dXepQZTnVDd2zE5tpd6 lVjbnrSNAXrogAZMkReY2KuY371MAvPLf4ww+zgX8A== X-Google-Smtp-Source: ABdhPJw8znzrYQILTU1o9QNjwuhaJmEkUNGjIn6LHvI/medWYypCLquMR1a0jo2wevulf3S3UL5JEJ/GuuNNKBpO3Tw= X-Received: by 2002:a92:d988:: with SMTP id r8mr2183838iln.28.1620850114721; Wed, 12 May 2021 13:08:34 -0700 (PDT) MIME-Version: 1.0 References: <441e1c22990205618e1bbff216e0bb83e3b13bae.1620777151.git.pcc@google.com> <20210512121035.GD14638@arm.com> In-Reply-To: <20210512121035.GD14638@arm.com> From: Peter Collingbourne Date: Wed, 12 May 2021 13:08:23 -0700 Message-ID: Subject: Re: [PATCH v2 1/3] kasan: use separate (un)poison implementation for integrated init To: Catalin Marinas Cc: Andrey Konovalov , Alexander Potapenko , Vincenzo Frascino , Andrew Morton , Evgenii Stepanov , Linux Memory Management List , Linux ARM Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=nm8EgRh+; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of pcc@google.com designates 209.85.166.178 as permitted sender) smtp.mailfrom=pcc@google.com X-Stat-Signature: 5so6zc3eekac6135x1or8hbuw7twen8y X-Rspamd-Queue-Id: DB2FBA001A98 X-Rspamd-Server: rspam02 Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf15; identity=mailfrom; envelope-from=""; helo=mail-il1-f178.google.com; client-ip=209.85.166.178 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620850107-440416 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 12, 2021 at 5:10 AM Catalin Marinas wrote: > > On Tue, May 11, 2021 at 04:54:24PM -0700, Peter Collingbourne wrote: > > diff --git a/include/linux/kasan.h b/include/linux/kasan.h > > index b1678a61e6a7..e35fa301d3db 100644 > > --- a/include/linux/kasan.h > > +++ b/include/linux/kasan.h > [...] > > @@ -113,8 +113,30 @@ static inline bool kasan_has_integrated_init(void) > > return false; > > } > > > > +static __always_inline void kasan_alloc_pages(struct page *page, > > + unsigned int order, gfp_t flags) > > +{ > > + /* Only available for integrated init. */ > > + BUG(); > > +} > > + > > +static __always_inline void kasan_free_pages(struct page *page, > > + unsigned int order) > > +{ > > + /* Only available for integrated init. */ > > + BUG(); > > +} > > Would these two work as BUILD_BUG()? It looks like it. This creates a dependency on the compiler being powerful enough to optimize away "if (0) undefined_function();" after inlining, which I'm not really a big fan of, but it looks like we're already doing similar things elsewhere in the kernel, so we might as well do it here as well. Peter