From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C66CC4363A for ; Wed, 28 Oct 2020 09:26:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C5F0624680 for ; Wed, 28 Oct 2020 09:26:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C5F0624680 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D71F06B0068; Wed, 28 Oct 2020 05:26:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D22976B006C; Wed, 28 Oct 2020 05:26:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C11096B006E; Wed, 28 Oct 2020 05:26:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0164.hostedemail.com [216.40.44.164]) by kanga.kvack.org (Postfix) with ESMTP id 907B26B0068 for ; Wed, 28 Oct 2020 05:26:02 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 339C852C9 for ; Wed, 28 Oct 2020 09:26:02 +0000 (UTC) X-FDA: 77420802564.02.books85_5c01dfb27283 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id 1A7F510097AA1 for ; Wed, 28 Oct 2020 09:26:02 +0000 (UTC) X-HE-Tag: books85_5c01dfb27283 X-Filterd-Recvd-Size: 4392 Received: from mail-oo1-f67.google.com (mail-oo1-f67.google.com [209.85.161.67]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Wed, 28 Oct 2020 09:26:01 +0000 (UTC) Received: by mail-oo1-f67.google.com with SMTP id u5so1017131oot.0 for ; Wed, 28 Oct 2020 02:26:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+XN02PSejXD+FeqWTrgwKvG1TTSDYTM2yrZb6ygptq8=; b=GqU75m3liAoO1iYwEZnybwOwgDrgGRk5KNIDEBJ04xecyuAMXLkGEMI2Rz5urK4Olm RqjrVAs0FeCGJ8XfHZ3UKnQ90X29wbB2/d+VvP6yPbkJrC9EMbQ39QSTsFyG27vhlGST 0U/nd3E9tvRS2yU0VjutCXtwJDFHTdZz/oogQeMuHPOn/5AHh7MRFjXFeN0tRJvL++5k nKubvOoztbZaQKddItz1SmSUgO6lvY+yT/doTrFLmSTkUWrGabfT7Ov8Dv9xkB54+orv 2SQ8S2QxTLDkILBuoKGj1wWel/TmIe/HifihKMKGIUryGN10IUUXurZyH+Gj8qdqM9+K m1nQ== X-Gm-Message-State: AOAM533fup5FyAmkS5kfl+1SjEkFIWi4wdtj3ytJ7zbYmqd/l4lHAYr9 0DyqvfSjPSZhb5i9jPFTT/4kNwgTYSj45vc65Zw= X-Google-Smtp-Source: ABdhPJwVZzki+tgZs/Q8WXcxtVj9dxZr8/KAouxapBQlbbCT10SMVoqLjSjBsdSeiewzamwEvqLH3hEqv+123K4FYD8= X-Received: by 2002:a4a:5d84:: with SMTP id w126mr4993384ooa.1.1603877160928; Wed, 28 Oct 2020 02:26:00 -0700 (PDT) MIME-Version: 1.0 References: <20201027112955.14157-1-rppt@kernel.org> <20201027112955.14157-12-rppt@kernel.org> In-Reply-To: <20201027112955.14157-12-rppt@kernel.org> From: Geert Uytterhoeven Date: Wed, 28 Oct 2020 10:25:49 +0100 Message-ID: Subject: Re: [PATCH 11/13] m68k/mm: make node data and node setup depend on CONFIG_DISCONTIGMEM To: Mike Rapoport Cc: Andrew Morton , Alexey Dobriyan , Catalin Marinas , Greg Ungerer , John Paul Adrian Glaubitz , Jonathan Corbet , Matt Turner , Meelis Roos , Michael Schmitz , Mike Rapoport , Russell King , Tony Luck , Vineet Gupta , Will Deacon , alpha , Linux ARM , "open list:DOCUMENTATION" , Linux FS Devel , "linux-ia64@vger.kernel.org" , Linux Kernel Mailing List , linux-m68k , Linux MM , arcml Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Mike, On Tue, Oct 27, 2020 at 12:31 PM Mike Rapoport wrote: > From: Mike Rapoport > > The pg_data_t node structures and their initialization currently depends on > !CONFIG_SINGLE_MEMORY_CHUNK. Since they are required only for DISCONTIGMEM > make this dependency explicit and replace usage of > CONFIG_SINGLE_MEMORY_CHUNK with CONFIG_DISCONTIGMEM where appropriate. > > The CONFIG_SINGLE_MEMORY_CHUNK was implicitly disabled on the ColdFire MMU > variant, although it always presumed a single memory bank. As there is no > actual need for DISCONTIGMEM in this case, make sure that ColdFire MMU > systems set CONFIG_SINGLE_MEMORY_CHUNK to 'y'. > > Signed-off-by: Mike Rapoport Thanks for your patch! > --- > arch/m68k/Kconfig.cpu | 6 +++--- > arch/m68k/include/asm/page_mm.h | 2 +- > arch/m68k/mm/init.c | 4 ++-- > 3 files changed, 6 insertions(+), 6 deletions(-) Is there any specific reason you didn't convert the checks for CONFIG_SINGLE_MEMORY_CHUNK in arch/m68k/kernel/setup_mm.c and arch/m68k/include/asm/virtconvert.h? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds