From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D12E3C433E0 for ; Mon, 29 Jun 2020 15:41:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7611D253E0 for ; Mon, 29 Jun 2020 15:41:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7611D253E0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BDF2B6B0073; Mon, 29 Jun 2020 11:41:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B8FAC6B0075; Mon, 29 Jun 2020 11:41:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7F616B007B; Mon, 29 Jun 2020 11:41:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0139.hostedemail.com [216.40.44.139]) by kanga.kvack.org (Postfix) with ESMTP id 905FE6B0073 for ; Mon, 29 Jun 2020 11:41:56 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 0B573181AC9C6 for ; Mon, 29 Jun 2020 15:41:56 +0000 (UTC) X-FDA: 76982665032.16.knee00_2301d5826e70 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id CF07F100E6903 for ; Mon, 29 Jun 2020 15:41:55 +0000 (UTC) X-HE-Tag: knee00_2301d5826e70 X-Filterd-Recvd-Size: 4744 Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Mon, 29 Jun 2020 15:41:55 +0000 (UTC) Received: by mail-ot1-f68.google.com with SMTP id q21so8397280otc.7 for ; Mon, 29 Jun 2020 08:41:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=18DuSBZeLijFT5byeb07kqFnxpD8Og5k3o71uVKMsdg=; b=QMlCHBJ/KPjmQK4VStqDasbEMpZPHbH3ljTdw0Lz4PpyRyZrJaR1ndDRzDDobnDgzX TR1fMCMfqe/BAQEetknbq0A6K7ms7A7jUDiKkHYNGjVWc4kro9zRyHoE/z9r5cTQINmK IeRcpGIfZKfYO8uVKDuoBs8jD0i5IlZKF8hPlE7MnOdManpx/707lWGt87QiEI8WWYbg PfaOrFYv5MMVt2Bzq4A175cYdiXid7bipQsnJ8Ma71dnzoxNf9I2JegGqfpvR42XIBl6 G5L8ekpxTYsj4iX46ndR7ZD+Y3Ev7+BIclBNRzbPurssiUI6Lx0+NjjKlCUH3IQ51N8j ps7Q== X-Gm-Message-State: AOAM5311jyG+kB23NPifbty/lJPlOqzrK00MS1u2p0PVEenCbT4lcP4w xZH9xGvYpYjRBWcIvelpWv0W6EFC8w9t71sbkjw= X-Google-Smtp-Source: ABdhPJyfGDnofAtWY6Vq9zQSiEjHHywgsNVHJzUbnOYeAK8rSOSVeLQNZQAOcMed2+/KO3c+bzP8Q5CiqDzs7aUNX9g= X-Received: by 2002:a05:6830:1451:: with SMTP id w17mr1238896otp.250.1593445314725; Mon, 29 Jun 2020 08:41:54 -0700 (PDT) MIME-Version: 1.0 References: <20200627143453.31835-1-rppt@kernel.org> <20200627143453.31835-2-rppt@kernel.org> In-Reply-To: <20200627143453.31835-2-rppt@kernel.org> From: Geert Uytterhoeven Date: Mon, 29 Jun 2020 17:41:43 +0200 Message-ID: Subject: Re: [PATCH 1/8] mm: remove unneeded includes of To: Mike Rapoport Cc: Linux Kernel Mailing List , Abdul Haleem , Andrew Morton , Andy Lutomirski , Arnd Bergmann , Christophe Leroy , Joerg Roedel , Max Filippov , Mike Rapoport , Peter Zijlstra , Satheesh Rajendran , Stafford Horne , Stephen Rothwell , Steven Rostedt , alpha , Linux-Arch , Linux ARM , linux-csky@vger.kernel.org, "open list:QUALCOMM HEXAGON..." , "linux-ia64@vger.kernel.org" , linux-m68k , "open list:BROADCOM NVRAM DRIVER" , Linux MM , Parisc List , linux-riscv , linux-s390 , Linux-sh list , arcml , linux-um , "open list:TENSILICA XTENSA PORT (xtensa)" , linuxppc-dev , Openrisc , sparclinux Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: CF07F100E6903 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jun 27, 2020 at 4:35 PM Mike Rapoport wrote: > From: Mike Rapoport > > In the most cases header is required only for allocations > of page table memory. Most of the .c files that include that header do not > use symbols declared in and do not require that header. > > As for the other header files that used to include , it is > possible to move that include into the .c file that actually uses symbols > from and drop the include from the header file. > > The process was somewhat automated using > > sed -i -E '/[<"]asm\/pgalloc\.h/d' \ > $(grep -L -w -f /tmp/xx \ > $(git grep -E -l '[<"]asm/pgalloc\.h')) > > where /tmp/xx contains all the symbols defined in > arch/*/include/asm/pgalloc.h. > > Signed-off-by: Mike Rapoport For the m68k part: Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds