From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA706C433F5 for ; Thu, 10 Feb 2022 15:19:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6633A6B0073; Thu, 10 Feb 2022 10:19:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 612CD6B0074; Thu, 10 Feb 2022 10:19:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DCE46B0075; Thu, 10 Feb 2022 10:19:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0249.hostedemail.com [216.40.44.249]) by kanga.kvack.org (Postfix) with ESMTP id 3C9606B0073 for ; Thu, 10 Feb 2022 10:19:23 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id EDF068E575 for ; Thu, 10 Feb 2022 15:19:22 +0000 (UTC) X-FDA: 79127229006.08.2C4C3FE Received: from mail-vs1-f42.google.com (mail-vs1-f42.google.com [209.85.217.42]) by imf26.hostedemail.com (Postfix) with ESMTP id 83BE5140002 for ; Thu, 10 Feb 2022 15:19:22 +0000 (UTC) Received: by mail-vs1-f42.google.com with SMTP id m24so6776826vsp.7 for ; Thu, 10 Feb 2022 07:19:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4us6o/cNpkSDYz9YOKk+ti1q/OlliOceGfkUTtwngBc=; b=AgIRnWYHLTBzZPhMcZNe3cPoP4gDJvoh4L3Irn72tYDFLBvOlTpxFmq+5DPRVLBIed Ei1L3sYvwvZR46VRQYwUaOAdttu0gRZkoQvR45omQMmfsxwbyLgSuauGS5ZJJLgkBwd8 xOZMoV4bEh/xfLsQLC/vyIxz4RMSh0IAo/ePZfdWK4rlbtjVyNxh++g+lexbQyjl3iP8 jnWcOoQAabIMk9YVV2KvnxcTBRVqZfqUx6uzdLQLqjdwqta1D0mr0gMY3O9O+c+Igye7 GdvkU2GKyZkowaXugFA0AEBrSVgRNmHyig8BMM3dlio1DpaT/Kf7jHMGr2dd+UHxKRJX kmVw== X-Gm-Message-State: AOAM531yf8bWUz3WJyzGhIwoKPeUtS8KeYGdx535MZSwOUp0cIGoarp4 aVTW9DzJriKpAkM8GKXYMP/PQU/sCO0ZPw== X-Google-Smtp-Source: ABdhPJx35AKz5VkMs7ukqPFMqkIjapEWMqrgaKZ6LzhtZmfozFQqjD0TnxY7VxQ3To5ZIc1osMeU8g== X-Received: by 2002:a05:6102:6ce:: with SMTP id m14mr2504206vsg.7.1644506361678; Thu, 10 Feb 2022 07:19:21 -0800 (PST) Received: from mail-ua1-f47.google.com (mail-ua1-f47.google.com. [209.85.222.47]) by smtp.gmail.com with ESMTPSA id m25sm1412584vsl.13.2022.02.10.07.19.19 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Feb 2022 07:19:20 -0800 (PST) Received: by mail-ua1-f47.google.com with SMTP id g18so3171512uak.5 for ; Thu, 10 Feb 2022 07:19:19 -0800 (PST) X-Received: by 2002:ab0:384c:: with SMTP id h12mr2566245uaw.122.1644506359681; Thu, 10 Feb 2022 07:19:19 -0800 (PST) MIME-Version: 1.0 References: <164420889455.29374.17958998143835612560.stgit@noble.brown> <164420916109.29374.8959231877111146366.stgit@noble.brown> In-Reply-To: <164420916109.29374.8959231877111146366.stgit@noble.brown> From: Geert Uytterhoeven Date: Thu, 10 Feb 2022 16:19:07 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 01/21] MM: create new mm/swap.h header file. To: NeilBrown Cc: Trond Myklebust , Anna Schumaker , Chuck Lever , Andrew Morton , Mark Hemment , Christoph Hellwig , David Howells , "open list:NFS, SUNRPC, AND..." , Linux MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: if1joma56fqaz4tj7nmiaw3be87tax3g X-Rspam-User: Authentication-Results: imf26.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf26.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.217.42 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 83BE5140002 X-HE-Tag: 1644506362-83379 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Neil, On Wed, Feb 9, 2022 at 10:52 AM NeilBrown wrote: > Many functions declared in include/linux/swap.h are only used within mm/ > > Create a new "mm/swap.h" and move some of these declarations there. > Remove the redundant 'extern' from the function declarations. > > Reviewed-by: Christoph Hellwig > Signed-off-by: NeilBrown Thanks for your patch! > --- /dev/null > +++ b/mm/swap.h > @@ -0,0 +1,129 @@ > + scripts/checkpatch.pl: WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds