From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Tobin C . Harding" <me@tobin.cc>, linux-mm <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/slab: Do not hash pointers when debugging slab
Date: Mon, 11 Dec 2017 09:08:15 +0100 [thread overview]
Message-ID: <CAMuHMdUugcEPjN+1KoLocpe0GsoXoi5qeXMXvfQSbhm5XDjv7Q@mail.gmail.com> (raw)
In-Reply-To: <CA+55aFzE0Z98KRT4rk3f3R0BcMqGMrHWHsaB9Aq02etwWm_hjg@mail.gmail.com>
Hi Linus,
On Sun, Dec 10, 2017 at 9:45 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
> On Thu, Dec 7, 2017 at 2:17 AM, Geert Uytterhoeven
> <geert+renesas@glider.be> wrote:
>> - pr_err("Slab corruption (%s): %s start=%p, len=%d\n",
>> + pr_err("Slab corruption (%s): %s start=%px, len=%d\n",
>> print_tainted(), cachep->name,
>> realobj, size);
>
> and here, is the pointer actually interesting, or should we just give
> the offset to the allocation?
The pointer may help to identify e.g. an empty list_head in the written data.
> But if the pointer is interesting, then ack.
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-12-11 8:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 10:17 [PATCH] mm/slab: Do not hash pointers when debugging slab Geert Uytterhoeven
2017-12-07 11:13 ` Christopher Lameter
2017-12-07 18:43 ` Kees Cook
2017-12-07 20:15 ` Christopher Lameter
2017-12-10 20:45 ` Linus Torvalds
2017-12-11 8:08 ` Geert Uytterhoeven [this message]
2017-12-11 12:00 ` Christopher Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdUugcEPjN+1KoLocpe0GsoXoi5qeXMXvfQSbhm5XDjv7Q@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=geert+renesas@glider.be \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=me@tobin.cc \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).