From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 887C4CA9ECF for ; Mon, 4 Nov 2019 09:53:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4BE6421D7D for ; Mon, 4 Nov 2019 09:53:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4BE6421D7D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D7FB86B0005; Mon, 4 Nov 2019 04:53:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D09656B0006; Mon, 4 Nov 2019 04:53:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BCF986B0007; Mon, 4 Nov 2019 04:53:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0063.hostedemail.com [216.40.44.63]) by kanga.kvack.org (Postfix) with ESMTP id A2F386B0005 for ; Mon, 4 Nov 2019 04:53:50 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 3BF35180AD81A for ; Mon, 4 Nov 2019 09:53:50 +0000 (UTC) X-FDA: 76118133420.02.unit15_216fb90654331 X-HE-Tag: unit15_216fb90654331 X-Filterd-Recvd-Size: 6316 Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Mon, 4 Nov 2019 09:53:49 +0000 (UTC) Received: by mail-ot1-f66.google.com with SMTP id 77so9418503oti.12 for ; Mon, 04 Nov 2019 01:53:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=KliwOsaW5hNOlzjps3zd+1fC4WckuXEun2JezrBsl8M=; b=NrRXbSss20GtieK67GwvrhiQ0w0Q1QsDOoae21UxvvaOocBimza49joCw7kMs8ZIf5 SUFqRjDN0fD9oWj43gHSaATmZ+VP2gdXEHw0Rh/T6bUOoI9c1pxGy6ZRd4rqTvCWqdb5 QIjx1pdvml/MhiQJgBX0v+YCmwtgumq3oMUm/YAldv/3CoySPhEA2UcR8D1KlIb7c0Ed GBolqzuVhWDsSF8XXMzC59kVUSwnAgMfrALFi9f6rae7mIxokF6QPfcnuz4anIMkJt6I nyNil0jeN0NOkRX7nDCYvgV0OpF/rq1sRi/lRqbzzttHNjz1x89w0oa811jRoROjB8VJ /tEQ== X-Gm-Message-State: APjAAAV34hPcdA/9HYx+PrD0Fs+znY8/EjO/xUNNRsN36hv3p4TKNnE4 FL3Ow62yrgC/+7QvXZ+zvtF8xX4NjEh+iPeBTxI= X-Google-Smtp-Source: APXvYqx7SaMbfn6eTvQqNR3qc8KtXh3qCjyaO/t3VTJ32GC2iIHqF0HiXvHrmlIBpl/gTi7AjGyf/NSZNGOTan5JhFg= X-Received: by 2002:a9d:73cd:: with SMTP id m13mr18480198otk.145.1572861228733; Mon, 04 Nov 2019 01:53:48 -0800 (PST) MIME-Version: 1.0 References: <1572850587-20314-1-git-send-email-rppt@kernel.org> <1572850587-20314-6-git-send-email-rppt@kernel.org> <20191104094748.GB23288@rapoport-lnx> In-Reply-To: <20191104094748.GB23288@rapoport-lnx> From: Geert Uytterhoeven Date: Mon, 4 Nov 2019 10:53:37 +0100 Message-ID: Subject: Re: [PATCH v3 05/13] m68k: mm: use pgtable-nopXd instead of 4level-fixup To: Mike Rapoport Cc: Linux MM , Andrew Morton , Anton Ivanov , Arnd Bergmann , "David S. Miller" , Greentime Hu , Greg Ungerer , Helge Deller , "James E.J. Bottomley" , Jeff Dike , "Kirill A. Shutemov" , Linus Torvalds , Mark Salter , Matt Turner , Michal Simek , Peter Rosin , Richard Weinberger , Rolf Eike Beer , Russell King , Sam Creasey , Vincent Chen , Vineet Gupta , alpha , Linux-Arch , Linux ARM , linux-c6x-dev@linux-c6x.org, Linux Kernel Mailing List , linux-m68k , Parisc List , linux-um@lists.infradead.org, sparclinux , Mike Rapoport Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Mike, On Mon, Nov 4, 2019 at 10:48 AM Mike Rapoport wrote: > On Mon, Nov 04, 2019 at 09:53:34AM +0100, Geert Uytterhoeven wrote: > > On Mon, Nov 4, 2019 at 7:57 AM Mike Rapoport wrote: > > > From: Mike Rapoport > > > m68k has two or three levels of page tables and can use appropriate > > > pgtable-nopXd and folding of the upper layers. > > > > > > Replace usage of include/asm-generic/4level-fixup.h and explicit > > > definitions of __PAGETABLE_PxD_FOLDED in m68k with > > > include/asm-generic/pgtable-nopmd.h for two-level configurations and = with > > > include/asm-generic/pgtable-nopud.h for three-lelve configurations an= d > > > adjust page table manipulation macros and functions accordingly. > > > > > > Signed-off-by: Mike Rapoport > > > Acked-by: Greg Ungerer > > > > Thanks for your patch! > > > > The build error reported for v1 by kbuild test robot when building for > > sun3x is still there (m68k defconfig or sun3x_defconfig): > > > > arch/m68k/sun3x/dvma.c: In function =E2=80=98dvma_map_cpu=E2=80=99: > > arch/m68k/sun3x/dvma.c:98:33: error: passing argument 2 of > > =E2=80=98pmd_alloc=E2=80=99 from incompatible pointer type > > [-Werror=3Dincompatible-pointer-types] > > if((pmd =3D pmd_alloc(&init_mm, pgd, vaddr)) =3D=3D NULL) { > > ^~~ > > In file included from arch/m68k/sun3x/dvma.c:17: > > include/linux/mm.h:1875:61: note: expected =E2=80=98pud_t *=E2=80= =99 {aka =E2=80=98struct > > *=E2=80=99} but argument is of type =E2=80=98pgd_t *=E2=80= =99 {aka =E2=80=98struct > > *=E2=80=99} > > static inline pmd_t *pmd_alloc(struct mm_struct *mm, pud_t *pud, > > unsigned long address) > > ~~~~~~~^~~ > > The initial report was against older mmotm (base: > git://git.cmpxchg.org/linux-mmotm.git master) and I presumed this was the > cause of the error. Will fix in v4. OK, thanks! My tree is based on m68k/master, which does not include the mmotm tree, and should be fairly similar to plain v5.4-rc6. > > This indeed boots fine on ARAnyM, which emulates on 68040. > > It would be good to have some boot testing on '020/030, too. > > To be honest, I have no idea how to to that :) Sure. This was more a request for the fellow m68k users. But don't worry too much about it. If it breaks '020/'030, we can fix that later. Thanks! Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds