From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4F83C433F5 for ; Mon, 7 Feb 2022 13:51:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 35D6D6B0074; Mon, 7 Feb 2022 08:51:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 30C126B0075; Mon, 7 Feb 2022 08:51:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D3286B0078; Mon, 7 Feb 2022 08:51:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0022.hostedemail.com [216.40.44.22]) by kanga.kvack.org (Postfix) with ESMTP id 09C816B0074 for ; Mon, 7 Feb 2022 08:51:31 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id AD3C9181D3976 for ; Mon, 7 Feb 2022 13:51:30 +0000 (UTC) X-FDA: 79116121140.30.95D0155 Received: from mail-ua1-f44.google.com (mail-ua1-f44.google.com [209.85.222.44]) by imf12.hostedemail.com (Postfix) with ESMTP id 58F6440004 for ; Mon, 7 Feb 2022 13:51:30 +0000 (UTC) Received: by mail-ua1-f44.google.com with SMTP id w18so19558160uar.8 for ; Mon, 07 Feb 2022 05:51:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=fUAjBprB67NHx4X4sNT3As+x8i0b1+huuPKs3QJNjwY=; b=txJcxgjpaC2tx72gm788TwnsKXOyhpUNJwfTH5JyUhkWI13dA/iQUVu3nZcpcT/KJa phnD5+fQQuNKcOYNJqg1opvAI7GsItzCs7A1kNTFbdV7lLCCdo9p15ZRn6Nu/5UqbzGt 4O5zYYj8QZgawhP9bNz6fnY+S5bY5ffBk2fzpEMzh74LAe2hZTiXCyZODCzkTB9T0qvQ BLPxeCTtDRpm0N/lhw1YDiC5+oB9EAOBd2gWle0MRMUdQOw7TiPoxIi91WBimxrf89mJ 4xR5QmsWq1IjTqhFUiw7g9OGxxiRs0JWnIdn/0gdAJUkuid5HCz/0Sr/QeBZl9AwNEMA KNRA== X-Gm-Message-State: AOAM530mer8WecJbUgSha29RNoZx1coUe7L1MUmCxUyBalzUhPd9mnHy D/EJi1QrpFxwzBgyJ6msepTAzWVlwuKZuQ== X-Google-Smtp-Source: ABdhPJxT/13h0j5orTclA5nEPi8AZIEKyvRjaKjEBp6pDhererMJ0syk4IUpCFiXKB7NslMbh8/bCg== X-Received: by 2002:a05:6102:3ecf:: with SMTP id n15mr1800863vsv.45.1644241889574; Mon, 07 Feb 2022 05:51:29 -0800 (PST) Received: from mail-vk1-f175.google.com (mail-vk1-f175.google.com. [209.85.221.175]) by smtp.gmail.com with ESMTPSA id o131sm2317820vkc.42.2022.02.07.05.51.28 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Feb 2022 05:51:29 -0800 (PST) Received: by mail-vk1-f175.google.com with SMTP id z15so7810956vkp.13 for ; Mon, 07 Feb 2022 05:51:28 -0800 (PST) X-Received: by 2002:a1f:2555:: with SMTP id l82mr5141143vkl.7.1644241888621; Mon, 07 Feb 2022 05:51:28 -0800 (PST) MIME-Version: 1.0 References: <164299573337.26253.7538614611220034049.stgit@noble.brown> <164299611271.26253.2968456569309914722.stgit@noble.brown> In-Reply-To: <164299611271.26253.2968456569309914722.stgit@noble.brown> From: Geert Uytterhoeven Date: Mon, 7 Feb 2022 14:51:17 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 01/23] MM: create new mm/swap.h header file. To: NeilBrown Cc: Trond Myklebust , Anna Schumaker , Chuck Lever , Andrew Morton , Mel Gorman , Christoph Hellwig , David Howells , "open list:NFS, SUNRPC, AND..." , Linux MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 58F6440004 X-Rspam-User: nil Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf12.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.222.44 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com X-Stat-Signature: go3qjpdozt7nzcmjh8nug5a5ywr185sz X-HE-Tag: 1644241890-730506 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Neil, On Mon, Jan 24, 2022 at 5:26 PM NeilBrown wrote: > Many functions declared in include/linux/swap.h are only used within mm/ > > Create a new "mm/swap.h" and move some of these declarations there. > Remove the redundant 'extern' from the function declarations. > > Reviewed-by: Christoph Hellwig > Signed-off-by: NeilBrown Thanks for your patch! mm/huge_memory.c: In function =E2=80=98__split_huge_page=E2=80=99: mm/huge_memory.c:2423:16: error: implicit declaration of function =E2=80=98swap_address_space=E2=80=99; did you mean =E2=80=98exit_swap_addre= ss_space=E2=80=99? [-Werror=3Dimplicit-function-declaration] 2423 | swap_cache =3D swap_address_space(entry); | ^~~~~~~~~~~~~~~~~~ | exit_swap_address_space mm/huge_memory.c needs to #include "swap.h", too. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds